Re: [PATCH] staging: rtl8723bs: fix coding style in HalBtc8723b2Ant.c

[Fahmy Hassan <fahmymohammed@gmail.com>]

Hi Bera,

Thanks for the suggestion, that makes sense. I will include that change in the next version of the patch.
Apologies for any garbled emails; I’m still learning this format. 

Best,
Fahmy




Fahmy Hassan | C# Backend Engineer


Sent from MacOS
Please consider the environment before printing this e-mail



> On Sep 9, 2026, at 9:17 AM, Fahmy Hassan <fahmymohammed@gmail.com> wrote:
> 
> Hi Bera,
> 
> Thanks for the suggestion, that makes sense. I will include that change in the next version of the patch.
> 
> Best,
> Fahmy
> 
> 
> 
> On Wed, Sep 9, 2026 at 6:36 AM <b9788213@gmail.com> wrote:
> On Mon 7 Sep 2026 20:57:57 -0600, Fahmy Hassan wrote:
> > Address checkpatch.pl warnings listed in the driver's TODO file:
> > remove braces around single-statement if/else arms, wrap function
> > calls that exceed the 100 column limit, and move trailing comments
> > that pushed lines over the limit onto their own line above the
> > statement they document.
> 
> ...
> 
> > -                             if (bBtHsOn) {
> > -                             } else {
> > +                             if (bBtHsOn)
> > +                                     ;
> > +                             else
> >                                       algorithm = BT_8723B_2ANT_COEX_ALGO_PANEDR_HID;
> > -                             }
> 
> You can use something like
> 
> if (!bBtHsOn)
>         algorithm = BT_8723B_2ANT_COEX_ALGO_PANEDR_HID;
> 
> Thanks,
> Bera