* [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200
@ 2026-09-09 12:56 julianbraha
2026-09-09 12:59 ` Arnd Bergmann
2026-09-09 13:06 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: julianbraha @ 2026-09-09 12:56 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai
Cc: ckeepax, linux-sound, linux-kernel, arnd, julianbraha
SND_SOC_DB1200 selects SND_SOC_WM8731_I2C without ensuring its
dependency, I2C is enabled. This causes an unmet dependency when
SND_SOC_DB1200 is enabled without I2C.
Let's add a dependency on I2C, as similar options in this subsystem do.
This unmet dependency was found by kconfirm, a static analysis tool for
Kconfig.
Fixes: 9dc15f81baf2 ("ASoC: wm8731: Factor out the I2C and SPI bus code into separate modules")
Signed-off-by: julianbraha <julianbraha@gmail.com>
---
sound/soc/au1x/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/au1x/Kconfig b/sound/soc/au1x/Kconfig
index a7630897bc0b..e8986da24d64 100644
--- a/sound/soc/au1x/Kconfig
+++ b/sound/soc/au1x/Kconfig
@@ -55,6 +55,7 @@ config SND_SOC_DB1000
config SND_SOC_DB1200
tristate "DB1200/DB1300/DB1550 Audio support"
+ depends on I2C
depends on SND_SOC_AU1XPSC
select SND_SOC_AU1XPSC_AC97
select SND_SOC_AC97_CODEC
--
2.55.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200
2026-09-09 12:56 [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200 julianbraha
@ 2026-09-09 12:59 ` Arnd Bergmann
2026-09-09 13:06 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2026-09-09 12:59 UTC (permalink / raw)
To: Julian Braha, lgirdwood, Mark Brown, Jaroslav Kysela, tiwai
Cc: Charles Keepax, linux-sound, linux-kernel
On Wed, Sep 9, 2026, at 14:56, julianbraha wrote:
> SND_SOC_DB1200 selects SND_SOC_WM8731_I2C without ensuring its
> dependency, I2C is enabled. This causes an unmet dependency when
> SND_SOC_DB1200 is enabled without I2C.
>
> Let's add a dependency on I2C, as similar options in this subsystem do.
>
> This unmet dependency was found by kconfirm, a static analysis tool for
> Kconfig.
>
> Fixes: 9dc15f81baf2 ("ASoC: wm8731: Factor out the I2C and SPI bus code
> into separate modules")
>
> Signed-off-by: julianbraha <julianbraha@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200
2026-09-09 12:56 [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200 julianbraha
2026-09-09 12:59 ` Arnd Bergmann
@ 2026-09-09 13:06 ` Mark Brown
2026-09-09 13:14 ` Julian Braha
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2026-09-09 13:06 UTC (permalink / raw)
To: julianbraha
Cc: lgirdwood, perex, tiwai, ckeepax, linux-sound, linux-kernel, arnd
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
On Wed, Sep 09, 2026 at 01:56:36PM +0100, julianbraha wrote:
> SND_SOC_DB1200 selects SND_SOC_WM8731_I2C without ensuring its
> dependency, I2C is enabled. This causes an unmet dependency when
> SND_SOC_DB1200 is enabled without I2C.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200
2026-09-09 13:06 ` Mark Brown
@ 2026-09-09 13:14 ` Julian Braha
0 siblings, 0 replies; 4+ messages in thread
From: Julian Braha @ 2026-09-09 13:14 UTC (permalink / raw)
To: Mark Brown
Cc: lgirdwood, perex, tiwai, ckeepax, linux-sound, linux-kernel, arnd
On 9/9/26 14:06, Mark Brown wrote:
> On Wed, Sep 09, 2026 at 01:56:36PM +0100, julianbraha wrote:
>> SND_SOC_DB1200 selects SND_SOC_WM8731_I2C without ensuring its
>> dependency, I2C is enabled. This causes an unmet dependency when
>> SND_SOC_DB1200 is enabled without I2C.
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
Got it, will do better on this. Thanks for your feedback, Mark.
- Julian Braha
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-09 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-09 12:56 [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200 julianbraha
2026-09-09 12:59 ` Arnd Bergmann
2026-09-09 13:06 ` Mark Brown
2026-09-09 13:14 ` Julian Braha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®