* [PATCH] fs/proc: avoid unused ctl_table entry in init_header
@ 2026-09-09 16:32 Safety 1
0 siblings, 0 replies; only message in thread
From: Safety 1 @ 2026-09-09 16:32 UTC (permalink / raw)
To: kees; +Cc: joel.granados, linux-kernel, linux-fsdevel, Safety 1
The entry variable in init_header() is only used by
list_for_each_table_entry() for iteration and is never read. With
-Werror=unused-but-set-variable, this causes the build to fail.
Use the table size directly for the loop since the entry value is
not needed here.
Tested with: make -j$(nproc)
Signed-off-by: Safety 1 <176830914+JokerPython3@users.noreply.github.com>
---
fs/proc/proc_sysctl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 04a382178..ddc510def 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -206,9 +206,7 @@ static void init_header(struct ctl_table_header *head,
head->node = node;
INIT_HLIST_HEAD(&head->inodes);
if (node) {
- const struct ctl_table *entry;
-
- list_for_each_table_entry(entry, head) {
+ for (size_t i = 0; i < head->ctl_table_size; i++) {
node->header = head;
node++;
}
base-commit: 893e11787f78e43b534e252249ac3fff4d1333f8
--
2.55.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-09 16:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-09 16:32 [PATCH] fs/proc: avoid unused ctl_table entry in init_header Safety 1
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®