* [PATCH] net: ipconfig: use ifreq field aliases
@ 2026-09-09 14:44 Lalit Shankar Chowdhury
2026-09-10 10:31 ` Ido Schimmel
2026-09-10 18:19 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Lalit Shankar Chowdhury @ 2026-09-09 14:44 UTC (permalink / raw)
To: David Ahern, Ido Schimmel, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman,
open list:NETWORKING [IPv4/IPv6],
open list
Cc: Lalit Shankar Chowdhury
Use the ifr_addr and ifr_name macros instead of the lengthier versions.
Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
---
net/ipv4/ipconfig.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 155db067eaec..475393a86c91 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -367,11 +367,11 @@ set_sockaddr(struct sockaddr_in *sin, __be32 addr, __be16 port)
static int __init ic_setup_if(void)
{
struct ifreq ir;
- struct sockaddr_in *sin = (void *) &ir.ifr_ifru.ifru_addr;
+ struct sockaddr_in *sin = (void *) &ir.ifr_addr;
int err;
memset(&ir, 0, sizeof(ir));
- strcpy(ir.ifr_ifrn.ifrn_name, ic_dev->dev->name);
+ strcpy(ir.ifr_name, ic_dev->dev->name);
set_sockaddr(sin, ic_myaddr, 0);
if ((err = devinet_ioctl(&init_net, SIOCSIFADDR, &ir)) < 0) {
pr_err("IP-Config: Unable to set interface address (%d)\n",
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ipconfig: use ifreq field aliases
2026-09-09 14:44 [PATCH] net: ipconfig: use ifreq field aliases Lalit Shankar Chowdhury
@ 2026-09-10 10:31 ` Ido Schimmel
2026-09-10 18:19 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2026-09-10 10:31 UTC (permalink / raw)
To: Lalit Shankar Chowdhury
Cc: David Ahern, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, open list:NETWORKING [IPv4/IPv6],
open list
On Wed, Sep 09, 2026 at 02:44:16PM +0000, Lalit Shankar Chowdhury wrote:
> Use the ifr_addr and ifr_name macros instead of the lengthier versions.
Please read the following document before submitting more networking
patches:
https://docs.kernel.org/next/process/maintainer-netdev.html
In particular:
https://docs.kernel.org/next/process/maintainer-netdev.html#clean-up-patches
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ipconfig: use ifreq field aliases
2026-09-09 14:44 [PATCH] net: ipconfig: use ifreq field aliases Lalit Shankar Chowdhury
2026-09-10 10:31 ` Ido Schimmel
@ 2026-09-10 18:19 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2026-09-10 18:19 UTC (permalink / raw)
To: Lalit Shankar Chowdhury
Cc: David Ahern, Ido Schimmel, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman,
open list:NETWORKING [IPv4/IPv6],
open list
On Wed, 9 Sep 2026 14:44:16 +0000
Lalit Shankar Chowdhury <lalitshankarch@gmail.com> wrote:
> Use the ifr_addr and ifr_name macros instead of the lengthier versions.
>
> Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
> ---
Why? seems like useless churn. Those header files never change
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-10 18:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-09 14:44 [PATCH] net: ipconfig: use ifreq field aliases Lalit Shankar Chowdhury
2026-09-10 10:31 ` Ido Schimmel
2026-09-10 18:19 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®