* [PATCH] rcu: Drop the private tick-internal.h include from tree.c
@ 2026-09-10 17:25 Bradley Morgan
2026-09-10 23:16 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Bradley Morgan @ 2026-09-10 17:25 UTC (permalink / raw)
To: Paul E. McKenney
Cc: frederic, neeraj.upadhyay, joelagnelf, josh, boqun, urezki,
rostedt, mathieu.desnoyers, jiangshanlai, qiang.zhang, rcu,
linux-kernel, brads
Nothing in the tree.c translation unit uses anything from the
private timekeeping header ../time/tick-internal.h, included
since commit 48d07c04b4cc ("rcu: Enable elimination of
Tree-RCU softirq processing"). The tick symbols RCU uses,
tick_dep_set(), tick_dep_clear(), their _cpu and _task
variants, tick_nohz_full_cpu() and TICK_DEP_BIT_RCU, are all
declared in the public linux/tick.h, which tree.c already
includes.
Drop the include.
Signed-off-by: Bradley Morgan <brads@mainlining.org>
---
kernel/rcu/tree.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 96848fc1f02b..338737b9781c 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -64,7 +64,6 @@
#include <linux/mm.h>
#include <linux/kasan.h>
#include <linux/context_tracking.h>
-#include "../time/tick-internal.h"
#include "tree.h"
#include "rcu.h"
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] rcu: Drop the private tick-internal.h include from tree.c
2026-09-10 17:25 [PATCH] rcu: Drop the private tick-internal.h include from tree.c Bradley Morgan
@ 2026-09-10 23:16 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2026-09-10 23:16 UTC (permalink / raw)
To: Bradley Morgan
Cc: frederic, neeraj.upadhyay, joelagnelf, josh, boqun, urezki,
rostedt, mathieu.desnoyers, jiangshanlai, qiang.zhang, rcu,
linux-kernel
On Thu, Sep 10, 2026 at 05:25:37PM +0000, Bradley Morgan wrote:
> Nothing in the tree.c translation unit uses anything from the
> private timekeeping header ../time/tick-internal.h, included
> since commit 48d07c04b4cc ("rcu: Enable elimination of
> Tree-RCU softirq processing"). The tick symbols RCU uses,
> tick_dep_set(), tick_dep_clear(), their _cpu and _task
> variants, tick_nohz_full_cpu() and TICK_DEP_BIT_RCU, are all
> declared in the public linux/tick.h, which tree.c already
> includes.
>
> Drop the include.
>
> Signed-off-by: Bradley Morgan <brads@mainlining.org>
Applied for testing and additional review, thank you!
Thanx, Paul
> ---
> kernel/rcu/tree.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 96848fc1f02b..338737b9781c 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -64,7 +64,6 @@
> #include <linux/mm.h>
> #include <linux/kasan.h>
> #include <linux/context_tracking.h>
> -#include "../time/tick-internal.h"
>
> #include "tree.h"
> #include "rcu.h"
> --
> 2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-10 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10 17:25 [PATCH] rcu: Drop the private tick-internal.h include from tree.c Bradley Morgan
2026-09-10 23:16 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®