mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCHv2] dmaengine: fsldma: kill tasklet before removing channel
@ 2026-09-10 20:28 Rosen Penev
  2026-09-15 17:36 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-09-10 20:28 UTC (permalink / raw)
  To: dmaengine
  Cc: Zhang Wei, Vinod Koul, Frank Li, open list:FREESCALE DMA DRIVER,
	open list

Add tasklet_kill() in fsl_dma_chan_remove() to prevent a race where the
tasklet is scheduled by the IRQ handler and runs after the channel has been
freed.

Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 v2: split from series and wrap at 75 characters
 drivers/dma/fsldma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 6ce0e5668dc2..5eca8ab23564 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -1207,6 +1207,7 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev,
 
 static void fsl_dma_chan_remove(struct fsldma_chan *chan)
 {
+	tasklet_kill(&chan->tasklet);
 	irq_dispose_mapping(chan->irq);
 	list_del(&chan->common.device_node);
 	iounmap(chan->regs);
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCHv2] dmaengine: fsldma: kill tasklet before removing channel
  2026-09-10 20:28 [PATCHv2] dmaengine: fsldma: kill tasklet before removing channel Rosen Penev
@ 2026-09-15 17:36 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2026-09-15 17:36 UTC (permalink / raw)
  To: dmaengine, Rosen Penev; +Cc: Zhang Wei, Frank Li, linuxppc-dev, linux-kernel


On Thu, 10 Sep 2026 13:28:46 -0700, Rosen Penev wrote:
> Add tasklet_kill() in fsl_dma_chan_remove() to prevent a race where the
> tasklet is scheduled by the IRQ handler and runs after the channel has been
> freed.
> 
> 

Applied, thanks!

[1/1] dmaengine: fsldma: kill tasklet before removing channel
      commit: 32ac4723e5526c44e5a1f3b1586578c17647f2ef

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-15 17:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10 20:28 [PATCHv2] dmaengine: fsldma: kill tasklet before removing channel Rosen Penev
2026-09-15 17:36 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®