* [PATCH 0/3] usb: musb: omap2430: propagate PHY setup errors
@ 2026-09-06 3:41 Pengpeng Hou
2026-09-10 12:22 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-09-06 3:41 UTC (permalink / raw)
To: Bin Liu, Greg Kroah-Hartman
Cc: Pengpeng Hou, Sylwester Nawrocki, Kishon Vijay Abraham I,
Felipe Balbi, linux-usb, linux-omap, linux-kernel, Tony Lindgren
The OMAP2430 glue ignores generic PHY initialization and power-on
failures during initial setup, runtime resume and system resume. The
callers can therefore access glue registers or publish resumed state
without a usable PHY.
Keep the three lifecycle transitions separate so each patch has one
failure state and one introducing commit. Each power-on failure exits a
PHY that was initialized by the same transition.
The issues were found by our static-analysis tool and manually reviewed.
Pengpeng Hou (3):
usb: musb: omap2430: Propagate PHY errors from init
usb: musb: omap2430: Propagate PHY errors from runtime resume
usb: musb: omap2430: Propagate PHY errors from system resume
drivers/usb/musb/omap2430.c | 35 +++++++++++++++++++++++++++++------
1 file changed, 29 insertions(+), 6 deletions(-)
--
2.50.1 (Apple Git-155)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/3] usb: musb: omap2430: propagate PHY setup errors
2026-09-06 3:41 [PATCH 0/3] usb: musb: omap2430: propagate PHY setup errors Pengpeng Hou
@ 2026-09-10 12:22 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-09-10 12:22 UTC (permalink / raw)
To: Pengpeng Hou
Cc: Bin Liu, Sylwester Nawrocki, Kishon Vijay Abraham I,
Felipe Balbi, linux-usb, linux-omap, linux-kernel, Tony Lindgren
On Sun, Sep 06, 2026 at 11:41:46AM +0800, Pengpeng Hou wrote:
> The OMAP2430 glue ignores generic PHY initialization and power-on
> failures during initial setup, runtime resume and system resume. The
> callers can therefore access glue registers or publish resumed state
> without a usable PHY.
>
> Keep the three lifecycle transitions separate so each patch has one
> failure state and one introducing commit. Each power-on failure exits a
> PHY that was initialized by the same transition.
>
> The issues were found by our static-analysis tool and manually reviewed.
None of these were properly "threaded" and can't be picked up by our
tools. Please fix that up and resend the full series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-10 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-06 3:41 [PATCH 0/3] usb: musb: omap2430: propagate PHY setup errors Pengpeng Hou
2026-09-10 12:22 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®