mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Narcisa Vasile <narcisav.kernel@gmail.com>
Cc: netdev@vger.kernel.org, daniel.zahka@gmail.com,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, shuah@kernel.org, horms@kernel.org,
	willemb@google.com, petrm@nvidia.com, anubhavsinggh@google.com,
	richardbgobert@gmail.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: drv-net: add BIG TCP test cases
Date: Fri, 11 Sep 2026 10:01:01 -0700	[thread overview]
Message-ID: <20260911100101.2c34bdc5@kernel.org> (raw)
In-Reply-To: <20260911050659.13367-1-narcisav.kernel@gmail.com>

On Thu, 10 Sep 2026 22:06:59 -0700 Narcisa Vasile wrote:
> Add four new test cases that validate coalescing
> under increased size limits (BIG TCP):
> 
> big_tcp_data_same
>   - validates that equal-sized segments coalesce past
>    the legacy IP_MAXPACKET limit.
> big_tcp_data_lrg_sml
>   - validates that a smaller final segment coalesces into the
>     previous chain of large-sized segments while crossing the
>     IP_MAXPACKET limit.
> big_tcp_tcp_seq
>   - validates that a packet with a wrong sequence number doesn't
>     coalesce. The test uses a sequence number for which the low 16 bits
>     correspond to the correct sequence number to validate against
>     truncation bugs, since total aggregate length crosses over the
>     legacy size limit for BIG TCP.
> big_tcp_large_max
>   - validates that coalescing stops at the configured BIG TCP limit.

Looks like SW is struggling to aggregate enough. Do we need longer
timeouts perhaps? Note that the debug kernel build includes 
kernel/configs/debug.config

AI says:

Thanks for adding the BIG TCP coalescing coverage to gro_sw.py. CI is
flagging the new subtests as failing on our debug-kernel executor
(vmksft-net-drv-dbg, gro-sw-py):

  not ok gro_sw.test.ipv4_big_tcp_data_same
  not ok gro_sw.test.ipv4_big_tcp_data_lrg_sml
  not ok gro_sw.test.ipv4_big_tcp_tcp_seq
  not ok gro_sw.test.ipv4_big_tcp_large_max
  (and the ipv6 equivalents)

The rx side never fully coalesces the injected segments before the
background receiver gives up and the test's retry loop (6 attempts) is
exhausted, e.g.:

  Expected {68952 }, Total 1 packets
  Received {20280 [!=68952]40560 [!=0]8112 [!=0]}, Total 3 packets.


  reply	other threads:[~2026-09-11 17:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11  5:06 Narcisa Vasile
2026-09-11 17:01 ` Jakub Kicinski [this message]
2026-09-12  5:11   ` Narcisa Vasile

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911100101.2c34bdc5@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=anubhavsinggh@google.com \
    --cc=daniel.zahka@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=narcisav.kernel@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=richardbgobert@gmail.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®