mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile
@ 2026-09-10  8:06 Hangbin Liu
  2026-09-11 10:36 ` Simon Horman
  2026-09-12  0:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2026-09-10  8:06 UTC (permalink / raw)
  To: Jakub Kicinski, Andrew Lunn, David S. Miller, Eric Dumazet,
	Paolo Abeni, Shuah Khan
  Cc: Hangbin Liu, netdev, linux-kselftest, linux-kernel, Hangbin Liu

From: Hangbin Liu <liuhangbin@kylinos.cn>

Some netdevsim selftests source forwarding/lib.sh and other files, but
the Makefile doesn't have TEST_INCLUDES targets, which makes

  make INSTALL_PATH=/tmp/kself TARGETS=drivers/net/netdevsim \
     -C tools/testing/selftests install

failed to install related lib files. Add TEST_INCLUDES to the Makefile
to install the dependencies.

Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
---
As there are multi nsim selftests include the lib.sh but no error report
for the installation issue. So I won't bother fixes tags and just post
this patch to net-next.
---
 tools/testing/selftests/drivers/net/netdevsim/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/testing/selftests/drivers/net/netdevsim/Makefile b/tools/testing/selftests/drivers/net/netdevsim/Makefile
index 9808c2fbae9e..bb90fe89d9a1 100644
--- a/tools/testing/selftests/drivers/net/netdevsim/Makefile
+++ b/tools/testing/selftests/drivers/net/netdevsim/Makefile
@@ -22,4 +22,12 @@ TEST_FILES := \
 	ethtool-common.sh
 # end of TEST_FILES
 
+TEST_INCLUDES := \
+	$(wildcard ../../../net/lib/sh/*.sh) \
+	../../../net/forwarding/devlink_lib.sh \
+	../../../net/forwarding/fib_offload_lib.sh \
+	../../../net/forwarding/lib.sh \
+	../../../net/lib.sh \
+# end of TEST_INCLUDES
+
 include ../../../lib.mk

---
base-commit: 63487bb38a97918656751a2a4b74809bbe22eacb
change-id: 20260910-nsim_lib-489cd5abf074

Best regards,
-- 
Hangbin Liu <liuhangbin@kylinos.cn>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile
  2026-09-10  8:06 [PATCH net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile Hangbin Liu
@ 2026-09-11 10:36 ` Simon Horman
  2026-09-12  0:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-09-11 10:36 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: Jakub Kicinski, Andrew Lunn, David S. Miller, Eric Dumazet,
	Paolo Abeni, Shuah Khan, netdev, linux-kselftest, linux-kernel,
	Hangbin Liu

On Thu, Sep 10, 2026 at 04:06:58PM +0800, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
> 
> Some netdevsim selftests source forwarding/lib.sh and other files, but
> the Makefile doesn't have TEST_INCLUDES targets, which makes
> 
>   make INSTALL_PATH=/tmp/kself TARGETS=drivers/net/netdevsim \
>      -C tools/testing/selftests install
> 
> failed to install related lib files. Add TEST_INCLUDES to the Makefile
> to install the dependencies.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
> ---
> As there are multi nsim selftests include the lib.sh but no error report
> for the installation issue. So I won't bother fixes tags and just post
> this patch to net-next.

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile
  2026-09-10  8:06 [PATCH net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile Hangbin Liu
  2026-09-11 10:36 ` Simon Horman
@ 2026-09-12  0:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-12  0:30 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: kuba, andrew+netdev, davem, edumazet, pabeni, shuah, netdev,
	linux-kselftest, linux-kernel, liuhangbin

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 10 Sep 2026 16:06:58 +0800 you wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
> 
> Some netdevsim selftests source forwarding/lib.sh and other files, but
> the Makefile doesn't have TEST_INCLUDES targets, which makes
> 
>   make INSTALL_PATH=/tmp/kself TARGETS=drivers/net/netdevsim \
>      -C tools/testing/selftests install
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile
    https://git.kernel.org/netdev/net-next/c/879e280b8486

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-12  0:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10  8:06 [PATCH net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile Hangbin Liu
2026-09-11 10:36 ` Simon Horman
2026-09-12  0:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®