mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc
@ 2026-09-11 20:42 Karl Mehltretter
  2026-09-14 12:22 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-09-11 20:42 UTC (permalink / raw)
  To: Andrew Lunn, Heiner Kallweit, Russell King, Jakub Kicinski,
	Florian Fainelli, Maxime Chevallier, Russell King (Oracle)
  Cc: Karl Mehltretter, netdev, linux-kernel

The phy_may_wakeup() documentation refers to
device_set_wakeup_enabled(), but the function is named
device_set_wakeup_enable(). Correct the reference.

The typo was introduced by commit b344bfacf1de ("net: phy: add
phy_may_wakeup()").

Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 include/linux/phy.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/phy.h b/include/linux/phy.h
index 5f8d65868e0ff558c163421cfea5a6f3bd73a53e..da2febc6425ed340248d9872dd8f2ef79b665168 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1697,7 +1697,7 @@ static inline bool phy_can_wakeup(struct phy_device *phydev)
  * phy_may_wakeup() - indicate whether PHY has wakeup enabled
  * @phydev: The phy_device struct
  *
- * Returns: true/false depending on the PHY driver's device_set_wakeup_enabled()
+ * Returns: true/false depending on the PHY driver's device_set_wakeup_enable()
  * setting if using the driver model, otherwise the legacy determination.
  */
 bool phy_may_wakeup(struct phy_device *phydev);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc
  2026-09-11 20:42 [PATCH net-next] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc Karl Mehltretter
@ 2026-09-14 12:22 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2026-09-14 12:22 UTC (permalink / raw)
  To: Karl Mehltretter
  Cc: Heiner Kallweit, Russell King, Jakub Kicinski, Florian Fainelli,
	Maxime Chevallier, Russell King (Oracle),
	netdev, linux-kernel

On Fri, Sep 11, 2026 at 10:42:01PM +0200, Karl Mehltretter wrote:
> The phy_may_wakeup() documentation refers to
> device_set_wakeup_enabled(), but the function is named
> device_set_wakeup_enable(). Correct the reference.
> 
> The typo was introduced by commit b344bfacf1de ("net: phy: add
> phy_may_wakeup()").
> 
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Please could you add a Fixes: tag and target net. Developers often
work on dead stable kernels, before rebasing to net-next for merging,
so fixing documentation in stable can be useful.

    Andrew

---
pw-bot: cr

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-14 12:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-11 20:42 [PATCH net-next] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc Karl Mehltretter
2026-09-14 12:22 ` Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®