mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] firewire: cdev: Fix FW_CDEV_IOC_CREATE_ISO_CONTEXT references in kernel-doc
@ 2026-09-11 22:28 Karl Mehltretter
  2026-09-11 23:46 ` Takashi Sakamoto
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-09-11 22:28 UTC (permalink / raw)
  To: Takashi Sakamoto
  Cc: Karl Mehltretter, Paul E. McKenney, David Howells, Dave Jones,
	Arnd Bergmann, Michael Kerrisk, linux1394-devel, linux-kernel

The fw_cdev_event_iso_interrupt and fw_cdev_event_iso_interrupt_mc
comments refer to FW_CDEV_CREATE_ISO_CONTEXT, but the ioctl is named
FW_CDEV_IOC_CREATE_ISO_CONTEXT.

Correct both references. The misspellings were introduced separately
with the userspace interface documentation and multichannel reception
support.

Fixes: 7ada60e36764 ("firewire: Document userspace ioctl interface.")
Fixes: 872e330e3880 ("firewire: add isochronous multichannel reception")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 include/uapi/linux/firewire-cdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/firewire-cdev.h b/include/uapi/linux/firewire-cdev.h
index 05e3aa8fa8bcbcd8e4981ef470d14fb9b941d51b..4f83d6babc92181ee969ef75b0b1b374616a3819 100644
--- a/include/uapi/linux/firewire-cdev.h
+++ b/include/uapi/linux/firewire-cdev.h
@@ -293,7 +293,7 @@ struct fw_cdev_event_request3 {
 /**
  * struct fw_cdev_event_iso_interrupt - Sent when an iso packet was completed
  * @closure:	See &fw_cdev_event_common;
- *		set by %FW_CDEV_CREATE_ISO_CONTEXT ioctl
+ *		set by %FW_CDEV_IOC_CREATE_ISO_CONTEXT ioctl
  * @type:	See &fw_cdev_event_common; always %FW_CDEV_EVENT_ISO_INTERRUPT
  * @cycle:	Cycle counter of the last completed packet
  * @header_length: Total length of following headers, in bytes
@@ -353,7 +353,7 @@ struct fw_cdev_event_iso_interrupt {
 /**
  * struct fw_cdev_event_iso_interrupt_mc - An iso buffer chunk was completed
  * @closure:	See &fw_cdev_event_common;
- *		set by %FW_CDEV_CREATE_ISO_CONTEXT ioctl
+ *		set by %FW_CDEV_IOC_CREATE_ISO_CONTEXT ioctl
  * @type:	%FW_CDEV_EVENT_ISO_INTERRUPT_MULTICHANNEL
  * @completed:	Offset into the receive buffer; data before this offset is valid
  *

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] firewire: cdev: Fix FW_CDEV_IOC_CREATE_ISO_CONTEXT references in kernel-doc
  2026-09-11 22:28 [PATCH] firewire: cdev: Fix FW_CDEV_IOC_CREATE_ISO_CONTEXT references in kernel-doc Karl Mehltretter
@ 2026-09-11 23:46 ` Takashi Sakamoto
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Sakamoto @ 2026-09-11 23:46 UTC (permalink / raw)
  To: Karl Mehltretter
  Cc: Paul E. McKenney, David Howells, Dave Jones, Arnd Bergmann,
	Michael Kerrisk, linux1394-devel, linux-kernel

Hi,

On Sat, Sep 12, 2026 at 12:28:07AM +0200, Karl Mehltretter wrote:
> The fw_cdev_event_iso_interrupt and fw_cdev_event_iso_interrupt_mc
> comments refer to FW_CDEV_CREATE_ISO_CONTEXT, but the ioctl is named
> FW_CDEV_IOC_CREATE_ISO_CONTEXT.
> 
> Correct both references. The misspellings were introduced separately
> with the userspace interface documentation and multichannel reception
> support.
> 
> Fixes: 7ada60e36764 ("firewire: Document userspace ioctl interface.")
> Fixes: 872e330e3880 ("firewire: add isochronous multichannel reception")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>  include/uapi/linux/firewire-cdev.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-next branch.


Thanks

Takashi Sakamoto

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-11 23:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-11 22:28 [PATCH] firewire: cdev: Fix FW_CDEV_IOC_CREATE_ISO_CONTEXT references in kernel-doc Karl Mehltretter
2026-09-11 23:46 ` Takashi Sakamoto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®