* [PATCH] staging: media: atomisp: remove duplicate blank line
@ 2026-09-12 1:09 Ricardo Barbosa Dias
2026-09-12 12:35 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Barbosa Dias @ 2026-09-12 1:09 UTC (permalink / raw)
To: hansg, mchehab, gregkh
Cc: andy, sakari.ailus, linux-staging, linux-media, linux-kernel,
Ricardo Barbosa Dias
Remove an unnecessary extra blank line to clean up code style
and fix checkpatch CHECK warning.
Signed-off-by: Ricardo Barbosa Dias <ricardobarbosamscg@gmail.com>
---
.../staging/media/atomisp/pci/runtime/isys/src/virtual_isys.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/virtual_isys.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/virtual_isys.c
index 8e8433f5b07a..370cd8cac43b 100644
--- a/drivers/staging/media/atomisp/pci/runtime/isys/src/virtual_isys.c
+++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/virtual_isys.c
@@ -10,7 +10,6 @@
#include "system_global.h"
-
#include "ia_css_isys.h"
#include "ia_css_debug.h"
#include "virtual_isys.h"
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: media: atomisp: remove duplicate blank line
2026-09-12 1:09 [PATCH] staging: media: atomisp: remove duplicate blank line Ricardo Barbosa Dias
@ 2026-09-12 12:35 ` Andy Shevchenko
2026-09-12 15:44 ` ricardo barbosa
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2026-09-12 12:35 UTC (permalink / raw)
To: Ricardo Barbosa Dias
Cc: hansg, mchehab, gregkh, andy, sakari.ailus, linux-staging,
linux-media, linux-kernel
On Sat, Sep 12, 2026 at 4:11 AM Ricardo Barbosa Dias
<ricardobarbosamscg@gmail.com> wrote:
>
> Remove an unnecessary extra blank line to clean up code style
> and fix checkpatch CHECK warning.
This is the lowest possible priority patch, if even considered. If you
want to clean up this driver, there are more interesting tasks.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: media: atomisp: remove duplicate blank line
2026-09-12 12:35 ` Andy Shevchenko
@ 2026-09-12 15:44 ` ricardo barbosa
2026-09-12 15:50 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: ricardo barbosa @ 2026-09-12 15:44 UTC (permalink / raw)
To: Andy Shevchenko
Cc: hansg, mchehab, gregkh, andy, sakari.ailus, linux-staging,
linux-media, linux-kernel
Thanks for the feedback, Andy.
As a beginner taking the LFD103 course, my main goal with this
submission was simply to validate the workflow and git send-email
toolchain with a zero-risk change.
I'll look into more meaningful tasks for my next patch.
On Sat, Sep 12, 2026 at 8:36 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sat, Sep 12, 2026 at 4:11 AM Ricardo Barbosa Dias
> <ricardobarbosamscg@gmail.com> wrote:
> >
> > Remove an unnecessary extra blank line to clean up code style
> > and fix checkpatch CHECK warning.
>
> This is the lowest possible priority patch, if even considered. If you
> want to clean up this driver, there are more interesting tasks.
>
> --
> With Best Regards,
> Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: media: atomisp: remove duplicate blank line
2026-09-12 15:44 ` ricardo barbosa
@ 2026-09-12 15:50 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2026-09-12 15:50 UTC (permalink / raw)
To: ricardo barbosa
Cc: hansg, mchehab, gregkh, andy, sakari.ailus, linux-staging,
linux-media, linux-kernel
On Sat, Sep 12, 2026 at 6:44 PM ricardo barbosa
<ricardobarbosamscg@gmail.com> wrote:
Please, do not top-post!
> Thanks for the feedback, Andy.
>
> As a beginner taking the LFD103 course, my main goal with this
> submission was simply to validate the workflow and git send-email
> toolchain with a zero-risk change.
Unfortunately this driver is not the best choice for a newbie. We
prefer to see real work (likely by a contributor who has a hardware to
test) on it first.
> I'll look into more meaningful tasks for my next patch.
Yes, it's still possible to submit some cleaning stuff, but do not
expect it will be accepted or even reviewed, we lack the resources to
handle that driver ourselves with all contributions it gets lately.
Thanks for understanding.
> On Sat, Sep 12, 2026 at 8:36 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Sat, Sep 12, 2026 at 4:11 AM Ricardo Barbosa Dias
> > <ricardobarbosamscg@gmail.com> wrote:
> > >
> > > Remove an unnecessary extra blank line to clean up code style
> > > and fix checkpatch CHECK warning.
> >
> > This is the lowest possible priority patch, if even considered. If you
> > want to clean up this driver, there are more interesting tasks.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-12 15:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-12 1:09 [PATCH] staging: media: atomisp: remove duplicate blank line Ricardo Barbosa Dias
2026-09-12 12:35 ` Andy Shevchenko
2026-09-12 15:44 ` ricardo barbosa
2026-09-12 15:50 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®