From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: v4l2-subdev: Fix media_entity_operations references in kernel-doc
Date: Sat, 12 Sep 2026 19:25:00 +0300 [thread overview]
Message-ID: <20260912162500.GZ1892234@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20260912055850.39828-1-kmehltretter@gmail.com>
On Sat, Sep 12, 2026 at 07:58:50AM +0200, Karl Mehltretter wrote:
> The kernel-doc comment of v4l2_subdev_link_validate() refers to
> media_entity_ops, which does not exist. The name is
> media_entity_operations. Say media_entity_operations.
>
> Fixes: 5fd3e2412ade ("media: v4l2-subdev: Support hybrid links in v4l2_subdev_link_validate()")
> Assisted-by: LLM
Throwing LLMs at this kind of things is neither a good use of computing
resources nor a good use of maintainer time. Please refrain from doing
so in the future.
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> include/media/v4l2-subdev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index d256b7ec8f848c51416cd1b62ff931ddc4feb4fd..6c4a0a6334e8e210c5da48527c1ad514568bd633 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -1236,10 +1236,10 @@ int v4l2_subdev_link_validate_default(struct v4l2_subdev *sd,
> * width, height and the media bus pixel code are equal on both
> * source and sink of the link.
> *
> - * The function can be used as a drop-in &media_entity_ops.link_validate
> + * The function can be used as a drop-in &media_entity_operations.link_validate
> * implementation for v4l2_subdev instances. It supports all links between
> * subdevs, as well as links between subdevs and video devices, provided that
> - * the video devices also implement their &media_entity_ops.link_validate
> + * the video devices also implement their &media_entity_operations.link_validate
> * operation.
> */
> int v4l2_subdev_link_validate(struct media_link *link);
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2026-09-12 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 5:58 Karl Mehltretter
2026-09-12 16:25 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912162500.GZ1892234@killaraus.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®