mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] media: v4l2-subdev: Fix media_entity_operations references in kernel-doc
@ 2026-09-12  5:58 Karl Mehltretter
  2026-09-12 16:25 ` Laurent Pinchart
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-09-12  5:58 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Karl Mehltretter, Sakari Ailus, Tomi Valkeinen, Laurent Pinchart,
	linux-media, linux-kernel

The kernel-doc comment of v4l2_subdev_link_validate() refers to
media_entity_ops, which does not exist. The name is
media_entity_operations. Say media_entity_operations.

Fixes: 5fd3e2412ade ("media: v4l2-subdev: Support hybrid links in v4l2_subdev_link_validate()")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 include/media/v4l2-subdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index d256b7ec8f848c51416cd1b62ff931ddc4feb4fd..6c4a0a6334e8e210c5da48527c1ad514568bd633 100644
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -1236,10 +1236,10 @@ int v4l2_subdev_link_validate_default(struct v4l2_subdev *sd,
  * width, height and the media bus pixel code are equal on both
  * source and sink of the link.
  *
- * The function can be used as a drop-in &media_entity_ops.link_validate
+ * The function can be used as a drop-in &media_entity_operations.link_validate
  * implementation for v4l2_subdev instances. It supports all links between
  * subdevs, as well as links between subdevs and video devices, provided that
- * the video devices also implement their &media_entity_ops.link_validate
+ * the video devices also implement their &media_entity_operations.link_validate
  * operation.
  */
 int v4l2_subdev_link_validate(struct media_link *link);
-- 
2.39.5 (Apple Git-154)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] media: v4l2-subdev: Fix media_entity_operations references in kernel-doc
  2026-09-12  5:58 [PATCH] media: v4l2-subdev: Fix media_entity_operations references in kernel-doc Karl Mehltretter
@ 2026-09-12 16:25 ` Laurent Pinchart
  0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2026-09-12 16:25 UTC (permalink / raw)
  To: Karl Mehltretter
  Cc: Mauro Carvalho Chehab, Sakari Ailus, Tomi Valkeinen, linux-media,
	linux-kernel

On Sat, Sep 12, 2026 at 07:58:50AM +0200, Karl Mehltretter wrote:
> The kernel-doc comment of v4l2_subdev_link_validate() refers to
> media_entity_ops, which does not exist. The name is
> media_entity_operations. Say media_entity_operations.
> 
> Fixes: 5fd3e2412ade ("media: v4l2-subdev: Support hybrid links in v4l2_subdev_link_validate()")
> Assisted-by: LLM

Throwing LLMs at this kind of things is neither a good use of computing
resources nor a good use of maintainer time. Please refrain from doing
so in the future.

> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>  include/media/v4l2-subdev.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index d256b7ec8f848c51416cd1b62ff931ddc4feb4fd..6c4a0a6334e8e210c5da48527c1ad514568bd633 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -1236,10 +1236,10 @@ int v4l2_subdev_link_validate_default(struct v4l2_subdev *sd,
>   * width, height and the media bus pixel code are equal on both
>   * source and sink of the link.
>   *
> - * The function can be used as a drop-in &media_entity_ops.link_validate
> + * The function can be used as a drop-in &media_entity_operations.link_validate
>   * implementation for v4l2_subdev instances. It supports all links between
>   * subdevs, as well as links between subdevs and video devices, provided that
> - * the video devices also implement their &media_entity_ops.link_validate
> + * the video devices also implement their &media_entity_operations.link_validate
>   * operation.
>   */
>  int v4l2_subdev_link_validate(struct media_link *link);

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-12 16:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-12  5:58 [PATCH] media: v4l2-subdev: Fix media_entity_operations references in kernel-doc Karl Mehltretter
2026-09-12 16:25 ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®