* [PATCHv2] dmaengine: bestcomm: make gen_bd init helpers static
@ 2026-09-13 19:48 Rosen Penev
2026-09-14 5:51 ` Christophe Leroy (CS GROUP)
2026-09-14 14:23 ` Frank Li
0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2026-09-13 19:48 UTC (permalink / raw)
To: dmaengine
Cc: Vinod Koul, Frank Li, Christophe Leroy (CS GROUP),
open list, open list:FREESCALE SOC DRIVERS,
moderated list:FREESCALE SOC DRIVERS
bcom_gen_bd_rx_init() and bcom_gen_bd_tx_init() are only called from
the PSC wrapper functions in gen_bd.c, so make them static, drop
their now-unneeded exports, and remove the corresponding header
declarations.
These had use before commit 7d3ee229ea51
("powerpc: Drop MPC5200 LocalPlus bus FIFO driver")
Assisted-by: LLM
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: mention driver removal that made them unused.
drivers/dma/bestcomm/gen_bd.c | 6 ++----
include/linux/fsl/bestcomm/gen_bd.h | 8 --------
2 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/dma/bestcomm/gen_bd.c b/drivers/dma/bestcomm/gen_bd.c
index 61b5746e1a97..b5093f7445cb 100644
--- a/drivers/dma/bestcomm/gen_bd.c
+++ b/drivers/dma/bestcomm/gen_bd.c
@@ -81,7 +81,7 @@ struct bcom_gen_bd_priv {
/* Task support code */
/* ======================================================================== */
-struct bcom_task *
+static struct bcom_task *
bcom_gen_bd_rx_init(int queue_len, phys_addr_t fifo,
int initiator, int ipr, int maxbufsize)
{
@@ -108,7 +108,6 @@ bcom_gen_bd_rx_init(int queue_len, phys_addr_t fifo,
return tsk;
}
-EXPORT_SYMBOL_GPL(bcom_gen_bd_rx_init);
int
bcom_gen_bd_rx_reset(struct bcom_task *tsk)
@@ -166,7 +165,7 @@ bcom_gen_bd_rx_release(struct bcom_task *tsk)
EXPORT_SYMBOL_GPL(bcom_gen_bd_rx_release);
-extern struct bcom_task *
+static struct bcom_task *
bcom_gen_bd_tx_init(int queue_len, phys_addr_t fifo,
int initiator, int ipr)
{
@@ -192,7 +191,6 @@ bcom_gen_bd_tx_init(int queue_len, phys_addr_t fifo,
return tsk;
}
-EXPORT_SYMBOL_GPL(bcom_gen_bd_tx_init);
int
bcom_gen_bd_tx_reset(struct bcom_task *tsk)
diff --git a/include/linux/fsl/bestcomm/gen_bd.h b/include/linux/fsl/bestcomm/gen_bd.h
index aeb312a1cd00..7253d308d77a 100644
--- a/include/linux/fsl/bestcomm/gen_bd.h
+++ b/include/linux/fsl/bestcomm/gen_bd.h
@@ -16,10 +16,6 @@ struct bcom_gen_bd {
};
-extern struct bcom_task *
-bcom_gen_bd_rx_init(int queue_len, phys_addr_t fifo,
- int initiator, int ipr, int maxbufsize);
-
extern int
bcom_gen_bd_rx_reset(struct bcom_task *tsk);
@@ -27,10 +23,6 @@ extern void
bcom_gen_bd_rx_release(struct bcom_task *tsk);
-extern struct bcom_task *
-bcom_gen_bd_tx_init(int queue_len, phys_addr_t fifo,
- int initiator, int ipr);
-
extern int
bcom_gen_bd_tx_reset(struct bcom_task *tsk);
--
2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2] dmaengine: bestcomm: make gen_bd init helpers static
2026-09-13 19:48 [PATCHv2] dmaengine: bestcomm: make gen_bd init helpers static Rosen Penev
@ 2026-09-14 5:51 ` Christophe Leroy (CS GROUP)
2026-09-14 14:23 ` Frank Li
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-09-14 5:51 UTC (permalink / raw)
To: Rosen Penev, dmaengine
Cc: Vinod Koul, Frank Li, open list, open list:FREESCALE SOC DRIVERS,
moderated list:FREESCALE SOC DRIVERS
Le 13/09/2026 à 21:48, Rosen Penev a écrit :
> bcom_gen_bd_rx_init() and bcom_gen_bd_tx_init() are only called from
> the PSC wrapper functions in gen_bd.c, so make them static, drop
> their now-unneeded exports, and remove the corresponding header
> declarations.
>
> These had use before commit 7d3ee229ea51
> ("powerpc: Drop MPC5200 LocalPlus bus FIFO driver")
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> ---
> v2: mention driver removal that made them unused.
> drivers/dma/bestcomm/gen_bd.c | 6 ++----
> include/linux/fsl/bestcomm/gen_bd.h | 8 --------
> 2 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/dma/bestcomm/gen_bd.c b/drivers/dma/bestcomm/gen_bd.c
> index 61b5746e1a97..b5093f7445cb 100644
> --- a/drivers/dma/bestcomm/gen_bd.c
> +++ b/drivers/dma/bestcomm/gen_bd.c
> @@ -81,7 +81,7 @@ struct bcom_gen_bd_priv {
> /* Task support code */
> /* ======================================================================== */
>
> -struct bcom_task *
> +static struct bcom_task *
> bcom_gen_bd_rx_init(int queue_len, phys_addr_t fifo,
> int initiator, int ipr, int maxbufsize)
> {
> @@ -108,7 +108,6 @@ bcom_gen_bd_rx_init(int queue_len, phys_addr_t fifo,
>
> return tsk;
> }
> -EXPORT_SYMBOL_GPL(bcom_gen_bd_rx_init);
>
> int
> bcom_gen_bd_rx_reset(struct bcom_task *tsk)
> @@ -166,7 +165,7 @@ bcom_gen_bd_rx_release(struct bcom_task *tsk)
> EXPORT_SYMBOL_GPL(bcom_gen_bd_rx_release);
>
>
> -extern struct bcom_task *
> +static struct bcom_task *
> bcom_gen_bd_tx_init(int queue_len, phys_addr_t fifo,
> int initiator, int ipr)
> {
> @@ -192,7 +191,6 @@ bcom_gen_bd_tx_init(int queue_len, phys_addr_t fifo,
>
> return tsk;
> }
> -EXPORT_SYMBOL_GPL(bcom_gen_bd_tx_init);
>
> int
> bcom_gen_bd_tx_reset(struct bcom_task *tsk)
> diff --git a/include/linux/fsl/bestcomm/gen_bd.h b/include/linux/fsl/bestcomm/gen_bd.h
> index aeb312a1cd00..7253d308d77a 100644
> --- a/include/linux/fsl/bestcomm/gen_bd.h
> +++ b/include/linux/fsl/bestcomm/gen_bd.h
> @@ -16,10 +16,6 @@ struct bcom_gen_bd {
> };
>
>
> -extern struct bcom_task *
> -bcom_gen_bd_rx_init(int queue_len, phys_addr_t fifo,
> - int initiator, int ipr, int maxbufsize);
> -
> extern int
> bcom_gen_bd_rx_reset(struct bcom_task *tsk);
>
> @@ -27,10 +23,6 @@ extern void
> bcom_gen_bd_rx_release(struct bcom_task *tsk);
>
>
> -extern struct bcom_task *
> -bcom_gen_bd_tx_init(int queue_len, phys_addr_t fifo,
> - int initiator, int ipr);
> -
> extern int
> bcom_gen_bd_tx_reset(struct bcom_task *tsk);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2] dmaengine: bestcomm: make gen_bd init helpers static
2026-09-13 19:48 [PATCHv2] dmaengine: bestcomm: make gen_bd init helpers static Rosen Penev
2026-09-14 5:51 ` Christophe Leroy (CS GROUP)
@ 2026-09-14 14:23 ` Frank Li
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2026-09-14 14:23 UTC (permalink / raw)
To: Rosen Penev
Cc: dmaengine, Vinod Koul, Frank Li, Christophe Leroy (CS GROUP),
open list, open list:FREESCALE SOC DRIVERS,
moderated list:FREESCALE SOC DRIVERS
On Sun, Sep 13, 2026 at 12:48:04PM -0700, Rosen Penev wrote:
> bcom_gen_bd_rx_init() and bcom_gen_bd_tx_init() are only called from
> the PSC wrapper functions in gen_bd.c, so make them static, drop
> their now-unneeded exports, and remove the corresponding header
> declarations.
>
> These had use before commit 7d3ee229ea51
> ("powerpc: Drop MPC5200 LocalPlus bus FIFO driver")
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> v2: mention driver removal that made them unused.
> drivers/dma/bestcomm/gen_bd.c | 6 ++----
> include/linux/fsl/bestcomm/gen_bd.h | 8 --------
> 2 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/dma/bestcomm/gen_bd.c b/drivers/dma/bestcomm/gen_bd.c
> index 61b5746e1a97..b5093f7445cb 100644
> --- a/drivers/dma/bestcomm/gen_bd.c
> +++ b/drivers/dma/bestcomm/gen_bd.c
> @@ -81,7 +81,7 @@ struct bcom_gen_bd_priv {
> /* Task support code */
> /* ======================================================================== */
>
> -struct bcom_task *
> +static struct bcom_task *
> bcom_gen_bd_rx_init(int queue_len, phys_addr_t fifo,
> int initiator, int ipr, int maxbufsize)
> {
> @@ -108,7 +108,6 @@ bcom_gen_bd_rx_init(int queue_len, phys_addr_t fifo,
>
> return tsk;
> }
> -EXPORT_SYMBOL_GPL(bcom_gen_bd_rx_init);
>
> int
> bcom_gen_bd_rx_reset(struct bcom_task *tsk)
> @@ -166,7 +165,7 @@ bcom_gen_bd_rx_release(struct bcom_task *tsk)
> EXPORT_SYMBOL_GPL(bcom_gen_bd_rx_release);
>
>
> -extern struct bcom_task *
> +static struct bcom_task *
> bcom_gen_bd_tx_init(int queue_len, phys_addr_t fifo,
> int initiator, int ipr)
> {
> @@ -192,7 +191,6 @@ bcom_gen_bd_tx_init(int queue_len, phys_addr_t fifo,
>
> return tsk;
> }
> -EXPORT_SYMBOL_GPL(bcom_gen_bd_tx_init);
>
> int
> bcom_gen_bd_tx_reset(struct bcom_task *tsk)
> diff --git a/include/linux/fsl/bestcomm/gen_bd.h b/include/linux/fsl/bestcomm/gen_bd.h
> index aeb312a1cd00..7253d308d77a 100644
> --- a/include/linux/fsl/bestcomm/gen_bd.h
> +++ b/include/linux/fsl/bestcomm/gen_bd.h
> @@ -16,10 +16,6 @@ struct bcom_gen_bd {
> };
>
>
> -extern struct bcom_task *
> -bcom_gen_bd_rx_init(int queue_len, phys_addr_t fifo,
> - int initiator, int ipr, int maxbufsize);
> -
> extern int
> bcom_gen_bd_rx_reset(struct bcom_task *tsk);
>
> @@ -27,10 +23,6 @@ extern void
> bcom_gen_bd_rx_release(struct bcom_task *tsk);
>
>
> -extern struct bcom_task *
> -bcom_gen_bd_tx_init(int queue_len, phys_addr_t fifo,
> - int initiator, int ipr);
> -
> extern int
> bcom_gen_bd_tx_reset(struct bcom_task *tsk);
>
> --
> 2.55.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-14 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-13 19:48 [PATCHv2] dmaengine: bestcomm: make gen_bd init helpers static Rosen Penev
2026-09-14 5:51 ` Christophe Leroy (CS GROUP)
2026-09-14 14:23 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®