From: Maria Lisina via B4 Relay <devnull+sekoohaka.sarisan.gmail.com@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lee Jones <lee@kernel.org>
Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
Maria Lisina <sekoohaka.sarisan@gmail.com>
Subject: [PATCH v4] mfd: intel-lpss: Prevent DebugFS messages if it is not initialized
Date: Mon, 14 Sep 2026 16:21:31 +0500 [thread overview]
Message-ID: <20260914-intel-lpss-debugfs-v4-1-0eb82ea7c1e3@gmail.com> (raw)
From: Maria Lisina <sekoohaka.sarisan@gmail.com>
The original code expects DebugFS to be always initialized which
causes unwanted warnings when DebugFS is simply disabled.
Therefore it spams dmesg with these messages:
intel-lpss 0000:00:15.0: Failed to create debugfs entries
intel-lpss 0000:00:15.3: Failed to create debugfs entries
intel-lpss 0000:00:1e.0: Failed to create debugfs entries
intel-lpss 0000:00:1e.2: Failed to create debugfs entries
This patch adds proper check to intel_lpss_init() and
intel_lpss_debugfs_add() functions to prevent writing to
uninitialized DebugFS.
Signed-off-by: Maria Lisina <sekoohaka.sarisan@gmail.com>
---
Changes in v4:
- Keep the dmesg messages, instead check whether DebugFS is initialized
- Link to v3: https://lore.kernel.org/r/20260913-intel-lpss-debugfs-v3-1-1b8e2b1f0992@gmail.com
Changes in v3:
- Fixed commit name and description.
- Link to v2: https://lore.kernel.org/r/20260913-intel-lpss-debugfs-v2-1-a1a4faf5cc63@gmail.com
Changes in v2:
- Fixed function name in comment section.
- Link to v1: https://lore.kernel.org/r/20260913-intel-lpss-debugfs-v1-1-833cbb6fffc9@gmail.com
---
drivers/mfd/intel-lpss.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 63d6694f71457b2e09d238af0a9bfb897a169a64..d45728f46c499b3f0c3713d30a17b0ae12106095 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -146,6 +146,12 @@ static int intel_lpss_debugfs_add(struct intel_lpss *lpss)
{
struct dentry *dir;
+ /* Exit if DebugFS is not initialized */
+ if (!intel_lpss_debugfs) {
+ lpss->debugfs = NULL;
+ return 0;
+ }
+
dir = debugfs_create_dir(dev_name(lpss->dev), intel_lpss_debugfs);
if (IS_ERR(dir))
return PTR_ERR(dir);
@@ -538,7 +544,15 @@ EXPORT_NS_GPL_DEV_PM_OPS(intel_lpss_pm_ops, INTEL_LPSS) = {
static int __init intel_lpss_init(void)
{
- intel_lpss_debugfs = debugfs_create_dir("intel_lpss", NULL);
+ /*
+ * Check whether DebugFS is initialized to
+ * prevent unwanted dmesg messages.
+ */
+ if (debugfs_initialized())
+ intel_lpss_debugfs = debugfs_create_dir("intel_lpss", NULL);
+ else
+ intel_lpss_debugfs = NULL;
+
return 0;
}
module_init(intel_lpss_init);
---
base-commit: 2f0c1cf72f4682178506f513bbf015e591b1aa4a
change-id: 20260913-intel-lpss-debugfs-eff3580d1295
Best regards,
--
Maria Lisina <sekoohaka.sarisan@gmail.com>
next reply other threads:[~2026-09-14 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 11:21 Maria Lisina via B4 Relay [this message]
2026-09-14 12:49 ` Andy Shevchenko
2026-09-14 14:27 ` Maria Lisina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914-intel-lpss-debugfs-v4-1-0eb82ea7c1e3@gmail.com \
--to=devnull+sekoohaka.sarisan.gmail.com@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=sekoohaka.sarisan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®