Re: [PATCH v4] mfd: intel-lpss: Prevent DebugFS messages if it is not initialized

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, Sep 14, 2026 at 04:21:31PM +0500, Maria Lisina via B4 Relay wrote:

> The original code expects DebugFS to be always initialized which
> causes unwanted warnings when DebugFS is simply disabled.
> 
> Therefore it spams dmesg with these messages:
> 
>   intel-lpss 0000:00:15.0: Failed to create debugfs entries
>   intel-lpss 0000:00:15.3: Failed to create debugfs entries
>   intel-lpss 0000:00:1e.0: Failed to create debugfs entries
>   intel-lpss 0000:00:1e.2: Failed to create debugfs entries

In previous review I pointed out that one of such a message is enough,
no need to repeat it for each LPSS device in the system.

> This patch adds proper check to intel_lpss_init() and
> intel_lpss_debugfs_add() functions to prevent writing to
> uninitialized DebugFS.

...

> Changes in v4:
> - Keep the dmesg messages, instead check whether DebugFS is initialized
> - Link to v3: https://lore.kernel.org/r/20260913-intel-lpss-debugfs-v3-1-1b8e2b1f0992@gmail.com

I mentioned that switching to the debug (or info) level is fine,
I'm a bit puzzled what this version is trying to achieve. Strictly
speaking the debugfs is designed in the way that no checks are
required at all. In this case we want the user be informed about
this as debugfs carries the LTR values.

So, I expect to see dev_warn() --> dev_dbg() or dev_info() in one-liner.

-- 
With Best Regards,
Andy Shevchenko