From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, stable@vger.kernel.org
Subject: [PATCH 5/6] usb: mtu3: add missing pm_runtime_dont_use_autosuspend() calls
Date: Tue, 15 Sep 2026 09:02:22 +0000 [thread overview]
Message-ID: <20260915090223.1346-6-joshua.crofts1@gmail.com> (raw)
In-Reply-To: <20260915090223.1346-1-joshua.crofts1@gmail.com>
The comm_init_err label in mtu3_probe() and mtu3_remove() both call
pm_runtime_disable() on error or device teardown, but don't call
pm_runtime_dont_use_autosuspend(), causing resource leaks.
Add the missing pm_runtime_dont_use_autosuspend().
Found using Coccinelle.
Fixes: df2069acb005 ("usb: Add MediaTek USB3 DRD driver")
Fixes: fa6f59e28c61 ("usb: mtu3: support runtime PM for host mode")
Cc: <stable@vger.kernel.org>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
drivers/usb/mtu3/mtu3_plat.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c
index b4f4c776adb9..ce64c36a98f7 100644
--- a/drivers/usb/mtu3/mtu3_plat.c
+++ b/drivers/usb/mtu3/mtu3_plat.c
@@ -445,6 +445,7 @@ static int mtu3_probe(struct platform_device *pdev)
comm_init_err:
pm_runtime_put_noidle(dev);
pm_runtime_disable(dev);
+ pm_runtime_dont_use_autosuspend(dev);
ssusb_debugfs_remove_root(ssusb);
return ret;
@@ -483,6 +484,7 @@ static void mtu3_remove(struct platform_device *pdev)
ssusb_rscs_exit(ssusb);
ssusb_debugfs_remove_root(ssusb);
pm_runtime_disable(&pdev->dev);
+ pm_runtime_dont_use_autosuspend(&pdev->dev);
pm_runtime_put_noidle(&pdev->dev);
pm_runtime_set_suspended(&pdev->dev);
}
--
2.47.3
next prev parent reply other threads:[~2026-09-15 9:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 9:02 [PATCH 0/6] usb: " Joshua Crofts
2026-09-15 9:02 ` [PATCH 1/6] usb: core: add missing pm_runtime_dont_use_autosuspend() call Joshua Crofts
2026-09-15 15:02 ` Alan Stern
2026-09-16 8:08 ` Johan Hovold
2026-09-16 8:21 ` Joshua Crofts
2026-09-16 9:14 ` Johan Hovold
2026-09-15 9:02 ` [PATCH 2/6] usb: xhci-mtk: " Joshua Crofts
2026-09-15 9:10 ` AngeloGioacchino Del Regno
2026-09-16 8:16 ` Johan Hovold
2026-09-15 9:02 ` [PATCH 3/6] usb: xhci: add missing pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-09-15 9:02 ` [PATCH 4/6] usb: typec: ucsi: ccg: add missing pm_runtime_dont_use_autosuspend() call Joshua Crofts
2026-09-18 10:03 ` Heikki Krogerus
2026-09-15 9:02 ` Joshua Crofts [this message]
2026-09-15 9:10 ` [PATCH 5/6] usb: mtu3: add missing pm_runtime_dont_use_autosuspend() calls AngeloGioacchino Del Regno
2026-09-15 9:02 ` [PATCH 6/6] usb: cdns3: add missing pm_runtime_dont_use_autosuspend() call Joshua Crofts
2026-09-17 2:59 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915090223.1346-6-joshua.crofts1@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=rogerq@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®