From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>,
Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/6] usb: xhci-mtk: add missing pm_runtime_dont_use_autosuspend() call
Date: Tue, 15 Sep 2026 11:10:20 +0200 [thread overview]
Message-ID: <409f6896-8d69-48dc-b784-a38f50cfb07b@collabora.com> (raw)
In-Reply-To: <20260915090223.1346-3-joshua.crofts1@gmail.com>
On 9/15/26 11:02, Joshua Crofts wrote:
> The disable_pm label in xhci_mtk_probe() and xhci_mtk_remove() both call
> pm_runtime_disable() on error or device teardown, but don't call
> pm_runtime_dont_use_autosuspend(), causing resource leaks.
>
> Add the missing pm_runtime_dont_use_autosuspend().
>
> Found using Coccinelle.
>
> Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller")
> Fixes: 04284eb74e0c ("usb: xhci-mtk: add support runtime PM")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2026-09-15 9:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 9:02 [PATCH 0/6] usb: add missing pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-09-15 9:02 ` [PATCH 1/6] usb: core: add missing pm_runtime_dont_use_autosuspend() call Joshua Crofts
2026-09-15 15:02 ` Alan Stern
2026-09-16 8:08 ` Johan Hovold
2026-09-16 8:21 ` Joshua Crofts
2026-09-16 9:14 ` Johan Hovold
2026-09-15 9:02 ` [PATCH 2/6] usb: xhci-mtk: " Joshua Crofts
2026-09-15 9:10 ` AngeloGioacchino Del Regno [this message]
2026-09-16 8:16 ` Johan Hovold
2026-09-15 9:02 ` [PATCH 3/6] usb: xhci: add missing pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-09-15 9:02 ` [PATCH 4/6] usb: typec: ucsi: ccg: add missing pm_runtime_dont_use_autosuspend() call Joshua Crofts
2026-09-15 9:02 ` [PATCH 5/6] usb: mtu3: add missing pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-09-15 9:10 ` AngeloGioacchino Del Regno
2026-09-15 9:02 ` [PATCH 6/6] usb: cdns3: add missing pm_runtime_dont_use_autosuspend() call Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=409f6896-8d69-48dc-b784-a38f50cfb07b@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=rogerq@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®