From: Tariq Toukan <tariqt@nvidia.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Akiva Goldberger <agoldberger@nvidia.com>,
Gal Pressman <gal@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, Mark Bloch <mbloch@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>, Shay Drory <shayd@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: [PATCH net V3 0/3] net/mlx5: SD LAG and devcom stability fixes
Date: Tue, 15 Sep 2026 14:34:56 +0300 [thread overview]
Message-ID: <20260915113459.3934760-1-tariqt@nvidia.com> (raw)
Hi,
This series by Shay fixes four bugs in the Socket Direct LAG and devcom
subsystems, all related to initialization/teardown ordering and
concurrent access to the LAG device.
Regards,
Tariq
Internal sashiko comment:
> @@ -342,7 +342,14 @@ static void sd_lag_init(struct mlx5_core_dev *dev)
> return;
> }
>
> +recheck:
> mutex_lock(&ldev->lock);
> + if (ldev->mode_changes_in_progress) {
> + mutex_unlock(&ldev->lock);
> + msleep(100);
> + goto recheck;
> +
}
> +
Does this open-coded retry loop reimplement a wait mechanism without
immediate
wakeups or fairness?
It looks like we are polling the mode_changes_in_progress flag using a
hard
coded msleep(100). Could this unnecessarily delay the initialization
path if
the condition clears much sooner than 100ms? Would it be better to use a
proper
synchronization primitive like a waitqueue here instead of an ad-hoc
flag loop?
[SD] This is the same check as in mlx5_lag_remove_mdev().
I agree we need to change it, but this is net-next material
V3:
- Drop the "SD, serialize SD LAG init/cleanup against LAG mode changes"
patch.
- Elaborate the commit message in "net/mlx5: LAG, reload IB reps of LAG
master before the rest".
V2:
https://lore.kernel.org/all/20260906071332.3759199-1-tariqt@nvidia.com/
Shay Drory (3):
net/mlx5: devcom, Base component size on linked devices
net/mlx5: SD, unload reps on shared FDB create error path
net/mlx5: LAG, reload IB reps of LAG master before the rest
.../net/ethernet/mellanox/mlx5/core/lag/lag.c | 44 ++++++++++++++-----
.../mellanox/mlx5/core/lag/shared_fdb.c | 1 +
.../ethernet/mellanox/mlx5/core/lib/devcom.c | 5 ++-
3 files changed, 37 insertions(+), 13 deletions(-)
base-commit: 23ca4ddc4fce2c233a49e9fd34d4b5b02bd7324e
--
2.44.0
next reply other threads:[~2026-09-15 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 11:34 Tariq Toukan [this message]
2026-09-15 11:34 ` [PATCH net V3 1/3] net/mlx5: devcom, Base component size on linked devices Tariq Toukan
2026-09-15 11:34 ` [PATCH net V3 2/3] net/mlx5: SD, unload reps on shared FDB create error path Tariq Toukan
2026-09-15 11:34 ` [PATCH net V3 3/3] net/mlx5: LAG, reload IB reps of LAG master before the rest Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915113459.3934760-1-tariqt@nvidia.com \
--to=tariqt@nvidia.com \
--cc=agoldberger@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®