* [PATCH] x86/resctrl: Update documented unit for the "activity" event
@ 2026-09-15 19:04 Tony Luck
2026-09-16 14:53 ` Reinette Chatre
0 siblings, 1 reply; 3+ messages in thread
From: Tony Luck @ 2026-09-15 19:04 UTC (permalink / raw)
To: Fenghua Yu, Reinette Chatre, Maciej Wieczor-Retman, Peter Newman,
James Morse, Babu Moger, Drew Fustini, Dave Martin, Chen Yu, x86
Cc: linux-kernel, patches, Tony Luck
The unit for the AET (Application Energy Telemetry) activity event[1] is nF, not F.
Fixes: a8848c4b43ad ("x86,fs/resctrl: Update documentation for telemetry events")
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: https://github.com/intel/Intel-PMT/blob/main/xml/CWF/OOBMSM/RMID-ENERGY/cwf_common.xml#L9 # [1]
---
Documentation/filesystems/resctrl.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
index e4b66af55ffb..a52cd812c261 100644
--- a/Documentation/filesystems/resctrl.rst
+++ b/Documentation/filesystems/resctrl.rst
@@ -643,7 +643,7 @@ When monitoring is enabled all MON groups will also contain:
during execution of instructions summed across all logical CPUs on a
package for the current monitoring group.
- "activity" also reports a floating point value (in Farads). This provides
+ "activity" also reports a floating point value (in nanofarads). This provides
an estimate of work done independent of the frequency that the CPUs used
for execution.
--
2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/resctrl: Update documented unit for the "activity" event
2026-09-15 19:04 [PATCH] x86/resctrl: Update documented unit for the "activity" event Tony Luck
@ 2026-09-16 14:53 ` Reinette Chatre
2026-09-16 15:51 ` Luck, Tony
0 siblings, 1 reply; 3+ messages in thread
From: Reinette Chatre @ 2026-09-16 14:53 UTC (permalink / raw)
To: Tony Luck, Fenghua Yu, Maciej Wieczor-Retman, Peter Newman,
James Morse, Babu Moger, Drew Fustini, Dave Martin, Chen Yu, x86
Cc: linux-kernel, patches
Hi Tony,
On 9/15/26 12:04 PM, Tony Luck wrote:
> The unit for the AET (Application Energy Telemetry) activity event[1] is nF, not F.
>
> Fixes: a8848c4b43ad ("x86,fs/resctrl: Update documentation for telemetry events")
Should this go to stable?
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Link: https://github.com/intel/Intel-PMT/blob/main/xml/CWF/OOBMSM/RMID-ENERGY/cwf_common.xml#L9 # [1]
> ---
> Documentation/filesystems/resctrl.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
> index e4b66af55ffb..a52cd812c261 100644
> --- a/Documentation/filesystems/resctrl.rst
> +++ b/Documentation/filesystems/resctrl.rst
> @@ -643,7 +643,7 @@ When monitoring is enabled all MON groups will also contain:
> during execution of instructions summed across all logical CPUs on a
> package for the current monitoring group.
>
> - "activity" also reports a floating point value (in Farads). This provides
> + "activity" also reports a floating point value (in nanofarads). This provides
> an estimate of work done independent of the frequency that the CPUs used
> for execution.
>
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] x86/resctrl: Update documented unit for the "activity" event
2026-09-16 14:53 ` Reinette Chatre
@ 2026-09-16 15:51 ` Luck, Tony
0 siblings, 0 replies; 3+ messages in thread
From: Luck, Tony @ 2026-09-16 15:51 UTC (permalink / raw)
To: Chatre, Reinette, Fenghua Yu, Wieczor-Retman, Maciej,
Peter Newman, James Morse, Babu Moger, Drew Fustini, Dave Martin,
Chen, Yu C, x86
Cc: linux-kernel, patches
> > The unit for the AET (Application Energy Telemetry) activity event[1] is nF, not F.
> >
> > Fixes: a8848c4b43ad ("x86,fs/resctrl: Update documentation for telemetry events")
>
> Should this go to stable?
Possibly. Though I'm not sure it would really help anyone. I don't expect anyone to change
anything based on the units here. Anyone who was using "activity" to monitor changes in
power consumption resulting from changes to their code would just have compared the
before/after values. Knowing that both numbers are nF rather than F wouldn't change
anything.
> > Signed-off-by: Tony Luck <tony.luck@intel.com>
> > Link: https://github.com/intel/Intel-PMT/blob/main/xml/CWF/OOBMSM/RMID-ENERGY/cwf_common.xml#L9 # [1]
-Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-16 15:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-15 19:04 [PATCH] x86/resctrl: Update documented unit for the "activity" event Tony Luck
2026-09-16 14:53 ` Reinette Chatre
2026-09-16 15:51 ` Luck, Tony
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®