[PATCH] firewire: core: correct comment about execution context

[PATCH] firewire: core: correct comment about execution context

[Takashi Sakamoto]

The comment for fw_address_callback_t describes the execution context,
but the callback has not been called from RCU read-side critical section
since v6.17.

Fixes: e884a8a0c573 ("firewire: core: call FCP address handlers outside RCU read-side critical section")
Fixes: e8cf6875005b ("firewire: core: call handler for exclusive regions outside RCU read-side critical section")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 include/linux/firewire.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/firewire.h b/include/linux/firewire.h
index a1e0cb4526c9..cbe59a18162e 100644
--- a/include/linux/firewire.h
+++ b/include/linux/firewire.h
@@ -299,8 +299,9 @@ union fw_transaction_callback {
 };
 
 /*
- * This callback handles an inbound request subaction.  It is called in
- * RCU read-side context, therefore must not sleep.
+ * This callback handles an inbound request subaction. If the request subaction is initiated from
+ * the local node (e.g. by unit driver), the execution context depends on the initiator and is
+ * unspecified. Otherwise, it runs in workqueue context.
  *
  * The callback should not initiate outbound request subactions directly.
  * Otherwise there is a danger of recursion of inbound and outbound
-- 
2.53.0

Re: [PATCH] firewire: core: correct comment about execution context

[Takashi Sakamoto]

On Tue, Sep 15, 2026 at 07:14:34AM +0900, Takashi Sakamoto wrote:
> The comment for fw_address_callback_t describes the execution context,
> but the callback has not been called from RCU read-side critical section
> since v6.17.
> 
> Fixes: e884a8a0c573 ("firewire: core: call FCP address handlers outside RCU read-side critical section")
> Fixes: e8cf6875005b ("firewire: core: call handler for exclusive regions outside RCU read-side critical section")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
>  include/linux/firewire.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto