[PATCH] usb: fotg210: fix link error for CONFIG_USB=n

[PATCH] usb: fotg210: fix link error for CONFIG_USB=n

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

Calling usb_hcd_platform_shutdown() is not possible if CONFIG_USB
is disabled:

arm-linux-gnueabi-ld: drivers/usb/fotg210/fotg210-core.o: in function `fotg210_shutdown':
fotg210-core.c:(.text+0x40): undefined reference to `usb_hcd_platform_shutdown'

Move this call into the hcd file to ensure this is only used
when USB host mode is actually available.

Fixes: 7dbc2e1ba8fd ("usb: fotg210: use the common EHCI core")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/usb/fotg210/fotg210-core.c | 2 +-
 drivers/usb/fotg210/fotg210-hcd.c  | 5 +++++
 drivers/usb/fotg210/fotg210.h      | 5 +++++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/fotg210/fotg210-core.c b/drivers/usb/fotg210/fotg210-core.c
index 7976bdae5f07..86e9ecd2c8ed 100644
--- a/drivers/usb/fotg210/fotg210-core.c
+++ b/drivers/usb/fotg210/fotg210-core.c
@@ -259,7 +259,7 @@ static void fotg210_remove(struct platform_device *pdev)
 static void fotg210_shutdown(struct platform_device *pdev)
 {
 	if (usb_get_dr_mode(&pdev->dev) != USB_DR_MODE_PERIPHERAL)
-		usb_hcd_platform_shutdown(pdev);
+		fotg210_hcd_shutdown(pdev);
 }
 
 static int fotg210_suspend(struct device *dev)
diff --git a/drivers/usb/fotg210/fotg210-hcd.c b/drivers/usb/fotg210/fotg210-hcd.c
index 0a36820f189b..8e2346a3e23f 100644
--- a/drivers/usb/fotg210/fotg210-hcd.c
+++ b/drivers/usb/fotg210/fotg210-hcd.c
@@ -186,6 +186,11 @@ int fotg210_hcd_remove(struct platform_device *pdev)
 	return 0;
 }
 
+void fotg210_hcd_shutdown(struct platform_device *pdev)
+{
+	usb_hcd_platform_shutdown(pdev);
+}
+
 int fotg210_hcd_suspend(struct device *dev)
 {
 #ifdef CONFIG_PM
diff --git a/drivers/usb/fotg210/fotg210.h b/drivers/usb/fotg210/fotg210.h
index aab0f0300dc8..96a8cf76deeb 100644
--- a/drivers/usb/fotg210/fotg210.h
+++ b/drivers/usb/fotg210/fotg210.h
@@ -26,6 +26,7 @@ void fotg210_vbus(struct fotg210 *fotg, bool enable);
 #ifdef CONFIG_USB_FOTG210_HCD
 int fotg210_hcd_probe(struct platform_device *pdev, struct fotg210 *fotg);
 int fotg210_hcd_remove(struct platform_device *pdev);
+void fotg210_hcd_shutdown(struct platform_device *pdev);
 int fotg210_hcd_suspend(struct device *dev);
 int fotg210_hcd_resume(struct device *dev);
 int fotg210_hcd_init(void);
@@ -42,6 +43,10 @@ static inline int fotg210_hcd_remove(struct platform_device *pdev)
 	return -ENODEV;
 }
 
+static inline void fotg210_hcd_shutdown(struct platform_device *pdev)
+{
+}
+
 static inline int fotg210_hcd_suspend(struct device *dev)
 {
 	return -ENODEV;
-- 
2.53.0

Re: [PATCH] usb: fotg210: fix link error for CONFIG_USB=n

[Linus Walleij]

On Wed, Sep 16, 2026 at 10:26 AM Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> Calling usb_hcd_platform_shutdown() is not possible if CONFIG_USB
> is disabled:
>
> arm-linux-gnueabi-ld: drivers/usb/fotg210/fotg210-core.o: in function `fotg210_shutdown':
> fotg210-core.c:(.text+0x40): undefined reference to `usb_hcd_platform_shutdown'
>
> Move this call into the hcd file to ensure this is only used
> when USB host mode is actually available.
>
> Fixes: 7dbc2e1ba8fd ("usb: fotg210: use the common EHCI core")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Good catch!
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [PATCH] usb: fotg210: fix link error for CONFIG_USB=n

[Arnd Bergmann]

On Wed, Sep 16, 2026, at 11:45, Linus Walleij wrote:
> On Wed, Sep 16, 2026 at 10:26 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Calling usb_hcd_platform_shutdown() is not possible if CONFIG_USB
>> is disabled:
>>
>> arm-linux-gnueabi-ld: drivers/usb/fotg210/fotg210-core.o: in function `fotg210_shutdown':
>> fotg210-core.c:(.text+0x40): undefined reference to `usb_hcd_platform_shutdown'
>>
>> Move this call into the hcd file to ensure this is only used
>> when USB host mode is actually available.
>>
>> Fixes: 7dbc2e1ba8fd ("usb: fotg210: use the common EHCI core")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Good catch!
> Reviewed-by: Linus Walleij <linusw@kernel.org>

Apparently you you already fixed this yourself in commit 600334ef2f29
("usb: fotg210: guard host shutdown in gadget-only builds") in today's
linux-next, so this one is no longer needed, the two patches are
equivalent.

I did run into an unrelated problem with fotg210 now, and I'll send a
patch for that.

    Arnd

Re: [PATCH] usb: fotg210: fix link error for CONFIG_USB=n

[Linus Walleij]

On Wed, Sep 16, 2026 at 1:44 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Wed, Sep 16, 2026, at 11:45, Linus Walleij wrote:
> > On Wed, Sep 16, 2026 at 10:26 AM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >> Calling usb_hcd_platform_shutdown() is not possible if CONFIG_USB
> >> is disabled:
> >>
> >> arm-linux-gnueabi-ld: drivers/usb/fotg210/fotg210-core.o: in function `fotg210_shutdown':
> >> fotg210-core.c:(.text+0x40): undefined reference to `usb_hcd_platform_shutdown'
> >>
> >> Move this call into the hcd file to ensure this is only used
> >> when USB host mode is actually available.
> >>
> >> Fixes: 7dbc2e1ba8fd ("usb: fotg210: use the common EHCI core")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Good catch!
> > Reviewed-by: Linus Walleij <linusw@kernel.org>
>
> Apparently you you already fixed this yourself in commit 600334ef2f29
> ("usb: fotg210: guard host shutdown in gadget-only builds") in today's
> linux-next, so this one is no longer needed, the two patches are
> equivalent.

Haha the solution was so different that I didn't understand it was
the same problem :D

Yours,
Linus Walleij