mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Kanak Shilledar <Kanak.Shilledar@axis.com>
Cc: "jic23@kernel.org" <jic23@kernel.org>,
	"dlechner@baylibre.com" <dlechner@baylibre.com>,
	Henrik Grimler <Henrik.Grimler@axis.com>,
	"nuno.sa@analog.com" <nuno.sa@analog.com>,
	"jean-baptiste.maneyrol@tdk.com" <jean-baptiste.maneyrol@tdk.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"marcelo.schmitt1@gmail.com" <marcelo.schmitt1@gmail.com>,
	"andy@kernel.org" <andy@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"macromorgan@hotmail.com" <macromorgan@hotmail.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	Kernel <Kernel@axis.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 7/8] iio: imu: inv_icm42607: Add accelerometer calibbias support
Date: Wed, 16 Sep 2026 11:44:57 +0200	[thread overview]
Message-ID: <20260916114457.000073ba@gmail.com> (raw)
In-Reply-To: <b58448efafcd27ceb2c924139ea97201b349b534.camel@axis.com>

On Wed, 16 Sep 2026 09:37:32 +0000
Kanak Shilledar <Kanak.Shilledar@axis.com> wrote:

> Hi Jonathan,
> 
> On Mon, 2026-09-07 at 02:54 +0100, Jonathan Cameron wrote:
> > > Expose IIO_CHAN_INFO_CALIBBIAS on the accelerometer channels. The
> > > registers are stored in MREG1, which can be accessed by the
> > > mreg_read
> > > and mreg_write routines. The calibration bias is written to
> > > OFFSET_USER4
> > > to OFFSET_USER8 registers in MREG1.
> > > 
> > > Note: The accelerometer functionality is tested with Invensense,
> > > ICM42370-P development board.
> > > 
> > > Datasheet:
> > > https://www.invensense.tdk.com/en-us/products/3-axis/icm-42370-p
> > > Datasheet: https://www.lcsc.com/product-detail/C5129967.html
> > > Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>  
> > 
> > Various things inline.
> > 
> > Thanks
> > 
> > Jonathan  
> 
> I will fix these issues.
> Thanks and Regards,
> Kanak Shilledar
> 

Hi Kanak,

No need to send a response to a review only saying you'll fix the
pointed out issues, it generates too much noise on the list. No
response means you agree with the review and will address it in
the next version :)

Thanks!

--
Kind regards,
Joshua Crofts

  reply	other threads:[~2026-09-16  9:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 14:35 [PATCH v3 0/8] Add support for InvenSense ICM-42370-P accelerometer Kanak Shilledar
2026-09-01 14:35 ` [PATCH v3 1/8] dt-bindings: Add InvenSense ICM-42370-p accelerometer Kanak Shilledar
2026-09-07  1:54   ` Jonathan Cameron
2026-09-16  9:25     ` Kanak Shilledar
2026-09-01 14:35 ` [PATCH v3 2/8] iio: imu: inv_icm42607: Update IIO channel macros Kanak Shilledar
2026-09-01 14:35 ` [PATCH v3 3/8] iio: imu: inv_icm42607: Update _odr_to_period_us formatting Kanak Shilledar
2026-09-07  1:54   ` Jonathan Cameron
2026-09-15 17:20     ` Chris Morgan
2026-09-16  9:23       ` Kanak Shilledar
2026-09-01 14:35 ` [PATCH v3 4/8] iio: imu: inv_icm42607: Switch to little endian Kanak Shilledar
2026-09-07  1:54   ` Jonathan Cameron
2026-09-16  9:26     ` Kanak Shilledar
2026-09-01 14:35 ` [PATCH v3 5/8] iio: imu: inv_icm42607: Add support for ICM-42370-P Kanak Shilledar
2026-09-07  1:54   ` Jonathan Cameron
2026-09-16  9:28     ` Kanak Shilledar
2026-09-01 14:35 ` [PATCH v3 6/8] iio: imu: inv_icm42607: Implement MREGx register access Kanak Shilledar
2026-09-07  1:54   ` Jonathan Cameron
2026-09-07 11:52   ` Jean-Baptiste Maneyrol
2026-09-16  9:30     ` Kanak Shilledar
2026-09-01 14:36 ` [PATCH v3 7/8] iio: imu: inv_icm42607: Add accelerometer calibbias support Kanak Shilledar
2026-09-07  1:54   ` Jonathan Cameron
2026-09-16  9:37     ` Kanak Shilledar
2026-09-16  9:44       ` Joshua Crofts [this message]
2026-09-15 17:27   ` Chris Morgan
2026-09-16  9:42     ` Kanak Shilledar
2026-09-01 14:36 ` [PATCH v3 8/8] iio: imu: inv_icm42607: Add gyroscope " Kanak Shilledar
2026-09-07  1:54   ` Jonathan Cameron
2026-09-02  5:30 ` [PATCH v3 0/8] Add support for InvenSense ICM-42370-P accelerometer Andy Shevchenko
2026-09-07  1:54   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916114457.000073ba@gmail.com \
    --to=joshua.crofts1@gmail.com \
    --cc=Henrik.Grimler@axis.com \
    --cc=Kanak.Shilledar@axis.com \
    --cc=Kernel@axis.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jean-baptiste.maneyrol@tdk.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macromorgan@hotmail.com \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®