* [PATCH net] eth: fbnic: Fix payload page pool error cleanup
@ 2026-09-15 10:49 Björn Töpel
2026-09-16 12:52 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Björn Töpel @ 2026-09-15 10:49 UTC (permalink / raw)
To: Alexander Duyck, Jakub Kicinski, kernel-team, Andrew Lunn,
David S. Miller, Eric Dumazet, Paolo Abeni, netdev
Cc: Björn Töpel, Mina Almasry, linux-kernel, Sashiko
The payload page pool pointer contains an error pointer when its
allocation fails. The cleanup path passes that error pointer to
page_pool_destroy() instead of destroying the header page pool. This
can dereference the error pointer and leave the header page pool
allocated.
Destroy the header page pool instead.
Fixes: 8a11010fdd96 ("eth: fbnic: allocate unreadable page pool for the payloads")
Reported-by: Sashiko <netdev-bot+sashiko@kernel.org>
Link: https://lore.kernel.org/netdev/178915061000.219967.7726187707862333281@kernel.org/
Signed-off-by: Björn Töpel <bjorn@kernel.org>
---
drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
index 401f8b8ae1ca..528d72071aff 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
@@ -1599,7 +1599,7 @@ fbnic_alloc_qt_page_pools(struct fbnic_net *fbn, struct fbnic_q_triad *qt,
return 0;
err_destroy_sub0:
- page_pool_destroy(pp);
+ page_pool_destroy(qt->sub0.page_pool);
return PTR_ERR(pp);
}
base-commit: 18a6fe05fb6e18de29fa90d388bb34044114b3d8
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] eth: fbnic: Fix payload page pool error cleanup
2026-09-15 10:49 [PATCH net] eth: fbnic: Fix payload page pool error cleanup Björn Töpel
@ 2026-09-16 12:52 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2026-09-16 12:52 UTC (permalink / raw)
To: Björn Töpel
Cc: Alexander Duyck, Jakub Kicinski, kernel-team, Andrew Lunn,
David S. Miller, Eric Dumazet, Paolo Abeni, netdev, Mina Almasry,
linux-kernel, Sashiko
On Tue, Sep 15, 2026 at 12:49:15PM +0200, Björn Töpel wrote:
> The payload page pool pointer contains an error pointer when its
> allocation fails. The cleanup path passes that error pointer to
> page_pool_destroy() instead of destroying the header page pool. This
> can dereference the error pointer and leave the header page pool
> allocated.
>
> Destroy the header page pool instead.
>
> Fixes: 8a11010fdd96 ("eth: fbnic: allocate unreadable page pool for the payloads")
> Reported-by: Sashiko <netdev-bot+sashiko@kernel.org>
> Link: https://lore.kernel.org/netdev/178915061000.219967.7726187707862333281@kernel.org/
> Signed-off-by: Björn Töpel <bjorn@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-16 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-15 10:49 [PATCH net] eth: fbnic: Fix payload page pool error cleanup Björn Töpel
2026-09-16 12:52 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®