From: Igor Paunovic <royalnet026@gmail.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: Igor Paunovic <royalnet026@gmail.com>,
tomeu@tomeuvizoso.net, ogabbay@kernel.org,
jeff.hugo@oss.qualcomm.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/4] accel/rocket: fix runtime PM refcount leak in rocket_job_run()
Date: Wed, 16 Sep 2026 18:10:53 +0200 [thread overview]
Message-ID: <20260916161053.11926-1-royalnet026@gmail.com> (raw)
In-Reply-To: <20260915041047.1724928-1-vulab@iscas.ac.cn>
Hi Wentao,
This looks already fixed in mainline by commit 9b2dedadf6a9
("accel/rocket: Fix error path handling in rocket_job_run()"), which
is in v7.3-rc1, and the same code is in the 7.2.y and 6.18.y stable
trees. There, rocket_job_run() already uses
pm_runtime_resume_and_get() and drops the reference with
pm_runtime_put() when iommu_attach_group() fails.
Your diff is against the older rocket_job.c (index ac51bff39833, the
v7.1/v7.2 file), so it no longer applies to current mainline.
I checked this with the help of an LLM assistant, against the
git.kernel.org trees.
Igor
prev parent reply other threads:[~2026-09-16 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 4:10 Wentao Liang
2026-09-16 16:10 ` Igor Paunovic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916161053.11926-1-royalnet026@gmail.com \
--to=royalnet026@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomeu@tomeuvizoso.net \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®