* [PATCH v3 1/4] mm: hugetlb: Track used_hpages when getting/putting pages from subpool
2026-09-16 23:39 [PATCH v3 0/4] Fix HugeTLB subpool used_hpages tracking Ackerley Tng via B4 Relay
@ 2026-09-16 23:39 ` Ackerley Tng via B4 Relay
2026-09-16 23:39 ` [PATCH v3 2/4] mm: hugetlb: Fix out_put_pages subpool reserve calculation Ackerley Tng via B4 Relay
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Ackerley Tng via B4 Relay @ 2026-09-16 23:39 UTC (permalink / raw)
To: Alex Shi, Andrew Morton, David Hildenbrand, Dongliang Mu,
Hongxiang Lou, Johannes Weiner, Jonathan Corbet, Joshua Hahn,
Liam R. Howlett, Lorenzo Stoakes, Miaohe Lin, Michal Hocko,
Mike Rapoport, Muchun Song, Nhat Pham, Oscar Salvador, Peter Xu,
Randy Dunlap, Roman Gushchin, Shakeel Butt, Shuah Khan,
Suren Baghdasaryan, Usama Arif, Vlastimil Babka, Wupeng Ma,
Yanteng Si, Naoya Horiguchi, fvdl, jthoughton, rientjes,
vannapurve
Cc: linux-doc, linux-kernel, linux-mm, Ackerley Tng, stable
From: Ackerley Tng <ackerleytng@google.com>
HugeTLB subpools currently only track used pages (used_hpages) when a
maximum size limit (max_hpages) is configured.
This breaks minimum size (min_hpages) guarantees. The subpool guarantee
requires that the sum of used pages and remaining subpool reserves
satisfies the configured minimum:
used_hpages + rsv_hpages >= min_hpages
where used_hpages includes both allocated folios and active reservations.
Therefore, when pages or reservations are released, the maximum number
of reservations the subpool can absorb is:
limit = max(0, min_hpages - used_hpages)
When used_hpages is untracked and remains zero,
hugepage_subpool_put_pages() assumes limit == min_hpages. It falsely
restores reservations to the subpool even when existing allocations
already satisfy the guarantee.
This false restoration leads to:
1. Leaked global reservations: resv_huge_pages is not decremented,
reducing the huge pages available for use across the host.
2. Premature freeing: the subpool considers itself unreferenced on
unmount (rsv_hpages == min_hpages), freeing the subpool while folios
are still active in page cache and leading to a use-after-free.
Fix this by unconditionally tracking used_hpages in the subpool, and
capping the reservations the subpool can absorb to
(min_hpages - used_hpages).
With used_hpages always tracked:
- subpool_is_free() is simplified to check whether used_hpages is zero.
- hugetlbfs_statfs() is updated to explicitly check for max_hpages == -1;
previously it relied on (-1 - 0) evaluating to -1, which would now
underflow and report negative free block counts.
Trace of a false restoration:
1. Mount time:
+ spool->min_hpages = 1 (user requested min_size=2M)
+ spool->max_hpages = -1 (no maximum size specified)
+ spool->rsv_hpages = 1 (reserve min_hpages)
+ spool->used_hpages = 0 (untracked when max_hpages == -1)
+ h->resv_huge_pages = 1 (reserved by hugetlb_acct_memory(h, 1))
2. Shared mapping of 4MB (2 pages) created (mmap with MAP_SHARED):
+ In hugetlb_reserve_pages(), region_chg() finds chg = 2 (pages 0
and 1 need reservations)
+ hugepage_subpool_get_pages(spool, 2):
+ spool->rsv_hpages = 0 (consumed the 1 subpool reservation)
+ Returns 1 (since this subpool only had 1 reservation)
+ hugetlb_acct_memory(h, 1):
+ h->resv_huge_pages = 2 (incremented from 1 to 2 for the
global reservation)
+ region_add() records reservations for pages 0 and 1 in
resv_map
3. Process touches and populates Page 0:
+ hugetlb_no_page() calls alloc_hugetlb_folio()
+ Page 0 reuses the existing reservation (vma_needs_reservation()
returns 0 => map_chg = MAP_CHG_REUSE = 0)
+ hugepage_subpool_get_pages() is not called (map_chg == 0)
+ dequeue_hugetlb_folio_nodemask() consumes 1 reservation:
h->resv_huge_pages = 1 (decremented from 2 to 1)
4. Process closes the file and exits:
+ For MAP_SHARED mappings, reservations persist in inode resv_map
+ Page 1 reservation remains active
+ h->resv_huge_pages = 1 (retained for Page 1)
5. File is truncated to 2MB (truncate -s 2M):
+ Truncation invokes remove_inode_hugepages() for range [1, LONG_MAX)
+ Page 1 was never faulted into page cache => freed = 0
+ Calls hugetlb_unreserve_pages(inode, 1, LONG_MAX, freed = 0)
+ region_del() removes Page 1 from resv_map => chg = 1
6. Inside hugetlb_unreserve_pages(): hugepage_subpool_put_pages(1):
+ delta = chg - freed = 1 - 0 = 1
+ Because spool->max_hpages == -1, spool->used_hpages always = 0
+ spool->used_hpages < spool->min_hpages (0 < 1 => true)
<<== subpool assumes 0 pages are in use, ignoring allocated Page 0
+ spool->rsv_hpages + delta <= spool->min_hpages (0 + 1 <= 1 => true)
+ spool->rsv_hpages += 1 => spool->rsv_hpages = 1
<<== false reservation restored to subpool
+ Returns 0 (subpool absorbed the reservation)
7. Back in hugetlb_unreserve_pages(): hugetlb_acct_memory():
+ hugetlb_acct_memory(h, -0) does nothing
+ h->resv_huge_pages remains stuck at 1 even though both reservations
have ended (Page 0 allocated, Page 1 truncated)
8. Later during unmounting:
+ subpool_is_free() checks spool->rsv_hpages == spool->min_hpages
(1 == 1 => true)
+ The subpool is erroneously considered completely free
+ hugetlb_acct_memory(spool->hstate, -spool->min_hpages) decrements
h->resv_huge_pages by 1 (1 - 1 = 0), masking the leak on unmount
9. If the folio outlives the inode:
+ When Page 0 is freed, free_huge_folio() attempts to access the
freed subpool pointer, leading to a use-after-free and double-free.
Fixes: 09a95e29cb30 ("mm/hugetlb: optimize minimum size (min_size) accounting")
Fixes: 1c5ecae3a93fa ("hugetlbfs: add minimum size accounting to subpools")
Signed-off-by: Ackerley Tng <ackerleytng@google.com>
Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: stable@vger.kernel.org
---
Documentation/mm/hugetlbfs_reserv.rst | 17 +----
.../translations/zh_CN/mm/hugetlbfs_reserv.rst | 11 +---
fs/hugetlbfs/inode.c | 8 ++-
include/linux/hugetlb.h | 4 +-
mm/hugetlb.c | 73 +++++++++++++---------
5 files changed, 55 insertions(+), 58 deletions(-)
diff --git a/Documentation/mm/hugetlbfs_reserv.rst b/Documentation/mm/hugetlbfs_reserv.rst
index a49115db18c76..d244583fdcbc3 100644
--- a/Documentation/mm/hugetlbfs_reserv.rst
+++ b/Documentation/mm/hugetlbfs_reserv.rst
@@ -314,21 +314,8 @@ huge pages. If they can not be reserved, the mount fails.
The routines hugepage_subpool_get/put_pages() are called when pages are
obtained from or released back to a subpool. They perform all subpool
accounting, and track any reservations associated with the subpool.
-hugepage_subpool_get/put_pages are passed the number of huge pages by which
-to adjust the subpool 'used page' count (down for get, up for put). Normally,
-they return the same value that was passed or an error if not enough pages
-exist in the subpool.
-
-However, if reserves are associated with the subpool a return value less
-than the passed value may be returned. This return value indicates the
-number of additional global pool adjustments which must be made. For example,
-suppose a subpool contains 3 reserved huge pages and someone asks for 5.
-The 3 reserved pages associated with the subpool can be used to satisfy part
-of the request. But, 2 pages must be obtained from the global pools. To
-relay this information to the caller, the value 2 is returned. The caller
-is then responsible for attempting to obtain the additional two pages from
-the global pools.
-
+hugepage_subpool_get/put_pages() use the number of huge pages passed to adjust
+the subpool 'used page' count.
COW and Reservations
====================
diff --git a/Documentation/translations/zh_CN/mm/hugetlbfs_reserv.rst b/Documentation/translations/zh_CN/mm/hugetlbfs_reserv.rst
index 20947f8bd0654..ae1f1f31477fc 100644
--- a/Documentation/translations/zh_CN/mm/hugetlbfs_reserv.rst
+++ b/Documentation/translations/zh_CN/mm/hugetlbfs_reserv.rst
@@ -246,15 +246,8 @@ hugepage_subpool的min_hpages字段中被跟踪。在挂载时，hugetlb_acct_me
被调用以预留指定数量的巨页。如果它们不能被预留，挂载就会失败。
当从子池中获取或释放页面时，会调用hugepage_subpool_get/put_pages()函数。
-hugepage_subpool_get/put_pages被传递给巨页数量，以此来调整子池的 “已用页面” 计数
-（get为下降，put为上升）。通常情况下，如果子池中没有足够的页面，它们会返回与传递的相同的值或
-一个错误。
-
-然而，如果预留与子池相关联，可能会返回一个小于传递值的返回值。这个返回值表示必须进行的额外全局
-池调整的数量。例如，假设一个子池包含3个预留的巨页，有人要求5个。与子池相关的3个预留页可以用来
-满足部分请求。但是，必须从全局池中获得2个页面。为了向调用者转达这一信息，将返回值2。然后，调用
-者要负责从全局池中获取另外两个页面。
-
+它们负责所有子池的统计核算，并跟踪与子池相关联的预留。
+hugepage_subpool_get/put_pages()函数使用传入的巨页数量来调整子池的“已用页面”计数。
COW和预留
==========
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 7611a8470ea26..5113f743f6fc7 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -1109,8 +1109,12 @@ static int hugetlbfs_statfs(struct dentry *dentry, struct kstatfs *buf)
spin_lock_irq(&sbinfo->spool->lock);
buf->f_blocks = sbinfo->spool->max_hpages;
- free_pages = sbinfo->spool->max_hpages
- - sbinfo->spool->used_hpages;
+ if (sbinfo->spool->max_hpages == -1) {
+ free_pages = -1;
+ } else {
+ free_pages = sbinfo->spool->max_hpages -
+ sbinfo->spool->used_hpages;
+ }
buf->f_bavail = buf->f_bfree = free_pages;
spin_unlock_irq(&sbinfo->spool->lock);
buf->f_files = sbinfo->max_inodes;
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index 16c4c4caa126c..4551ff3023640 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -39,8 +39,8 @@ struct hugepage_subpool {
spinlock_t lock;
long count;
long max_hpages; /* Maximum huge pages or -1 if no maximum. */
- long used_hpages; /* Used count against maximum, includes */
- /* both allocated and reserved pages. */
+ long used_hpages; /* Used page count, includes both */
+ /* allocated and reserved pages. */
struct hstate *hstate;
long min_hpages; /* Minimum huge pages or -1 if no minimum. */
long rsv_hpages; /* Pages reserved against global pool to */
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 4f6f58bf3db6c..e72e22f887478 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -130,12 +130,8 @@ static inline bool subpool_is_free(struct hugepage_subpool *spool)
{
if (spool->count)
return false;
- if (spool->max_hpages != -1)
- return spool->used_hpages == 0;
- if (spool->min_hpages != -1)
- return spool->rsv_hpages == spool->min_hpages;
- return true;
+ return spool->used_hpages == 0;
}
static inline void unlock_or_release_subpool(struct hugepage_subpool *spool,
@@ -193,13 +189,18 @@ void hugepage_put_subpool(struct hugepage_subpool *spool)
unlock_or_release_subpool(spool, flags);
}
-/*
- * Subpool accounting for allocating and reserving pages.
- * Return -ENOMEM if there are not enough resources to satisfy the
- * request. Otherwise, return the number of pages by which the
- * global pools must be adjusted (upward). The returned value may
- * only be different than the passed value (delta) in the case where
- * a subpool minimum size must be maintained.
+/**
+ * hugepage_subpool_get_pages - Get pages from a subpool
+ * @spool: pointer to subpool structure (may be NULL)
+ * @delta: number of pages to allocate or reserve
+ *
+ * Check and update subpool page usage counts when allocating or
+ * reserving @delta hugepages.
+ *
+ * Context: Takes spool->lock using spin_lock_irq().
+ * Return: Non-negative number of reservations that cannot be
+ * satisfied by the subpool, or -ENOMEM if the subpool maximum
+ * limit would be exceeded.
*/
static long hugepage_subpool_get_pages(struct hugepage_subpool *spool,
long delta)
@@ -211,15 +212,14 @@ static long hugepage_subpool_get_pages(struct hugepage_subpool *spool,
spin_lock_irq(&spool->lock);
- if (spool->max_hpages != -1) { /* maximum size accounting */
- if ((spool->used_hpages + delta) <= spool->max_hpages)
- spool->used_hpages += delta;
- else {
- ret = -ENOMEM;
- goto unlock_ret;
- }
+ if (spool->max_hpages != -1 &&
+ spool->used_hpages + delta > spool->max_hpages) {
+ ret = -ENOMEM;
+ goto unlock_ret;
}
+ spool->used_hpages += delta;
+
/* minimum size accounting */
if (spool->min_hpages != -1 && spool->rsv_hpages) {
if (delta > spool->rsv_hpages) {
@@ -240,11 +240,19 @@ static long hugepage_subpool_get_pages(struct hugepage_subpool *spool,
return ret;
}
-/*
- * Subpool accounting for freeing and unreserving pages.
- * Return the number of global page reservations that must be dropped.
- * The return value may only be different than the passed value (delta)
- * in the case where a subpool minimum size must be maintained.
+/**
+ * hugepage_subpool_put_pages - Release pages back to a subpool
+ * @spool: pointer to subpool structure (may be NULL)
+ * @delta: number of pages to free or unreserve
+ *
+ * Check and update subpool page usage counts when freeing or
+ * unreserving @delta hugepages.
+ *
+ * Context: Takes spool->lock using spin_lock_irqsave(). May release
+ * and free @spool if its usage count and references reach
+ * zero.
+ * Return: Non-negative number of reservations that the subpool cannot
+ * absorb.
*/
static long hugepage_subpool_put_pages(struct hugepage_subpool *spool,
long delta)
@@ -257,19 +265,24 @@ static long hugepage_subpool_put_pages(struct hugepage_subpool *spool,
spin_lock_irqsave(&spool->lock, flags);
- if (spool->max_hpages != -1) /* maximum size accounting */
- spool->used_hpages -= delta;
+ spool->used_hpages -= delta;
/* minimum size accounting */
if (spool->min_hpages != -1 && spool->used_hpages < spool->min_hpages) {
- if (spool->rsv_hpages + delta <= spool->min_hpages)
+ /*
+ * limit is the maximum number of reservations that
+ * can be restored to this subpool.
+ */
+ long limit = spool->min_hpages - spool->used_hpages;
+
+ if (spool->rsv_hpages + delta <= limit)
ret = 0;
else
- ret = spool->rsv_hpages + delta - spool->min_hpages;
+ ret = spool->rsv_hpages + delta - limit;
spool->rsv_hpages += delta;
- if (spool->rsv_hpages > spool->min_hpages)
- spool->rsv_hpages = spool->min_hpages;
+ if (spool->rsv_hpages > limit)
+ spool->rsv_hpages = limit;
}
/*
--
2.55.0.1082.g2b9226bbc0-goog
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 2/4] mm: hugetlb: Fix out_put_pages subpool reserve calculation
2026-09-16 23:39 [PATCH v3 0/4] Fix HugeTLB subpool used_hpages tracking Ackerley Tng via B4 Relay
2026-09-16 23:39 ` [PATCH v3 1/4] mm: hugetlb: Track used_hpages when getting/putting pages from subpool Ackerley Tng via B4 Relay
@ 2026-09-16 23:39 ` Ackerley Tng via B4 Relay
2026-09-16 23:39 ` [PATCH v3 3/4] mm: hugetlb: Fix subpool usage leak on allocation failure Ackerley Tng via B4 Relay
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Ackerley Tng via B4 Relay @ 2026-09-16 23:39 UTC (permalink / raw)
To: Alex Shi, Andrew Morton, David Hildenbrand, Dongliang Mu,
Hongxiang Lou, Johannes Weiner, Jonathan Corbet, Joshua Hahn,
Liam R. Howlett, Lorenzo Stoakes, Miaohe Lin, Michal Hocko,
Mike Rapoport, Muchun Song, Nhat Pham, Oscar Salvador, Peter Xu,
Randy Dunlap, Roman Gushchin, Shakeel Butt, Shuah Khan,
Suren Baghdasaryan, Usama Arif, Vlastimil Babka, Wupeng Ma,
Yanteng Si, Naoya Horiguchi, fvdl, jthoughton, rientjes,
vannapurve
Cc: linux-doc, linux-kernel, linux-mm, Ackerley Tng, stable
From: Ackerley Tng <ackerleytng@google.com>
When reserving pages for a mapping fails during global accounting, the
error path rolls back the adjustments made to the subpool.
Currently, this rollback was performed in two separate steps:
1. Returning only the portion of reservations originally satisfied from the
subpool
2. Separately adjusting the subpool used pages counter for the portion that
was requested from the global pool.
In (1.), because the used pages counter had not yet been decremented for
the global portion, the subpool observed an inflated used pages count. If
the mount was configured with both a minimum size and a maximum size, this
inflated count prevented the subpool from recognizing that usage fell below
the minimum size guarantee.
As a result, the subpool failed to restore its reserved pages counter and
instead returned that a global reservation should be dropped. The
mount-time reservation is permanently destroyed, leaving global reservation
counts depleted and causing an underflow when the filesystem is eventually
unmounted.
Additionally, if concurrent threads modified subpool usage during the
reservation attempt, calculating the rollback amount using stale local
variables could cause global reservation counts to diverge.
Now that used pages are always tracked within the subpool, return the
entire requested page count to the subpool in a single call. Global
reservations are then adjusted using the difference between the
reservations originally requested and those returned, fixing the issues
described above.
Fixes: 1d3f9bb4c8af ("mm/hugetlb: restore failed global reservations to subpool")
Signed-off-by: Ackerley Tng <ackerleytng@google.com>
Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: stable@vger.kernel.org
---
mm/hugetlb.c | 44 ++++++++++++++++++--------------------------
1 file changed, 18 insertions(+), 26 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index e72e22f887478..faa799634822e 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -6676,12 +6676,14 @@ long hugetlb_reserve_pages(struct inode *inode,
struct vm_area_struct *vma,
vma_flags_t vma_flags)
{
- long chg = -1, add = -1, spool_resv, gbl_resv;
+ long chg = -1, add = -1;
struct hstate *h = hstate_inode(inode);
struct hugepage_subpool *spool = subpool_inode(inode);
struct resv_map *resv_map;
struct hugetlb_cgroup *h_cg = NULL;
- long gbl_reserve, regions_needed = 0;
+ long regions_needed = 0;
+ long gbl_resv_get;
+ long gbl_resv_put;
int err;
/* This should never happen */
@@ -6756,9 +6758,9 @@ long hugetlb_reserve_pages(struct inode *inode,
* the subpool has a minimum size, there may be some global
* reservations already in place (gbl_reserve).
*/
- gbl_reserve = hugepage_subpool_get_pages(spool, chg);
- if (gbl_reserve < 0) {
- err = gbl_reserve;
+ gbl_resv_get = hugepage_subpool_get_pages(spool, chg);
+ if (gbl_resv_get < 0) {
+ err = gbl_resv_get;
goto out_uncharge_cgroup;
}
@@ -6766,7 +6768,7 @@ long hugetlb_reserve_pages(struct inode *inode,
* Check enough hugepages are available for the reservation.
* Hand the pages back to the subpool if there are not
*/
- err = hugetlb_acct_memory(h, gbl_reserve);
+ err = hugetlb_acct_memory(h, gbl_resv_get);
if (err < 0)
goto out_put_pages;
@@ -6785,7 +6787,7 @@ long hugetlb_reserve_pages(struct inode *inode,
add = region_add(resv_map, from, to, regions_needed, h, h_cg);
if (unlikely(add < 0)) {
- hugetlb_acct_memory(h, -gbl_reserve);
+ hugetlb_acct_memory(h, -gbl_resv_get);
err = add;
goto out_put_pages;
} else if (unlikely(chg > add)) {
@@ -6821,26 +6823,16 @@ long hugetlb_reserve_pages(struct inode *inode,
}
return chg;
-out_put_pages:
- spool_resv = chg - gbl_reserve;
- if (spool_resv) {
- /* put sub pool's reservation back, chg - gbl_reserve */
- gbl_resv = hugepage_subpool_put_pages(spool, spool_resv);
- /*
- * subpool's reserved pages can not be put back due to race,
- * return to hstate.
- */
- hugetlb_acct_memory(h, -gbl_resv);
- }
- /* Restore used_hpages for pages that failed global reservation */
- if (gbl_reserve && spool) {
- unsigned long flags;
+ out_put_pages:
+ gbl_resv_put = hugepage_subpool_put_pages(spool, chg);
+ /*
+ * There may be a difference between the number of
+ * reservations to consume and the number to restore now if
+ * there are multiple threads interacting with the subpool -
+ * restore the difference.
+ */
+ hugetlb_acct_memory(h, gbl_resv_get - gbl_resv_put);
- spin_lock_irqsave(&spool->lock, flags);
- if (spool->max_hpages != -1)
- spool->used_hpages -= gbl_reserve;
- unlock_or_release_subpool(spool, flags);
- }
out_uncharge_cgroup:
hugetlb_cgroup_uncharge_cgroup_rsvd(hstate_index(h),
chg * pages_per_huge_page(h), h_cg);
--
2.55.0.1082.g2b9226bbc0-goog
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 3/4] mm: hugetlb: Fix subpool usage leak on allocation failure
2026-09-16 23:39 [PATCH v3 0/4] Fix HugeTLB subpool used_hpages tracking Ackerley Tng via B4 Relay
2026-09-16 23:39 ` [PATCH v3 1/4] mm: hugetlb: Track used_hpages when getting/putting pages from subpool Ackerley Tng via B4 Relay
2026-09-16 23:39 ` [PATCH v3 2/4] mm: hugetlb: Fix out_put_pages subpool reserve calculation Ackerley Tng via B4 Relay
@ 2026-09-16 23:39 ` Ackerley Tng via B4 Relay
2026-09-16 23:39 ` [PATCH v3 4/4] mm: hugetlb: Avoid re-allocating global reservations on region add failure Ackerley Tng via B4 Relay
2026-09-17 3:13 ` [PATCH v3 0/4] Fix HugeTLB subpool used_hpages tracking Andrew Morton
4 siblings, 0 replies; 6+ messages in thread
From: Ackerley Tng via B4 Relay @ 2026-09-16 23:39 UTC (permalink / raw)
To: Alex Shi, Andrew Morton, David Hildenbrand, Dongliang Mu,
Hongxiang Lou, Johannes Weiner, Jonathan Corbet, Joshua Hahn,
Liam R. Howlett, Lorenzo Stoakes, Miaohe Lin, Michal Hocko,
Mike Rapoport, Muchun Song, Nhat Pham, Oscar Salvador, Peter Xu,
Randy Dunlap, Roman Gushchin, Shakeel Butt, Shuah Khan,
Suren Baghdasaryan, Usama Arif, Vlastimil Babka, Wupeng Ma,
Yanteng Si, Naoya Horiguchi, fvdl, jthoughton, rientjes,
vannapurve
Cc: linux-doc, linux-kernel, linux-mm, Ackerley Tng, stable
From: Ackerley Tng <ackerleytng@google.com>
When folio allocation fails early (e.g. buddy allocation failure or
cgroup charging failure) and a reservation was not used (meaning an
unreserved global page was needed), the subpool page acquired during the
allocation attempt must still be returned.
Currently, the subpool cleanup error path only returns the page to the
subpool if a reservation was used. If no reservation was used, it skips
releasing the page back to the subpool, permanently leaking the subpool's
used pages counter.
With subpools now always tracking used pages, always release the page
back to the subpool whenever a subpool page was acquired.
Opportunistically rename the local variables tracking global reservations
needed and global reservations returned. This clarifies the accounting:
a value of zero for needed global reservations indicates an existing
reservation satisfies the allocation, while a non-zero value indicates
new global pages are required.
Adjust global reservations using the difference between reservations
needed and reservations returned to properly handle races where concurrent
threads interact with the same subpool.
Fixes: a833a693a490 ("mm: hugetlb: fix incorrect fallback for subpool")
Signed-off-by: Ackerley Tng <ackerleytng@google.com>
Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: stable@vger.kernel.org
---
mm/hugetlb.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index faa799634822e..6589b188cf657 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2957,7 +2957,7 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma,
struct hugepage_subpool *spool = subpool_vma(vma);
struct hstate *h = hstate_vma(vma);
struct folio *folio;
- long retval, gbl_chg, gbl_reserve;
+ long retval, gbl_resv_get;
map_chg_state map_chg;
struct mempolicy_interpreted mpoli;
gfp_t gfp = htlb_alloc_mask(h);
@@ -2996,8 +2996,8 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma,
* Or if it can get one from the pool reservation directly.
*/
if (map_chg) {
- gbl_chg = hugepage_subpool_get_pages(spool, 1);
- if (gbl_chg < 0) {
+ gbl_resv_get = hugepage_subpool_get_pages(spool, 1);
+ if (gbl_resv_get < 0) {
ret = -ENOSPC;
goto out_end_reservation;
}
@@ -3006,7 +3006,7 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma,
* If we have the vma reservation ready, no need for extra
* global reservation.
*/
- gbl_chg = 0;
+ gbl_resv_get = 0;
}
/*
@@ -3017,10 +3017,10 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma,
alloc_flags |= HUGETLB_ALLOC_CHARG_CGROUP_RSVD;
/*
- * gbl_chg == 0 indicates a reservation exists for this
+ * gbl_resv_get == 0 indicates a reservation exists for this
* allocation, so try to use it.
*/
- if (gbl_chg == 0)
+ if (gbl_resv_get == 0)
alloc_flags |= HUGETLB_ALLOC_USE_GLOBAL_RESERVATIONS;
/* Takes reference on mpol. */
@@ -3074,13 +3074,10 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma,
return folio;
out_subpool_put:
- /*
- * put page to subpool iff the quota of subpool's rsv_hpages is used
- * during hugepage_subpool_get_pages.
- */
- if (map_chg && !gbl_chg) {
- gbl_reserve = hugepage_subpool_put_pages(spool, 1);
- hugetlb_acct_memory(h, -gbl_reserve);
+ if (map_chg) {
+ long gbl_resv_put = hugepage_subpool_put_pages(spool, 1);
+
+ hugetlb_acct_memory(h, gbl_resv_get - gbl_resv_put);
}
out_end_reservation:
--
2.55.0.1082.g2b9226bbc0-goog
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 4/4] mm: hugetlb: Avoid re-allocating global reservations on region add failure
2026-09-16 23:39 [PATCH v3 0/4] Fix HugeTLB subpool used_hpages tracking Ackerley Tng via B4 Relay
` (2 preceding siblings ...)
2026-09-16 23:39 ` [PATCH v3 3/4] mm: hugetlb: Fix subpool usage leak on allocation failure Ackerley Tng via B4 Relay
@ 2026-09-16 23:39 ` Ackerley Tng via B4 Relay
2026-09-17 3:13 ` [PATCH v3 0/4] Fix HugeTLB subpool used_hpages tracking Andrew Morton
4 siblings, 0 replies; 6+ messages in thread
From: Ackerley Tng via B4 Relay @ 2026-09-16 23:39 UTC (permalink / raw)
To: Alex Shi, Andrew Morton, David Hildenbrand, Dongliang Mu,
Hongxiang Lou, Johannes Weiner, Jonathan Corbet, Joshua Hahn,
Liam R. Howlett, Lorenzo Stoakes, Miaohe Lin, Michal Hocko,
Mike Rapoport, Muchun Song, Nhat Pham, Oscar Salvador, Peter Xu,
Randy Dunlap, Roman Gushchin, Shakeel Butt, Shuah Khan,
Suren Baghdasaryan, Usama Arif, Vlastimil Babka, Wupeng Ma,
Yanteng Si, Naoya Horiguchi, fvdl, jthoughton, rientjes,
vannapurve
Cc: linux-doc, linux-kernel, linux-mm, Ackerley Tng, stable
From: Ackerley Tng <ackerleytng@google.com>
When reserving huge pages for a shared mapping, reservations are first
requested from the subpool, and any remainder is accounted in global
reservations. When adding the file region entries fails later in the
process, the reservation attempt must be rolled back.
Previously, this error path explicitly dropped the global reservations
that were just acquired before jumping to the cleanup label. The cleanup
label then returned the pages to the subpool. If concurrent activity in
the subpool allowed the subpool to absorb more reservations upon return
than it supplied initially, the cleanup label calculated a positive
difference and attempted to allocate new global reservations from scratch.
This premature release was completely unnecessary because all requested
pages were already backed globally: partly by the mount guarantee and
partly by the global reservations just acquired. Prematurely dissolving
those reservations forced the cleanup path to attempt fresh buddy
allocations that could fail under memory pressure.
Instead, track the number of global reservations actually accounted so
far. In the cleanup label, subtract the already-accounted amount from the
difference between requested and returned reservations. This ensures
that when global reservations were already acquired, the adjustment is
purely non-positive, dropping excess reservations without ever attempting
fresh allocations.
Signed-off-by: Ackerley Tng <ackerleytng@google.com>
Cc: stable@vger.kernel.org
---
mm/hugetlb.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 6589b188cf657..ee1ba9ded0ec7 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -6678,6 +6678,7 @@ long hugetlb_reserve_pages(struct inode *inode,
struct hugepage_subpool *spool = subpool_inode(inode);
struct resv_map *resv_map;
struct hugetlb_cgroup *h_cg = NULL;
+ long gbl_resv_accounted = 0;
long regions_needed = 0;
long gbl_resv_get;
long gbl_resv_put;
@@ -6768,6 +6769,7 @@ long hugetlb_reserve_pages(struct inode *inode,
err = hugetlb_acct_memory(h, gbl_resv_get);
if (err < 0)
goto out_put_pages;
+ gbl_resv_accounted = gbl_resv_get;
/*
* Account for the reservations made. Shared mappings record regions
@@ -6784,7 +6786,6 @@ long hugetlb_reserve_pages(struct inode *inode,
add = region_add(resv_map, from, to, regions_needed, h, h_cg);
if (unlikely(add < 0)) {
- hugetlb_acct_memory(h, -gbl_resv_get);
err = add;
goto out_put_pages;
} else if (unlikely(chg > add)) {
@@ -6826,9 +6827,10 @@ long hugetlb_reserve_pages(struct inode *inode,
* There may be a difference between the number of
* reservations to consume and the number to restore now if
* there are multiple threads interacting with the subpool -
- * restore the difference.
+ * restore the difference, taking into account any global
+ * reservations already acquired.
*/
- hugetlb_acct_memory(h, gbl_resv_get - gbl_resv_put);
+ hugetlb_acct_memory(h, gbl_resv_get - gbl_resv_put - gbl_resv_accounted);
out_uncharge_cgroup:
hugetlb_cgroup_uncharge_cgroup_rsvd(hstate_index(h),
--
2.55.0.1082.g2b9226bbc0-goog
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 0/4] Fix HugeTLB subpool used_hpages tracking
2026-09-16 23:39 [PATCH v3 0/4] Fix HugeTLB subpool used_hpages tracking Ackerley Tng via B4 Relay
` (3 preceding siblings ...)
2026-09-16 23:39 ` [PATCH v3 4/4] mm: hugetlb: Avoid re-allocating global reservations on region add failure Ackerley Tng via B4 Relay
@ 2026-09-17 3:13 ` Andrew Morton
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2026-09-17 3:13 UTC (permalink / raw)
To: ackerleytng
Cc: Ackerley Tng via B4 Relay, Alex Shi, David Hildenbrand,
Dongliang Mu, Hongxiang Lou, Johannes Weiner, Jonathan Corbet,
Joshua Hahn, Liam R. Howlett, Lorenzo Stoakes, Miaohe Lin,
Michal Hocko, Mike Rapoport, Muchun Song, Nhat Pham,
Oscar Salvador, Peter Xu, Randy Dunlap, Roman Gushchin,
Shakeel Butt, Shuah Khan, Suren Baghdasaryan, Usama Arif,
Vlastimil Babka, Wupeng Ma, Yanteng Si, Naoya Horiguchi, fvdl,
jthoughton, rientjes, vannapurve, linux-doc, linux-kernel,
linux-mm, stable
On Wed, 16 Sep 2026 16:39:00 -0700 Ackerley Tng via B4 Relay <devnull+ackerleytng.google.com@kernel.org> wrote:
> HugeTLB subpools currently only track used pages (used_hpages) when a
> maximum size limit (max_hpages) is configured on the mount.
>
> ...
>
> This series addresses three problem areas resulting from untracked usage
> and asymmetric error handling:
These are rather serious-sounding problems.
I'm seeing Fixes: for 10-year-old patches, for one last year and one
this year. The fourth patch doesn't identify what to fix.
So if downstream people (-stable maintainers, others) follow our
recommendations, some kernels will get two of these patches, other
kernel versions will get three and some lucky kernels might get all
four. Are you confident that the patches can be split apart in this
fashion and still produce a good result? After all, we're sending
downstream some patch combinations which we didn't test.
Also, can you speculate about why these things took so long to
discover?
Ho hum, complicated. Let's at least slap a Fixes: on [4/4]. My
trillion-dollar sidekick suggests a9e443086489 ("hugetlb: disable
region_add file_region coalescing").
Our other little friend is talking to us:
https://sashiko.dev/#/patchset/20260916-hugetlb-subpool-always-track-used-v3-0-38aae9b5ccdd@google.com
I'd like to queue this up promptly because it fixes things. But let's
seek additional review input and argue with Sashiko before taking that
step.
^ permalink raw reply [flat|nested] 6+ messages in thread