From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
John Stultz <jstultz@google.com>, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Christian Loehle <christian.loehle@arm.com>,
David Dai <david.dai@linux.dev>, Emil Tsalapatis <etsal@meta.com>,
Lee Trager <ltrager@nvidia.com>,
Richard Cheng <icheng@nvidia.com>, Koba Ko <kobak@nvidia.com>,
Aiqun Yu <aiqun.yu@oss.qualcomm.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/18] sched: Add sched_ext hooks for proxy execution
Date: Thu, 17 Sep 2026 12:35:07 +0200 [thread overview]
Message-ID: <20260917103507.GJ776954@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <aqq7Si1D3P2et_gw@gpd4>
On Wed, Sep 16, 2026 at 05:52:42PM +0200, Andrea Righi wrote:
> > In this case, ->donor is visible to ext and all is well, but ->curr is
> > not so easy.
> >
> > I'm still a little confused though, why not leave blocked tasks on this
> > reject queue. If they're needed, the proxy mechanism will move them
> > around. They won't actually ever run except through proxy.
> >
> > The point where they will become runnable again, is through wakeup. So
> > why not delay everything until that point?
> >
> > Or am I not understanding ext again?
>
> I think the missing detail is that the task rejected by the remote DSQ transfer
> isn't necessarily blocked.
>
> Consider a blocked donor D proxy-executing a runnable EXT mutex owner
> O on CPU0. O is rq->curr and D is rq->donor. Since O is executing
> using D's scheduling context, O's own EXT scheduling entity may still
> be on a non-local DSQ.
>
> CPU1 could concurrently consume O from that non-local DSQ and start
> transferring it to CPU1. After dropping the DSQ lock and acquiring O's
> source rq lock, it discovers that O has become rq->curr on CPU0 and
> therefore can't be migrated. O is then parked on CPU0's reject DSQ.
>
> When proxy exec switches away from O, O stops being rq->curr but
> remains runnable. There's no wakeup in this case, because O never
> blocked. If it remains on the reject DSQ, it's no longer visible to
> the BPF scheduler and can't subsequently run using its own scheduling
> context.
Argh, right! I got D and O switched around :-/
> The rq->donor case has a similar issue even though that task is
> blocked: a blocked donor can stop being the active donor before the
> mutex wakes it (for example, if another scheduling context is
> selected). The proxy exec mechanism follows the owner chain after the
> donor has been selected, it doesn't select tasks from the internal
> reject DSQ. Leaving the donor there until wakeup would prevent it from
> being selected again for proxy execution in the meantime.
Ah, but rq->donor gets a put_prev_task() to sort it out. While there is
no such things for rq->curr.
> This is why the retry is tied to another proxy selection point, once
> the task is no longer rq->curr or rq->donor, it can be re-enqueued to
> through its BPF scheduler.
Fair enough.
next prev parent reply other threads:[~2026-09-17 10:35 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 13:42 [PATCHSET v13 sched_ext/for-7.4] sched: Make proxy execution compatible with sched_ext Andrea Righi
2026-08-31 13:42 ` [PATCH 01/18] sched/core: Drop mutex locks before proxy rescheduling Andrea Righi
2026-08-31 13:42 ` [PATCH 02/18] sched/core: Dequeue waking proxy donors before reset Andrea Righi
2026-09-01 5:24 ` K Prateek Nayak
2026-09-08 9:28 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 03/18] sched: Make NOHZ CFS bandwidth checks follow proxy donor Andrea Righi
2026-09-10 9:54 ` Peter Zijlstra
2026-09-15 15:59 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 04/18] sched/core: Avoid false migration warning for proxy donors Andrea Righi
2026-09-10 10:06 ` Peter Zijlstra
2026-09-15 16:05 ` Andrea Righi
2026-09-15 17:20 ` Andrea Righi
2026-09-15 17:24 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 05/18] sched: Pass next class to sched_change_begin() Andrea Righi
2026-09-10 10:12 ` Peter Zijlstra
2026-09-15 19:31 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 06/18] sched: Add helper to block retained proxy donors Andrea Righi
2026-08-31 13:42 ` [PATCH 07/18] sched: Add sched_ext hooks for proxy execution Andrea Righi
2026-09-10 10:38 ` Peter Zijlstra
2026-09-15 20:30 ` Andrea Righi
2026-09-16 9:00 ` Peter Zijlstra
2026-09-16 15:52 ` Andrea Righi
2026-09-17 10:35 ` Peter Zijlstra [this message]
2026-08-31 13:42 ` [PATCH 08/18] sched: Introduce WF_ON_RQ wake flag Andrea Righi
2026-09-10 10:45 ` Peter Zijlstra
2026-09-15 20:55 ` Andrea Righi
2026-09-15 21:14 ` John Stultz
2026-09-16 9:19 ` Peter Zijlstra
2026-09-16 10:27 ` K Prateek Nayak
2026-09-16 10:30 ` Peter Zijlstra
2026-09-16 10:38 ` K Prateek Nayak
2026-09-16 10:41 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 09/18] sched_ext: Block proxy donors across scheduler transitions Andrea Righi
2026-09-10 10:53 ` Peter Zijlstra
2026-09-10 11:41 ` Peter Zijlstra
2026-09-15 21:40 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 10/18] sched_ext: Fix ops.running/stopping() pairing for proxy-exec donors Andrea Righi
2026-08-31 13:42 ` [PATCH 11/18] sched_ext: Move reject DSQ draining into core Andrea Righi
2026-08-31 13:42 ` [PATCH 12/18] sched_ext: Generalize the reject DSQ reenqueue path Andrea Righi
2026-09-03 22:39 ` Tejun Heo
2026-09-08 9:34 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 13/18] sched_ext: Handle proxy-exec races in remote DSQ transfers Andrea Righi
2026-08-31 13:42 ` [PATCH 14/18] sched_ext: Split curr|donor references properly Andrea Righi
2026-09-10 11:47 ` Peter Zijlstra
2026-09-16 6:44 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 15/18] sched_ext: Delegate proxy donor admission to BPF schedulers Andrea Righi
2026-09-10 13:39 ` Peter Zijlstra
2026-09-16 6:51 ` Andrea Righi
2026-09-10 13:41 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 16/18] sched_ext: Add selftest for blocked donor admission Andrea Righi
2026-08-31 13:42 ` [PATCH 17/18] sched_ext: scx_qmap: Add proxy execution support Andrea Righi
2026-09-01 7:52 ` Richard Cheng
2026-09-08 9:42 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 18/18] sched: Allow enabling proxy exec with sched_ext Andrea Righi
2026-09-03 22:51 ` [PATCHSET v13 sched_ext/for-7.4] sched: Make proxy execution compatible " Tejun Heo
2026-09-08 8:02 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917103507.GJ776954@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=christian.loehle@arm.com \
--cc=david.dai@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=etsal@meta.com \
--cc=icheng@nvidia.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kobak@nvidia.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltrager@nvidia.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®