* [PATCH] [v2] ASoC: rt766: fix HID dependency for SND_SOC_SDCA_HID
@ 2026-09-17 13:58 Arnd Bergmann
2026-09-17 19:25 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2026-09-17 13:58 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Shuming Fan, Charles Keepax
Cc: Arnd Bergmann, Richard Fitzgerald, Srinivas Kandagatla,
linux-sound, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Selecting SND_SOC_SDCA_HID only works if HID is enabled:
WARNING: unmet direct dependencies detected for SND_SOC_SDCA_HID
Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_SOC_SDCA [=y] && (HID [=n]=y [=y] || HID [=n]=SND_SOC_SDCA [=y])
Selected by [y]:
- SND_SOC_RT766_SDCA_SDW [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && SOUNDWIRE [=y] && SND_SOC_SDCA [=y]
Change the dependency to require SND_SOC_SDCA_CLASS instead, which
solves the problem without extra selects.
Fixes: b50ecf5873df ("ASoC: rt766: add RT766/RT767 SDCA driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: replace the original approach that added a still insufficient dependency.
---
sound/soc/codecs/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index e78d725e61e2..f88381523ea3 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1991,9 +1991,7 @@ config SND_SOC_RT715_SDCA_SDW
config SND_SOC_RT766_SDCA_SDW
tristate "Realtek RT766 SDCA Codec - SDW"
depends on SOUNDWIRE
- depends on SND_SOC_SDCA
- select SND_SOC_SDCA_HID
- select SND_SOC_SDCA_IRQ
+ depends on SND_SOC_SDCA_CLASS
select REGMAP_SOUNDWIRE
select REGMAP_SOUNDWIRE_MBQ
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] [v2] ASoC: rt766: fix HID dependency for SND_SOC_SDCA_HID
2026-09-17 13:58 [PATCH] [v2] ASoC: rt766: fix HID dependency for SND_SOC_SDCA_HID Arnd Bergmann
@ 2026-09-17 19:25 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-09-17 19:25 UTC (permalink / raw)
To: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Shuming Fan,
Charles Keepax, Arnd Bergmann
Cc: Arnd Bergmann, Richard Fitzgerald, Srinivas Kandagatla,
linux-sound, linux-kernel
On Thu, 17 Sep 2026 15:58:51 +0200, Arnd Bergmann wrote:
> ASoC: rt766: fix HID dependency for SND_SOC_SDCA_HID
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3
Thanks!
[1/1] ASoC: rt766: fix HID dependency for SND_SOC_SDCA_HID
https://git.kernel.org/broonie/sound/c/8d78e4f906cf
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-18 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 13:58 [PATCH] [v2] ASoC: rt766: fix HID dependency for SND_SOC_SDCA_HID Arnd Bergmann
2026-09-17 19:25 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®