* [PATCH] mtd: Call get_wunit() on the master partition
@ 2026-09-17 14:53 Richard Weinberger (sigma star gmbh)
2026-09-17 15:14 ` Miquel Raynal
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger (sigma star gmbh) @ 2026-09-17 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-mtd, vigneshr, miquel.raynal, Richard Weinberger
From: Richard Weinberger <richard@nod.at>
The code checks whether master has get_wunit() but still calls
it on the child. Fix this.
Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/mtdcore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 16629382a787..82b1e6392b16 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -563,7 +563,7 @@ int mtd_pairing_info_to_wunit(struct mtd_info *mtd,
return -EINVAL;
if (master->pairing && master->pairing->get_wunit)
- return mtd->pairing->get_wunit(master, info);
+ return master->pairing->get_wunit(master, info);
return info->pair;
}
--
2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: Call get_wunit() on the master partition
2026-09-17 14:53 [PATCH] mtd: Call get_wunit() on the master partition Richard Weinberger (sigma star gmbh)
@ 2026-09-17 15:14 ` Miquel Raynal
2026-09-17 15:15 ` AW: " Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Miquel Raynal @ 2026-09-17 15:14 UTC (permalink / raw)
To: Richard Weinberger (sigma star gmbh)
Cc: linux-kernel, linux-mtd, vigneshr, Richard Weinberger
On 17/09/2026 at 16:53:29 +02, "Richard Weinberger (sigma star gmbh)" <rw@kernel.org> wrote:
> From: Richard Weinberger <richard@nod.at>
>
> The code checks whether master has get_wunit() but still calls
> it on the child. Fix this.
Ha :-)
Shouldn't we add Cc: stable?
> Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
> Signed-off-by: Richard Weinberger <richard@nod.at>
Otherwise lgtm!
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
* AW: [PATCH] mtd: Call get_wunit() on the master partition
2026-09-17 15:14 ` Miquel Raynal
@ 2026-09-17 15:15 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2026-09-17 15:15 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger (sigma star gmbh)
Cc: linux-kernel, linux-mtd, vigneshr
Am Thu, Sep 17, 2026, 17:14 schrieb Miquel Raynal <miquel.raynal@bootlin.com>:
> On 17/09/2026 at 16:53:29 +02, "Richard Weinberger (sigma star gmbh)" <rw@kernel.org> wrote:
>
> > From: Richard Weinberger <richard@nod.at>
> >
> > The code checks whether master has get_wunit() but still calls
> > it on the child. Fix this.
>
> Ha :-)
>
> Shouldn't we add Cc: stable?
Fine by me.
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-17 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 14:53 [PATCH] mtd: Call get_wunit() on the master partition Richard Weinberger (sigma star gmbh)
2026-09-17 15:14 ` Miquel Raynal
2026-09-17 15:15 ` AW: " Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®