mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: linux-mm@kvack.org, Baoquan He <bhe@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, Dev Jain <dev.jain@arm.com>,
	lirongqing <lirongqing@baidu.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RESEND] mm/vmalloc: Use dedicated unbound workqueues for vmap drain
Date: Fri, 18 Sep 2026 07:24:05 +0800	[thread overview]
Message-ID: <20260917232406.148-1-hdanton@sina.com> (raw)
In-Reply-To: <aqwdc7Oh24b_bxOQ@milan>

On Thu, 17 Sep 2026 19:03:47 +0200 "Uladzislau Rezki (Sony)" wrote:
> On Thu, Sep 17, 2026 at 08:07:37AM +0800, Hillf Danton wrote:
> > 
> > Given numa node1 including cpu8-15 without cpu hotplug cared, a bound worker
> > for cpu9 can not migrate to any other cpu, while a unbound worker can run on
> > any cpu of node1, that is all.
> > 
> Right. 
> 
> <snip>
> 	if (list_empty(&pwq->inactive_works) && pwq_tryinc_nr_active(pwq, false)) {
> 		if (list_empty(&pool->worklist))
> 			pool->last_progress_ts = jiffies;
> 
> 		trace_workqueue_activate_work(work);
> 		insert_work(pwq, work, &pool->worklist, work_flags);
> 		kick_pool_pick(pool, &wake_task);
> 	} else {
> 		work_flags |= WORK_STRUCT_INACTIVE;
> 		insert_work(pwq, work, &pwq->inactive_works, work_flags);
> 	}
> 
> out:
> 	raw_spin_unlock(&pool->lock);
> 	if (wake_task)
> 		wake_up_process(wake_task);
> <snip>
> 
> wake_up_process(wake_task) - this guy takes care about task placement.
> For us it is TASK_FAIR thus select_task_rq_fair() decides the fate of
> unbound kworker.
>
At best an idle cpu is selected for the unbound worker, but it may be
preempted the next micro second. Maybe you disagree, eevdf means uncertain.

Even given an idle cpu without preempt, it fails to prevent the vmap
work from becoming a wart, no?

  reply	other threads:[~2026-09-17 23:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05 15:27 Uladzislau Rezki (Sony)
2026-09-05 22:37 ` Andrew Morton
2026-09-08 14:23   ` Uladzislau Rezki
2026-09-06  3:50 ` Hillf Danton
2026-09-08 14:21   ` Uladzislau Rezki
2026-09-09  1:08     ` Hillf Danton
2026-09-14 16:56       ` Uladzislau Rezki
2026-09-16  0:12         ` Hillf Danton
2026-09-16 16:00           ` Uladzislau Rezki
2026-09-17  0:07             ` Hillf Danton
2026-09-17 17:03               ` Uladzislau Rezki
2026-09-17 23:24                 ` Hillf Danton [this message]
2026-09-10  8:33 ` Ye Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917232406.148-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lirongqing@baidu.com \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®