* [PATCH] octeontx2-af: remove duplicate SCTP port flags
@ 2026-09-18 6:03 Aryan Sinha
[not found] ` <CAN_7xUoyoCoq9G41A04owA2JJbHARn==NueTxB3i=LjCRymOSQ@mail.gmail.com>
2026-09-18 6:25 ` Ratheesh Kannoth
0 siblings, 2 replies; 4+ messages in thread
From: Aryan Sinha @ 2026-09-18 6:03 UTC (permalink / raw)
To: Sunil Goutham, Ratheesh Kannoth, Geetha sowjanya, Subbaraya Sundeep
Cc: Andrew Lunn, davem, edumazet, kuba, pabeni, netdev, linux-kernel,
Aryan Sinha
proto_flags ORs BIT_ULL(NPC_SPORT_SCTP) and BIT_ULL(NPC_DPORT_SCTP)
are present twice. Both fields are already covered by the first pair, so the second
one has no effect.
Drop it. No functional change.
Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
index d422bdd5e..ec004ea51 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
@@ -698,7 +698,6 @@ static void npc_set_features(struct rvu *rvu, int blkaddr, u8 intf)
proto_flags = BIT_ULL(NPC_SPORT_TCP) | BIT_ULL(NPC_SPORT_UDP) |
BIT_ULL(NPC_DPORT_TCP) | BIT_ULL(NPC_DPORT_UDP) |
BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP) |
- BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP) |
BIT_ULL(NPC_TYPE_ICMP) | BIT_ULL(NPC_CODE_ICMP) |
BIT_ULL(NPC_TCP_FLAGS);
--
2.46.0
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <CAN_7xUoyoCoq9G41A04owA2JJbHARn==NueTxB3i=LjCRymOSQ@mail.gmail.com>]
* RE: [EXTERNAL] Re: [PATCH] octeontx2-af: remove duplicate SCTP port flags
[not found] ` <CAN_7xUoyoCoq9G41A04owA2JJbHARn==NueTxB3i=LjCRymOSQ@mail.gmail.com>
@ 2026-09-18 6:14 ` Geethasowjanya Akula
0 siblings, 0 replies; 4+ messages in thread
From: Geethasowjanya Akula @ 2026-09-18 6:14 UTC (permalink / raw)
To: TechyMinati, Sunil Kovvuri Goutham, Ratheesh Kannoth,
Subbaraya Sundeep Bhatta
Cc: Andrew Lunn, davem, edumazet, kuba, pabeni, netdev, linux-kernel
>-----Original Message-----
>From: TechyMinati <sinha.aryan03@gmail.com>
>Sent: Friday, September 18, 2026 11:36 AM
>To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Ratheesh Kannoth
><rkannoth@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>;
>Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
>Cc: Andrew Lunn <andrew+netdev@lunn.ch>; davem@davemloft.net;
>edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
>netdev@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: [EXTERNAL] Re: [PATCH] octeontx2-af: remove duplicate SCTP port
>flags
>
>This targets net-next. Sorry for the missing subject tag.
>
>On Fri, Sep 18, 2026 at 11:33 AM Aryan Sinha <sinha.aryan03@gmail.com
><mailto:sinha.aryan03@gmail.com> > wrote:
>
>
> proto_flags ORs BIT_ULL(NPC_SPORT_SCTP) and
>BIT_ULL(NPC_DPORT_SCTP)
> are present twice. Both fields are already covered by the first pair, so
>the second
> one has no effect.
>
> Drop it. No functional change.
>
> Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com
><mailto:sinha.aryan03@gmail.com> >
> ---
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
>b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> index d422bdd5e..ec004ea51 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> @@ -698,7 +698,6 @@ static void npc_set_features(struct rvu *rvu, int
>blkaddr, u8 intf)
> proto_flags = BIT_ULL(NPC_SPORT_TCP) |
>BIT_ULL(NPC_SPORT_UDP) |
> BIT_ULL(NPC_DPORT_TCP) | BIT_ULL(NPC_DPORT_UDP) |
> BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP)
>|
> - BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP)
>|
> BIT_ULL(NPC_TYPE_ICMP) | BIT_ULL(NPC_CODE_ICMP) |
> BIT_ULL(NPC_TCP_FLAGS);
>
> --
> 2.46.0
>
>
Reviewed-by: Geetha sowjanya <gakula@marvell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] octeontx2-af: remove duplicate SCTP port flags
2026-09-18 6:03 [PATCH] octeontx2-af: remove duplicate SCTP port flags Aryan Sinha
[not found] ` <CAN_7xUoyoCoq9G41A04owA2JJbHARn==NueTxB3i=LjCRymOSQ@mail.gmail.com>
@ 2026-09-18 6:25 ` Ratheesh Kannoth
2026-09-18 22:15 ` Jakub Kicinski
1 sibling, 1 reply; 4+ messages in thread
From: Ratheesh Kannoth @ 2026-09-18 6:25 UTC (permalink / raw)
To: Aryan Sinha
Cc: Sunil Goutham, Geetha sowjanya, Subbaraya Sundeep, Andrew Lunn,
davem, edumazet, kuba, pabeni, netdev, linux-kernel
On 2026-09-18 at 11:33:19, Aryan Sinha (sinha.aryan03@gmail.com) wrote:
> proto_flags ORs BIT_ULL(NPC_SPORT_SCTP) and BIT_ULL(NPC_DPORT_SCTP)
> are present twice. Both fields are already covered by the first pair, so the second
> one has no effect.
>
> Drop it. No functional change.
>
> Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
Isn't this a fix? Please include the appropriate Fixes tag:
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] octeontx2-af: remove duplicate SCTP port flags
2026-09-18 6:25 ` Ratheesh Kannoth
@ 2026-09-18 22:15 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2026-09-18 22:15 UTC (permalink / raw)
To: Ratheesh Kannoth
Cc: Aryan Sinha, Sunil Goutham, Geetha sowjanya, Subbaraya Sundeep,
Andrew Lunn, davem, edumazet, pabeni, netdev, linux-kernel
On Fri, 18 Sep 2026 11:55:08 +0530 Ratheesh Kannoth wrote:
> On 2026-09-18 at 11:33:19, Aryan Sinha (sinha.aryan03@gmail.com) wrote:
> > proto_flags ORs BIT_ULL(NPC_SPORT_SCTP) and BIT_ULL(NPC_DPORT_SCTP)
> > are present twice. Both fields are already covered by the first pair, so the second
> > one has no effect.
> >
> > Drop it. No functional change.
> >
> > Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
> Isn't this a fix? Please include the appropriate Fixes tag:
The patch has no functional change, how could it be a fix?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-18 22:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-18 6:03 [PATCH] octeontx2-af: remove duplicate SCTP port flags Aryan Sinha
[not found] ` <CAN_7xUoyoCoq9G41A04owA2JJbHARn==NueTxB3i=LjCRymOSQ@mail.gmail.com>
2026-09-18 6:14 ` [EXTERNAL] " Geethasowjanya Akula
2026-09-18 6:25 ` Ratheesh Kannoth
2026-09-18 22:15 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®