* [PATCH] dmaengine: dw-axi-dmac: demote apb_regs warning to debug
@ 2026-09-18 10:14 Baineng Shou
2026-09-18 14:04 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: Baineng Shou @ 2026-09-18 10:14 UTC (permalink / raw)
To: Eugeniy.Paltsev, vkoul; +Cc: Frank.Li, dmaengine, linux-kernel, Baineng Shou
dw_axi_dma_set_hw_channel() logs "apb_regs not initialized" at err
level when apb_regs is absent. However, only Intel KeemBay
("intel,kmb-axi-dma") carries apb_regs; all other supported SoCs
(snps,axi-dma-1.01a, sophgo,cv1800b, starfive,jh7110/jh8100) operate
without it. For those, reaching this path during slave/cyclic prep and
terminate is the normal no-op case, not an error, and the err log spams
dmesg on every transfer.
Demote it to dev_dbg to match the identical check in
dw_axi_dma_set_byte_halfword().
Signed-off-by: Baineng Shou <shoubaineng@gmail.com>
---
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index bcefaff03b5c..d829b9af5491 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -574,7 +574,7 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set)
unsigned long reg_value, val;
if (!chip->apb_regs) {
- dev_err(chip->dev, "apb_regs not initialized\n");
+ dev_dbg(chip->dev, "apb_regs not initialized\n");
return;
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: dw-axi-dmac: demote apb_regs warning to debug
2026-09-18 10:14 [PATCH] dmaengine: dw-axi-dmac: demote apb_regs warning to debug Baineng Shou
@ 2026-09-18 14:04 ` Frank Li
0 siblings, 0 replies; 3+ messages in thread
From: Frank Li @ 2026-09-18 14:04 UTC (permalink / raw)
To: Baineng Shou; +Cc: Eugeniy.Paltsev, vkoul, Frank.Li, dmaengine, linux-kernel
On Fri, Sep 18, 2026 at 06:14:14PM +0800, Baineng Shou wrote:
> dw_axi_dma_set_hw_channel() logs "apb_regs not initialized" at err
> level when apb_regs is absent. However, only Intel KeemBay
> ("intel,kmb-axi-dma") carries apb_regs; all other supported SoCs
> (snps,axi-dma-1.01a, sophgo,cv1800b, starfive,jh7110/jh8100) operate
> without it. For those, reaching this path during slave/cyclic prep and
> terminate is the normal no-op case, not an error, and the err log spams
> dmesg on every transfer.
>
> Demote it to dev_dbg to match the identical check in
> dw_axi_dma_set_byte_halfword().
>
> Signed-off-by: Baineng Shou <shoubaineng@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index bcefaff03b5c..d829b9af5491 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -574,7 +574,7 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set)
> unsigned long reg_value, val;
>
> if (!chip->apb_regs) {
> - dev_err(chip->dev, "apb_regs not initialized\n");
> + dev_dbg(chip->dev, "apb_regs not initialized\n");
> return;
> }
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] dmaengine: dw-axi-dmac: demote apb_regs warning to debug
@ 2026-09-10 8:09 Baineng Shou
0 siblings, 0 replies; 3+ messages in thread
From: Baineng Shou @ 2026-09-10 8:09 UTC (permalink / raw)
To: Eugeniy.Paltsev, vkoul; +Cc: Frank.Li, dmaengine, linux-kernel, Baineng Shou
dw_axi_dma_set_hw_channel() logs "apb_regs not initialized" at err
level when apb_regs is absent. However, only Intel KeemBay
("intel,kmb-axi-dma") carries apb_regs; all other supported SoCs
(snps,axi-dma-1.01a, sophgo,cv1800b, starfive,jh7110/jh8100) operate
without it. For those, reaching this path during slave/cyclic prep and
terminate is the normal no-op case, not an error, and the err log spams
dmesg on every transfer.
Demote it to dev_dbg to match the identical check in
dw_axi_dma_set_byte_halfword().
Signed-off-by: Baineng Shou <shoubaineng@gmail.com>
---
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index bcefaff03b5c..d829b9af5491 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -574,7 +574,7 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set)
unsigned long reg_value, val;
if (!chip->apb_regs) {
- dev_err(chip->dev, "apb_regs not initialized\n");
+ dev_dbg(chip->dev, "apb_regs not initialized\n");
return;
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-18 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-18 10:14 [PATCH] dmaengine: dw-axi-dmac: demote apb_regs warning to debug Baineng Shou
2026-09-18 14:04 ` Frank Li
-- strict thread matches above, loose matches on Subject: below --
2026-09-10 8:09 Baineng Shou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®