From: Andreas Kemnade <andreas@kemnade.info>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bhargav Joshi <j.bhargav.u@gmail.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Animesh Agarwal <animeshagarwal28@gmail.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: crypto: ti,omap4-des: Remove redundant clock properties
Date: Fri, 18 Sep 2026 14:29:33 +0200 [thread overview]
Message-ID: <20260918142933.2f28d31c@kemnade.info> (raw)
In-Reply-To: <20260918-jolly-honeybee-of-improvement-601ad0@quoll>
On Fri, 18 Sep 2026 10:46:57 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Wed, Sep 16, 2026 at 02:29:38AM +0530, Bhargav Joshi wrote:
> > The omap-des driver doesn't use the clocks and clock-names properties
> > because clock management is entirely handled by the parent ti-sysc
> > wrapper. files omap5-l4.dtsi, omap4-l4.dtsi, am4372.dtsi doesn't use
> > these properties either.
>
First a simple idea about reasoning here. Start with the assumption that
Linux does not exist and there are random operating systems. using devicetree.
Try to justify your patch that way.
> This is not a correct reason alone to make a DT change and it is
> explicitly documented in writing bindings doc. If hardware has clocks,
> but driver does not use them, they must be documented.
>
This is a lot about how to define several things.
Hardware is described by splitting them into some power management part
(compatible "ti-sysc") as parent and the main part. Basic clocking is
described in that ti-sysc part.
But the situation is a bit different here. The clock to be removed is
different from the stuff in the ti-sysc part. So it needs indeed some more
arguing.
Regards,
Andreas
next prev parent reply other threads:[~2026-09-18 12:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 20:59 [PATCH v2 0/4] ARM: dts: ti: Clean up OMAP crypto bindings and dt Bhargav Joshi
2026-09-15 20:59 ` [PATCH v2 1/4] dt-bindings: crypto: ti,omap4-des: Remove redundant clock properties Bhargav Joshi
2026-09-18 8:46 ` Krzysztof Kozlowski
2026-09-18 12:29 ` Andreas Kemnade [this message]
2026-09-15 20:59 ` [PATCH v2 2/4] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes Bhargav Joshi
2026-09-18 8:48 ` Krzysztof Kozlowski
2026-09-18 12:42 ` Andreas Kemnade
2026-09-18 20:47 ` Bhargav Joshi
2026-09-15 20:59 ` [PATCH v2 3/4] dt-bindings: crypto: ti,omap-sham: Add OMAP3 compatible and deprecate ti,hwmods Bhargav Joshi
2026-09-15 20:59 ` [PATCH v2 4/4] dt-bindings: crypto: ti,omap: Fix missing subdirectory in $id path Bhargav Joshi
2026-09-18 8:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918142933.2f28d31c@kemnade.info \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=animeshagarwal28@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=j.bhargav.u@gmail.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®