[PATCH v2 0/4] ARM: dts: ti: Clean up OMAP crypto bindings and dt

[PATCH v2 0/4] ARM: dts: ti: Clean up OMAP crypto bindings and dt

[Bhargav Joshi]

Patch 1 removes redundant properties clocks and clock-names from
omap4-des bindings.

Patch 2 removes redundant "clocks" and "clock-names" properties from the
DRA7 crypto dt nodes.

Patch 3 updates the ti,omap-sham YAML binding to add the missing
"ti,omap3-sham" compatible, deprecates "ti,hwmods" and removes it from
the required properties list.

Patch 4 Adds missing subdirectory in $id path for omap2-aes and omap4-des.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
Changes in v2:
- Add patch 1 that removes redundant properties from des.
- collect tag for patch 2
- Add patch 4 to add missing subdirectory in $id path.
- Link to v1: https://lore.kernel.org/r/20260911-ti-dra7-omap-sham-fix-v1-0-c430f01b4e13@gmail.com

---
Bhargav Joshi (4):
      dt-bindings: crypto: ti,omap4-des: Remove redundant clock properties
      ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes
      dt-bindings: crypto: ti,omap-sham: Add OMAP3 compatible and deprecate ti,hwmods
      dt-bindings: crypto: ti,omap: Fix missing subdirectory in $id path

 Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml |  3 ++-
 Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml |  2 +-
 Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml | 13 +------------
 arch/arm/boot/dts/ti/omap/dra7-l4.dtsi                     |  2 --
 arch/arm/boot/dts/ti/omap/dra7.dtsi                        |  8 --------
 5 files changed, 4 insertions(+), 24 deletions(-)
---
base-commit: 50d05c7c76c96b90462f24debacca971d2e86713
change-id: 20260911-ti-dra7-omap-sham-fix-388a067572b3

Best regards,
-- 
Bhargav

[PATCH v2 1/4] dt-bindings: crypto: ti,omap4-des: Remove redundant clock properties

[Bhargav Joshi]

The omap-des driver doesn't use the clocks and clock-names properties
because clock management is entirely handled by the parent ti-sysc
wrapper. files omap5-l4.dtsi, omap4-l4.dtsi, am4372.dtsi doesn't use
these properties either.

Remove these properties from the binding.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
 Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml b/Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml
index f02f1e141218..2ed6f77583d4 100644
--- a/Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml
@@ -31,13 +31,6 @@ properties:
       - const: tx
       - const: rx
 
-  clocks:
-    maxItems: 1
-
-  clock-names:
-    items:
-      - const: fck
-
 dependencies:
   dmas: [ dma-names ]
 
@@ -45,8 +38,6 @@ required:
   - compatible
   - reg
   - interrupts
-  - clocks
-  - clock-names
 
 additionalProperties: false
 
@@ -58,8 +49,6 @@ examples:
         compatible = "ti,omap4-des";
         reg = <0x480a5000 0xa0>;
         interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
-        clocks = <&l3_iclk_div>;
-        clock-names = "fck";
         dmas = <&sdma 117>, <&sdma 116>;
         dma-names = "tx", "rx";
     };

-- 
2.55.0

[PATCH v2 2/4] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

[Bhargav Joshi]

The omap-sham, omap4-des and omap2-aes crypto drivers do not use
"clocks" and "clock-names" properties. Clock management is handled by
the ti-sysc interconnect parent wrapper. The dt-bindings for
ti,omap-sham and ti,omap-aes don't define these clock properties. Having
them in the child nodes causes dtbs_check warnings.

Remove the "clocks" and "clock-names" properties from the sham, des and
aes nodes.

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
 arch/arm/boot/dts/ti/omap/dra7-l4.dtsi | 2 --
 arch/arm/boot/dts/ti/omap/dra7.dtsi    | 8 --------
 2 files changed, 10 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
index a595745afe59..bca035fd7e62 100644
--- a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
@@ -2086,8 +2086,6 @@ des: des@0 {
 				interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
 				dmas = <&sdma_xbar 117>, <&sdma_xbar 116>;
 				dma-names = "tx", "rx";
-				clocks = <&l3_iclk_div>;
-				clock-names = "fck";
 			};
 		};
 
diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi
index 711ce4c31bb1..0784c6d9cbe4 100644
--- a/arch/arm/boot/dts/ti/omap/dra7.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi
@@ -1012,8 +1012,6 @@ aes1: aes@0 {
 				interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
 				dmas = <&edma_xbar 111 0>, <&edma_xbar 110 0>;
 				dma-names = "tx", "rx";
-				clocks = <&l3_iclk_div>;
-				clock-names = "fck";
 			};
 		};
 
@@ -1043,8 +1041,6 @@ aes2: aes@0 {
 				interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
 				dmas = <&edma_xbar 114 0>, <&edma_xbar 113 0>;
 				dma-names = "tx", "rx";
-				clocks = <&l3_iclk_div>;
-				clock-names = "fck";
 			};
 		};
 
@@ -1073,8 +1069,6 @@ sham1: sham@0 {
 				interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;
 				dmas = <&edma_xbar 119 0>;
 				dma-names = "rx";
-				clocks = <&l3_iclk_div>;
-				clock-names = "fck";
 			};
 		};
 
@@ -1103,8 +1097,6 @@ sham2: sham@0 {
 				interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
 				dmas = <&edma_xbar 165 0>;
 				dma-names = "rx";
-				clocks = <&l3_iclk_div>;
-				clock-names = "fck";
 			};
 		};
 

-- 
2.55.0

[PATCH v2 3/4] dt-bindings: crypto: ti,omap-sham: Add OMAP3 compatible and deprecate ti,hwmods

[Bhargav Joshi]

The OMAP SHAM driver supports OMAP3 SoCs, and "ti,omap3-sham" is
actively used in existing dts. However, it was previously missing from
binding. Add "ti,omap3-sham" to the list of valid compatibles.

The legacy "ti,hwmods" property is no longer needed as TI OMAP mirgrated
to "ti-sysc". Mark it as deprecated and remove it from the required
properties.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
 Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml b/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
index d69b50228009..3ef05890e13a 100644
--- a/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
@@ -13,6 +13,7 @@ properties:
   compatible:
     enum:
       - ti,omap2-sham
+      - ti,omap3-sham
       - ti,omap4-sham
       - ti,omap5-sham
 
@@ -32,6 +33,7 @@ properties:
     description: Name of the hwmod associated with the SHAM module
     $ref: /schemas/types.yaml#/definitions/string
     enum: [sham]
+    deprecated: true
 
 dependencies:
   dmas: [dma-names]
@@ -40,7 +42,6 @@ additionalProperties: false
 
 required:
   - compatible
-  - ti,hwmods
   - reg
   - interrupts
 

-- 
2.55.0

[PATCH v2 4/4] dt-bindings: crypto: ti,omap: Fix missing subdirectory in $id path

[Bhargav Joshi]

The $id fields in the omap2-aes and omap4-des schemas are missing the
crypto/ subdirectory in their paths.

Add the missing crypto/ to $id.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
 Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml | 2 +-
 Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml b/Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml
index 90e92050ad2e..54e1d6c9bfdf 100644
--- a/Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/ti,omap2-aes.yaml#
+$id: http://devicetree.org/schemas/crypto/ti,omap2-aes.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: OMAP SoC AES crypto Module
diff --git a/Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml b/Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml
index 2ed6f77583d4..3e7eed297c81 100644
--- a/Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/ti,omap4-des.yaml#
+$id: http://devicetree.org/schemas/crypto/ti,omap4-des.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: OMAP4 DES crypto Module

-- 
2.55.0

Re: [PATCH v2 1/4] dt-bindings: crypto: ti,omap4-des: Remove redundant clock properties

[Krzysztof Kozlowski]

On Wed, Sep 16, 2026 at 02:29:38AM +0530, Bhargav Joshi wrote:
> The omap-des driver doesn't use the clocks and clock-names properties
> because clock management is entirely handled by the parent ti-sysc
> wrapper. files omap5-l4.dtsi, omap4-l4.dtsi, am4372.dtsi doesn't use
> these properties either.

This is not a correct reason alone to make a DT change and it is
explicitly documented in writing bindings doc. If hardware has clocks,
but driver does not use them, they must be documented.

Explain the hardware. You can mention the driver as an argument proving
only lack of ABI impact, but not reason to make a change.

Best regards,
Krzysztof

Re: [PATCH v2 2/4] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

[Krzysztof Kozlowski]

On Wed, Sep 16, 2026 at 02:29:39AM +0530, Bhargav Joshi wrote:
> The omap-sham, omap4-des and omap2-aes crypto drivers do not use
> "clocks" and "clock-names" properties. Clock management is handled by
> the ti-sysc interconnect parent wrapper. The dt-bindings for
> ti,omap-sham and ti,omap-aes don't define these clock properties. Having
> them in the child nodes causes dtbs_check warnings.

This is not true. First you removed it from the DES binding and then you
claim it causes dtbs_check warnings.

Order your commits properly and then see if there are warnings.

Best regards,
Krzysztof

Re: [PATCH v2 4/4] dt-bindings: crypto: ti,omap: Fix missing subdirectory in $id path

[Krzysztof Kozlowski]

On Wed, Sep 16, 2026 at 02:29:41AM +0530, Bhargav Joshi wrote:
> The $id fields in the omap2-aes and omap4-des schemas are missing the
> crypto/ subdirectory in their paths.
> 
> Add the missing crypto/ to $id.
> 
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> ---
>  Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml | 2 +-
>  Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH v2 1/4] dt-bindings: crypto: ti,omap4-des: Remove redundant clock properties

[Andreas Kemnade]

On Fri, 18 Sep 2026 10:46:57 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Wed, Sep 16, 2026 at 02:29:38AM +0530, Bhargav Joshi wrote:
> > The omap-des driver doesn't use the clocks and clock-names properties
> > because clock management is entirely handled by the parent ti-sysc
> > wrapper. files omap5-l4.dtsi, omap4-l4.dtsi, am4372.dtsi doesn't use
> > these properties either.  
> 
First a simple idea about reasoning here. Start with the assumption that
Linux does not exist and there are random operating systems. using devicetree.
Try to justify your patch that way. 

> This is not a correct reason alone to make a DT change and it is
> explicitly documented in writing bindings doc. If hardware has clocks,
> but driver does not use them, they must be documented.
> 
This is a lot about how to define several things.

Hardware is described by splitting them into some power management part
(compatible "ti-sysc") as parent and the main part. Basic clocking is
described in that ti-sysc part.

But the situation is a bit different here. The clock to be removed is
different from the stuff in the ti-sysc part. So it needs indeed some more
arguing.

Regards,
Andreas

Re: [PATCH v2 2/4] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

[Andreas Kemnade]

On Wed, 16 Sep 2026 02:29:39 +0530
Bhargav Joshi <j.bhargav.u@gmail.com> wrote:

> The omap-sham, omap4-des and omap2-aes crypto drivers do not use
> "clocks" and "clock-names" properties. Clock management is handled by
> the ti-sysc interconnect parent wrapper. The dt-bindings for
> ti,omap-sham and ti,omap-aes don't define these clock properties. Having
> them in the child nodes causes dtbs_check warnings.
> 
> Remove the "clocks" and "clock-names" properties from the sham, des and
> aes nodes.
> 
> Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>

I was a bit too fast here, clocks here are different from what is
used in the ti-sysc block. So some more thought and argumenting is needed.

Regards,
Andreas

> ---
>  arch/arm/boot/dts/ti/omap/dra7-l4.dtsi | 2 --
>  arch/arm/boot/dts/ti/omap/dra7.dtsi    | 8 --------
>  2 files changed, 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> index a595745afe59..bca035fd7e62 100644
> --- a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> @@ -2086,8 +2086,6 @@ des: des@0 {
>  				interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&sdma_xbar 117>, <&sdma_xbar 116>;
>  				dma-names = "tx", "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi
> index 711ce4c31bb1..0784c6d9cbe4 100644
> --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi
> @@ -1012,8 +1012,6 @@ aes1: aes@0 {
>  				interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 111 0>, <&edma_xbar 110 0>;
>  				dma-names = "tx", "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> @@ -1043,8 +1041,6 @@ aes2: aes@0 {
>  				interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 114 0>, <&edma_xbar 113 0>;
>  				dma-names = "tx", "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> @@ -1073,8 +1069,6 @@ sham1: sham@0 {
>  				interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 119 0>;
>  				dma-names = "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> @@ -1103,8 +1097,6 @@ sham2: sham@0 {
>  				interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 165 0>;
>  				dma-names = "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
>