[PATCH] drm/mgag200: prevent PLL divide-by-zero and validate framebuffer pitch/size

[PATCH] drm/mgag200: prevent PLL divide-by-zero and validate framebuffer pitch/size

[Hui Peng]

In drivers/gpu/drm/mgag200/ (mgag200_mode.c, mgag200_g200se.c), validate
clock/PLL parameters and verify framebuffer pitch * height fits in VRAM.

Fixes: 414c45310625 ("mgag200: initial g200se driver (v2)")
Assisted-by: LLM
Signed-off-by: Hui Peng <benquike@gmail.com>
---
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200se.c b/drivers/gpu/drm/mgag200/mgag200_g200se.c
index 349ec36f6d49..d24af3bb5029 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200se.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200se.c
@@ -257,17 +257,17 @@ static int mgag200_g200se_04_pixpllc_atomic_check(struct drm_crtc *crtc,
 		}
 	}
 
+	if (delta > permitteddelta || !m) {
+		pr_warn("PLL delta too large\n");
+		return -EINVAL;
+	}
+
 	fvv = pllreffreq * n / m;
 	fvv = (fvv - 800000) / 50000;
 	if (fvv > 15)
 		fvv = 15;
 	s = fvv << 1;
 
-	if (delta > permitteddelta) {
-		pr_warn("PLL delta too large\n");
-		return -EINVAL;
-	}
-
 	pixpllc->m = m;
 	pixpllc->n = n;
 	pixpllc->p = p;
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 7e07fc3f1a60..a881d85e6f39 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -468,6 +468,7 @@ int mgag200_primary_plane_helper_atomic_check(struct drm_plane *plane,
 	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(new_state, plane);
 	struct drm_framebuffer *new_fb = new_plane_state->fb;
 	struct drm_framebuffer *fb = NULL;
+	struct mga_device *mdev = to_mga_device(plane->dev);
 	struct drm_crtc *new_crtc = new_plane_state->crtc;
 	struct drm_crtc_state *new_crtc_state = NULL;
 	struct mgag200_crtc_state *new_mgag200_crtc_state;
@@ -485,6 +486,9 @@ int mgag200_primary_plane_helper_atomic_check(struct drm_plane *plane,
 	else if (!new_plane_state->visible)
 		return 0;
 
+	if ((u64)new_fb->pitches[0] * new_fb->height > mdev->vram_available)
+		return -EINVAL;
+
 	if (plane->state)
 		fb = plane->state->fb;