mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] clk: mediatek: mt7988-apmixed: publish the OF module alias
@ 2026-09-20  3:38 Pengpeng Hou
  2026-09-21 10:56 ` AngeloGioacchino Del Regno
  0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-09-20  3:38 UTC (permalink / raw)
  To: sboyd
  Cc: bmasney+clk, jbrunet+clk, matthias.bgg,
	angelogioacchino.delregno, linux-clk, linux-kernel,
	linux-arm-kernel, linux-mediatek, sam.shih, daniel, hppiscas

COMMON_CLK_MT7988 permits a module build, and the apmixed driver matches
mediatek,mt7988-apmixedsys through its OF table. The table is not
exported, so the module does not publish the corresponding autoload
alias.

Add MODULE_DEVICE_TABLE() for that existing table.

The issue was found by our static-analysis tool.

Fixes: 4b4719437d85 ("clk: mediatek: add drivers for MT7988 SoC")
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Assisted-by: gpt 5
Signed-off-by: Pengpeng Hou <hppiscas@163.com>
---
Changes since v1:
https://lore.kernel.org/all/20260905133417.64373-1-hppiscas@163.com/
Use the full author name in the submission identity; retain the code
reviewed by Daniel.

 drivers/clk/mediatek/clk-mt7988-apmixed.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/mediatek/clk-mt7988-apmixed.c b/drivers/clk/mediatek/clk-mt7988-apmixed.c
index 416a4b88d100..24f4e7b87a31 100644
--- a/drivers/clk/mediatek/clk-mt7988-apmixed.c
+++ b/drivers/clk/mediatek/clk-mt7988-apmixed.c
@@ -75,6 +75,7 @@ static const struct of_device_id of_match_clk_mt7988_apmixed[] = {
 	{ .compatible = "mediatek,mt7988-apmixedsys" },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, of_match_clk_mt7988_apmixed);
 
 static int clk_mt7988_apmixed_probe(struct platform_device *pdev)
 {

base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137
-- 
2.50.1 (Apple Git-155)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] clk: mediatek: mt7988-apmixed: publish the OF module alias
  2026-09-20  3:38 [PATCH v2] clk: mediatek: mt7988-apmixed: publish the OF module alias Pengpeng Hou
@ 2026-09-21 10:56 ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-09-21 10:56 UTC (permalink / raw)
  To: Pengpeng Hou, sboyd
  Cc: bmasney+clk, jbrunet+clk, matthias.bgg, linux-clk, linux-kernel,
	linux-arm-kernel, linux-mediatek, sam.shih, daniel

On 9/20/26 05:38, Pengpeng Hou wrote:
> COMMON_CLK_MT7988 permits a module build, and the apmixed driver matches
> mediatek,mt7988-apmixedsys through its OF table. The table is not
> exported, so the module does not publish the corresponding autoload
> alias.
> 
> Add MODULE_DEVICE_TABLE() for that existing table.
> 
> The issue was found by our static-analysis tool.
> 
> Fixes: 4b4719437d85 ("clk: mediatek: add drivers for MT7988 SoC")
> Reviewed-by: Daniel Golle <daniel@makrotopia.org>
> Assisted-by: gpt 5
> Signed-off-by: Pengpeng Hou <hppiscas@163.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-21 10:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-20  3:38 [PATCH v2] clk: mediatek: mt7988-apmixed: publish the OF module alias Pengpeng Hou
2026-09-21 10:56 ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®