* [PATCH] Documentation: kunit: Fix KUNIT_DEFINE_ACTION_WRAPPER() argument order
@ 2026-09-21 0:00 Kees Cook
0 siblings, 0 replies; only message in thread
From: Kees Cook @ 2026-09-21 0:00 UTC (permalink / raw)
To: Brendan Higgins
Cc: Kees Cook, David Gow, Rae Moar, Jonathan Corbet, Shuah Khan,
kunit-dev, linux-doc, Randy Dunlap, linux-kernel,
linux-kselftest, linux-hardening
The macro is
#define KUNIT_DEFINE_ACTION_WRAPPER(wrapper, orig, arg_type) ...
so it defines "wrapper" which calls orig(arg_type). The example names
them the other way round. Swap the two order.
Fixes: 56778b49c9a2c ("kunit: Add a macro to wrap a deferred action function")
Assisted-by: LLM
Signed-off-by: Kees Cook <kees@kernel.org>
---
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <david@davidgow.net>
Cc: Rae Moar <raemoar63@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Cc: <kunit-dev@googlegroups.com>
Cc: <linux-doc@vger.kernel.org>
---
Documentation/dev-tools/kunit/usage.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kunit/usage.rst
index 1c78dfff94e8..8fec131f8ee7 100644
--- a/Documentation/dev-tools/kunit/usage.rst
+++ b/Documentation/dev-tools/kunit/usage.rst
@@ -1028,7 +1028,7 @@ with the ``KUNIT_DEFINE_ACTION_WRAPPER()`` macro, for example:
.. code-block:: C
- KUNIT_DEFINE_ACTION_WRAPPER(device_unregister, device_unregister_wrapper, struct device *);
+ KUNIT_DEFINE_ACTION_WRAPPER(device_unregister_wrapper, device_unregister, struct device *);
kunit_add_action(test, &device_unregister_wrapper, &dev);
You should do this in preference to manually casting to the ``kunit_action_t`` type,
--
2.34.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-21 0:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-21 0:00 [PATCH] Documentation: kunit: Fix KUNIT_DEFINE_ACTION_WRAPPER() argument order Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®