From: Jonathan Cameron <jic23@kernel.org>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux@analog.com>, <michael.hennerich@analog.com>,
<nuno.sa@analog.com>, <dlechner@baylibre.com>, <andy@kernel.org>,
<marcelo.schmitt1@gmail.com>
Subject: Re: [PATCH v1 1/1] iio: adc: ad7173: Fix digital filter configuration
Date: Mon, 21 Sep 2026 01:18:52 +0100 [thread overview]
Message-ID: <20260921011852.1325aed0@jic23-hlaptop> (raw)
In-Reply-To: <6de8050f5cc2b1632d7c72e4d290a484dbe53d31.1789577939.git.marcelo.schmitt@analog.com>
On Wed, 16 Sep 2026 14:01:34 -0300
Marcelo Schmitt <marcelo.schmitt@analog.com> wrote:
> Filter enable and filter type selection masks were swapped on data
> preparation for filter configuration register write. Use the correct masks
> to set each property of post filter configuration.
>
> Fixes: bb688cd9f772 ("iio: adc: ad7173: support changing filter type")
That's not a valid hash. Fixed up whilst applying.
Applied to the fixes-togreg branch of iio.git.
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> ---
> drivers/iio/adc/ad7173.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index eb47175a0528..faebb7b34a15 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -775,9 +775,9 @@ static int ad7173_load_config(struct ad7173_state *st,
>
> return ad_sd_write_reg(&st->sd, AD7173_REG_FILTER(free_cfg_slot), 2,
> FIELD_PREP(AD7173_FILTER_SINC3_MAP, 0) |
> - FIELD_PREP(AD7173_FILTER_ENHFILT_MASK,
> - post_filter_enable) |
> FIELD_PREP(AD7173_FILTER_ENHFILTEN,
> + post_filter_enable) |
> + FIELD_PREP(AD7173_FILTER_ENHFILT_MASK,
> post_filter_select) |
> FIELD_PREP(AD7173_FILTER_ORDER, 0) |
> FIELD_PREP(AD7173_FILTER_ODR_MASK,
>
> base-commit: 9c464e7473f762cee4c031a09da04f65a1c65d49
prev parent reply other threads:[~2026-09-21 0:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 17:01 Marcelo Schmitt
2026-09-21 0:18 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921011852.1325aed0@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®