* [PATCH v1 1/1] iio: adc: ad7173: Fix digital filter configuration
@ 2026-09-16 17:01 Marcelo Schmitt
2026-09-21 0:18 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Schmitt @ 2026-09-16 17:01 UTC (permalink / raw)
To: linux-iio, linux-kernel, linux
Cc: jic23, michael.hennerich, nuno.sa, dlechner, andy, marcelo.schmitt1
Filter enable and filter type selection masks were swapped on data
preparation for filter configuration register write. Use the correct masks
to set each property of post filter configuration.
Fixes: bb688cd9f772 ("iio: adc: ad7173: support changing filter type")
Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
---
drivers/iio/adc/ad7173.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
index eb47175a0528..faebb7b34a15 100644
--- a/drivers/iio/adc/ad7173.c
+++ b/drivers/iio/adc/ad7173.c
@@ -775,9 +775,9 @@ static int ad7173_load_config(struct ad7173_state *st,
return ad_sd_write_reg(&st->sd, AD7173_REG_FILTER(free_cfg_slot), 2,
FIELD_PREP(AD7173_FILTER_SINC3_MAP, 0) |
- FIELD_PREP(AD7173_FILTER_ENHFILT_MASK,
- post_filter_enable) |
FIELD_PREP(AD7173_FILTER_ENHFILTEN,
+ post_filter_enable) |
+ FIELD_PREP(AD7173_FILTER_ENHFILT_MASK,
post_filter_select) |
FIELD_PREP(AD7173_FILTER_ORDER, 0) |
FIELD_PREP(AD7173_FILTER_ODR_MASK,
base-commit: 9c464e7473f762cee4c031a09da04f65a1c65d49
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] iio: adc: ad7173: Fix digital filter configuration
2026-09-16 17:01 [PATCH v1 1/1] iio: adc: ad7173: Fix digital filter configuration Marcelo Schmitt
@ 2026-09-21 0:18 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2026-09-21 0:18 UTC (permalink / raw)
To: Marcelo Schmitt
Cc: linux-iio, linux-kernel, linux, michael.hennerich, nuno.sa,
dlechner, andy, marcelo.schmitt1
On Wed, 16 Sep 2026 14:01:34 -0300
Marcelo Schmitt <marcelo.schmitt@analog.com> wrote:
> Filter enable and filter type selection masks were swapped on data
> preparation for filter configuration register write. Use the correct masks
> to set each property of post filter configuration.
>
> Fixes: bb688cd9f772 ("iio: adc: ad7173: support changing filter type")
That's not a valid hash. Fixed up whilst applying.
Applied to the fixes-togreg branch of iio.git.
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> ---
> drivers/iio/adc/ad7173.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index eb47175a0528..faebb7b34a15 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -775,9 +775,9 @@ static int ad7173_load_config(struct ad7173_state *st,
>
> return ad_sd_write_reg(&st->sd, AD7173_REG_FILTER(free_cfg_slot), 2,
> FIELD_PREP(AD7173_FILTER_SINC3_MAP, 0) |
> - FIELD_PREP(AD7173_FILTER_ENHFILT_MASK,
> - post_filter_enable) |
> FIELD_PREP(AD7173_FILTER_ENHFILTEN,
> + post_filter_enable) |
> + FIELD_PREP(AD7173_FILTER_ENHFILT_MASK,
> post_filter_select) |
> FIELD_PREP(AD7173_FILTER_ORDER, 0) |
> FIELD_PREP(AD7173_FILTER_ODR_MASK,
>
> base-commit: 9c464e7473f762cee4c031a09da04f65a1c65d49
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-21 0:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-16 17:01 [PATCH v1 1/1] iio: adc: ad7173: Fix digital filter configuration Marcelo Schmitt
2026-09-21 0:18 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®