From: Petko Manolov <petko.manolov@konsulko.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
dinguyen@kernel.org, arnemaximilian.richter@draeger.com,
martynas.grybauskas@draeger.com
Subject: Re: [PATCH v6 3/3] arm: dts: altera: add Draeger M48 CPU Module
Date: Mon, 21 Sep 2026 12:06:59 +0300 [thread overview]
Message-ID: <20260921090659.GD14552@cabron.k.g> (raw)
In-Reply-To: <042c39d5-0642-4bcd-b965-61fce77b52ae@kernel.org>
On 26-09-20 11:52:36, Krzysztof Kozlowski wrote:
> On 20/09/2026 09:59, Petko Manolov wrote:
> > On 26-09-18 13:57:22, Krzysztof Kozlowski wrote:
> >> On Thu, Sep 17, 2026 at 07:31:56PM +0300, Petko Manolov wrote:
> >>> Draeger M48 CPU Module that is built around Altera SoCFPGA.
> >>
> >> How can you run a CPU module alone? To my knowledge there is only one such
> >> case, only one exception, and it was explained by the authors. If this is
> >> second, I already asked you to properly explain the hardware in commit msg.
> >
> > I've described the board/carrier/module/whatever in the cover letter. When i
>
> Cover letters do not matter. We don't read them and they usually do not end up
> in the git history. Your commit must stand on its own, not rely on cover
> letter.
Fair enough. Shall i drop cover letters entirely?
> > put the same text in the commit message Sashiko rejected the patch on the
> > grounds that there should be just one CPU architecture there. But there are
> > two.
>
> Sashiko cannot reject a patch. Does not have such abilities nor power.
It does influence your decisions, though.
> Regardless its comment was right - your description was between incomplete to
> confusing.
You do realize your comments mostly criticize, but do very little to actually
help resolve the issues, don't you?
Petko
prev parent reply other threads:[~2026-09-21 9:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 16:31 [PATCH v6 0/3] " Petko Manolov
2026-09-17 16:31 ` [PATCH v6 1/3] dt-bindings: vendor-prefixes: add Draeger AG Petko Manolov
2026-09-18 11:54 ` Krzysztof Kozlowski
2026-09-17 16:31 ` [PATCH v6 2/3] dt-bindings: arm: altera: add Draeger M48 Module Petko Manolov
2026-09-18 11:55 ` Krzysztof Kozlowski
2026-09-20 7:23 ` Petko Manolov
2026-09-21 7:42 ` Petko Manolov
2026-09-17 16:31 ` [PATCH v6 3/3] arm: dts: altera: add Draeger M48 CPU Module Petko Manolov
2026-09-18 11:57 ` Krzysztof Kozlowski
2026-09-20 7:59 ` Petko Manolov
2026-09-20 9:52 ` Krzysztof Kozlowski
2026-09-21 9:06 ` Petko Manolov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921090659.GD14552@cabron.k.g \
--to=petko.manolov@konsulko.com \
--cc=arnemaximilian.richter@draeger.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martynas.grybauskas@draeger.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®