From: sashiko-bot@kernel.org
To: zhangtianyang@loongson.cn, chleroy@kernel.org,
eric.devolder@oracle.com, linux-kernel@vger.kernel.org,
driver-core@lists.linux.dev, dakr@kernel.org,
guodongtai@kylinos.cn, hpa@zytor.com, kernel@xen0n.name,
chao.gao@intel.com, pasha.tatashin@soleen.com, npiggin@gmail.com,
coxu@redhat.com, liukexin@kylinos.cn, seanjc@google.com,
bgwin@google.com, rppt@kernel.org, bp@alien8.de,
kai.huang@intel.com, sshegde@linux.ibm.com, kees@kernel.org,
mpe@ellerman.id.au, tglx@kernel.org, jbouron@amazon.com,
yeoreum.yun@arm.com, "Jinjie Ruan" <ruanjinjie@huawei.com>,
maddy@linux.ibm.com, gregkh@linuxfoundation.org, will@kernel.org,
pratyush@kernel.org, akpm@linux-foundation.org, robh@kernel.org,
tangyouling@kylinos.cn, piliu@redhat.com, hbathini@linux.ibm.com,
mark.rutland@arm.com, chenhuacai@kernel.org, me@linux.beauty,
mclapinski@google.com, dave.hansen@linux.intel.com,
ritesh.list@gmail.com, x86@kernel.org,
linux-arm-kernel@lists.infradead.org, leitao@debian.org,
palmer@rivosinc.com, maqianga@uniontech.com, james.morse@arm.com,
takahiro.akashi@linaro.org, linuxppc-dev@lists.ozlabs.org,
loongarch@lists.linux.dev, vishal.l.verma@intel.com,
catalin.marinas@arm.com, graf@amazon.com,
sourabhjain@linux.ibm.com, mingo@redhat.com,
ruirui.yang@linux.dev, rafael@kernel.org, baoquan.he@linux.dev,
thuth@redhat.com
Cc: kexec@lists.infradead.org, ruanjinjie@huawei.com
Subject: Re: [PATCH v6 12/14] crash: Normalize the kexec_load elfcorehdr at load time
Date: Mon, 21 Sep 2026 09:19:51 +0000 [thread overview]
Message-ID: <20260921091951.BDE231F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921090450.807575-13-ruanjinjie@huawei.com>
> For kexec_load() the kernel does not build the elfcorehdr, so it is only
> rewritten by the first crash hotplug event. CPU hotplug events do not
> change the elfcorehdr, but they may run without device_hotplug_lock
> (e.g. CPU offlining during suspend), so they cannot perform that rewrite
> without racing with memory hotplug.
>
> Normalize the elfcorehdr once when the crash image is installed via
> crash_hotplug_prepare_elfcorehdr(), while device_hotplug_lock can still
> be taken safely, and let the hotplug paths skip CPU events entirely.
> Architectures that do not need the rewrite (e.g. powerpc) treat
> KEXEC_CRASH_HP_NONE as a no-op.
>
> The x86 crash hotplug handler now skips CPU hotplug events
> unconditionally, so nothing reads image->elfcorehdr_updated anymore.
> Drop the field and the code that maintains it.
> [ ... ]
> Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
> Cc: Pratyush Yadav <pratyush@kernel.org>
> Cc: Dave Young <ruirui.yang@linux.dev>
> Cc: Sourabh Jain <sourabhjain@linux.ibm.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921090450.807575-1-ruanjinjie@huawei.com?part=12
next prev parent reply other threads:[~2026-09-21 9:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 9:04 [PATCH v6 00/14] crash: Fix several bugs Jinjie Ruan
2026-09-21 9:04 ` [PATCH v6 01/14] kexec: Fix CMA segment address translation with non-zero text_offset Jinjie Ruan
2026-09-21 9:17 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 02/14] kexec: Record allocated CMA pages to fix release size mismatch Jinjie Ruan
2026-09-21 9:14 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 03/14] kexec: Extract kexec_free_segment_cma() from kimage_free_cma() Jinjie Ruan
2026-09-21 9:13 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 04/14] arm64: kexec_file: Fix CMA page leaks in segment placement retry loops Jinjie Ruan
2026-09-21 9:18 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 05/14] arm64: kexec_file: Fix elf_headers memory leak in retry loop Jinjie Ruan
2026-09-21 9:15 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 06/14] LoongArch: kexec_file: Fix CMA page leaks in segment placement retry loops Jinjie Ruan
2026-09-21 9:13 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 07/14] LoongArch: kexec_file: Fix elf_headers memory leak in retry loop Jinjie Ruan
2026-09-21 9:14 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 08/14] LoongArch: kexec_file: Fix a modified_cmdline leak Jinjie Ruan
2026-09-21 9:15 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 09/14] x86/crash: Fix massive out-of-bounds write on 32-bit Highmem Jinjie Ruan
2026-09-21 9:04 ` [PATCH v6 10/14] crash: Extract crash_get_memory_ranges() helper Jinjie Ruan
2026-09-21 9:19 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 11/14] crash: Factor out crash_find_elfcorehdr() helper Jinjie Ruan
2026-09-21 9:17 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 12/14] crash: Normalize the kexec_load elfcorehdr at load time Jinjie Ruan
2026-09-21 9:19 ` sashiko-bot [this message]
2026-09-21 9:04 ` [PATCH v6 13/14] driver core: Add device_hotplug_lock_assert_held() helper Jinjie Ruan
2026-09-21 9:18 ` sashiko-bot
2026-09-21 9:04 ` [PATCH v6 14/14] crash: Fix TOCTOU race in crash memory range collection Jinjie Ruan
2026-09-21 9:25 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921091951.BDE231F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baoquan.he@linux.dev \
--cc=bgwin@google.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chao.gao@intel.com \
--cc=chenhuacai@kernel.org \
--cc=chleroy@kernel.org \
--cc=coxu@redhat.com \
--cc=dakr@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=driver-core@lists.linux.dev \
--cc=eric.devolder@oracle.com \
--cc=graf@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=guodongtai@kylinos.cn \
--cc=hbathini@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jbouron@amazon.com \
--cc=kai.huang@intel.com \
--cc=kees@kernel.org \
--cc=kernel@xen0n.name \
--cc=kexec@lists.infradead.org \
--cc=leitao@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liukexin@kylinos.cn \
--cc=loongarch@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=maqianga@uniontech.com \
--cc=mark.rutland@arm.com \
--cc=mclapinski@google.com \
--cc=me@linux.beauty \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@rivosinc.com \
--cc=pasha.tatashin@soleen.com \
--cc=piliu@redhat.com \
--cc=pratyush@kernel.org \
--cc=rafael@kernel.org \
--cc=ritesh.list@gmail.com \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=ruirui.yang@linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=seanjc@google.com \
--cc=sourabhjain@linux.ibm.com \
--cc=sshegde@linux.ibm.com \
--cc=takahiro.akashi@linaro.org \
--cc=tangyouling@kylinos.cn \
--cc=tglx@kernel.org \
--cc=thuth@redhat.com \
--cc=vishal.l.verma@intel.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yeoreum.yun@arm.com \
--cc=zhangtianyang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®