From: Rupesh Majhi <zoone.rupert@gmail.com>
To: "Andy Shevchenko" <andy@kernel.org>,
"Bill Wendling" <morbo@google.com>,
"David Lechner" <dlechner@baylibre.com>,
"Eddie James" <eajames@linux.ibm.com>,
"Joel Stanley" <joel@jms.id.au>,
"Jonathan Cameron" <jic23@kernel.org>,
"Justin Stitt" <justinstitt@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nuno Sá" <nuno.sa@analog.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Rupesh Majhi <zoone.rupert@gmail.com>
Subject: [PATCH v8 09/10] iio: pressure: dps310: implement .hwfifo_flush_to_buffer()
Date: Mon, 21 Sep 2026 21:31:31 +0300 [thread overview]
Message-ID: <20260921183132.233136-10-zoone.rupert@gmail.com> (raw)
In-Reply-To: <20260921183132.233136-1-zoone.rupert@gmail.com>
Let userspace drain the FIFO on demand rather than only from the
periodic drain.
With a trigger attached the FIFO is not running, so there is nothing to
flush and the hook returns 0.
Hold the mode across the drain, so a concurrent buffer disable cannot
free active_scan_mask while it runs.
Assisted-by: LLM
Signed-off-by: Rupesh Majhi <zoone.rupert@gmail.com>
---
drivers/iio/pressure/dps310.c | 36 ++++++++++++++++++++++++++++++++---
1 file changed, 33 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/pressure/dps310.c b/drivers/iio/pressure/dps310.c
index 974630eca547..59203df1ae35 100644
--- a/drivers/iio/pressure/dps310.c
+++ b/drivers/iio/pressure/dps310.c
@@ -1093,22 +1093,30 @@ static int dps310_fifo_push_held(struct dps310_data *data)
/*
* Read the batch out before compensating it, so a pressure entry pairs with
- * the temperature preceding it rather than the last one in the batch.
+ * the temperature preceding it rather than the last one in the batch. Stop
+ * reading at max_scans rather than after it, since entries leave the hardware
+ * as they are read and any extra would have to be thrown away. max_scans of
+ * zero drains everything.
*
* Returns scans pushed.
*/
-static int dps310_fifo_drain(struct dps310_data *data)
+static int dps310_fifo_drain(struct dps310_data *data, unsigned int max_scans)
__must_hold(&data->lock)
{
bool pressure_enabled = test_bit(DPS310_SCAN_PRESSURE,
data->iio->active_scan_mask);
u8 kind[DPS310_FIFO_DEPTH];
s32 raw[DPS310_FIFO_DEPTH];
+ unsigned int scans = 0;
unsigned int pushed = 0;
unsigned int cnt, i;
+ bool is_pressure;
int rc;
for (cnt = 0; cnt < DPS310_FIFO_DEPTH; cnt++) {
+ if (max_scans && scans >= max_scans)
+ break;
+
rc = dps310_fifo_read_entry(data, &raw[cnt]);
if (rc < 0)
return rc;
@@ -1116,7 +1124,12 @@ static int dps310_fifo_drain(struct dps310_data *data)
if (rc == DPS310_FIFO_EMPTY)
break;
+ is_pressure = rc == DPS310_FIFO_PRESSURE;
kind[cnt] = rc;
+
+ /* Only the measurement that drives the scans counts */
+ if (is_pressure == pressure_enabled)
+ scans++;
}
for (i = 0; i < cnt; i++) {
@@ -1166,7 +1179,7 @@ static void dps310_fifo_work(struct work_struct *work)
int rc;
mutex_lock(&data->lock);
- rc = dps310_fifo_drain(data);
+ rc = dps310_fifo_drain(data, 0);
mutex_unlock(&data->lock);
if (rc < 0)
@@ -1201,6 +1214,22 @@ static int dps310_fifo_hold_alloc(struct dps310_data *data, int prs_rate,
return 0;
}
+static int dps310_hwfifo_flush(struct iio_dev *iio, unsigned int count)
+{
+ struct dps310_data *data = iio_priv(iio);
+
+ /* Holding the mode keeps active_scan_mask alive across the drain */
+ IIO_DEV_GUARD_CURRENT_MODE(iio);
+
+ /* A trigger drives the capture instead and leaves the FIFO empty */
+ if (iio_device_get_current_mode(iio) != INDIO_BUFFER_SOFTWARE)
+ return 0;
+
+ guard(mutex)(&data->lock);
+
+ return dps310_fifo_drain(data, count);
+}
+
static int dps310_hwfifo_set_watermark(struct iio_dev *iio, unsigned int val)
{
struct dps310_data *data = iio_priv(iio);
@@ -1338,6 +1367,7 @@ static const struct iio_info dps310_info = {
.read_raw = dps310_read_raw,
.write_raw = dps310_write_raw,
.hwfifo_set_watermark = dps310_hwfifo_set_watermark,
+ .hwfifo_flush_to_buffer = dps310_hwfifo_flush,
};
static int dps310_probe(struct i2c_client *client)
--
2.43.0
next prev parent reply other threads:[~2026-09-21 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 18:31 [PATCH v8 00/10] iio: pressure: dps310: FIFO and triggered buffer support Rupesh Majhi
2026-09-21 18:31 ` [PATCH v8 01/10] iio: pressure: dps310: fix CFG_REG bit definitions Rupesh Majhi
2026-09-21 18:31 ` [PATCH v8 02/10] iio: pressure: dps310: use a local device pointer in probe Rupesh Majhi
2026-09-21 18:31 ` [PATCH v8 03/10] iio: pressure: dps310: use get_unaligned_be24() for the 24-bit results Rupesh Majhi
2026-09-21 18:31 ` [PATCH v8 04/10] iio: pressure: dps310: take the lock once per raw read Rupesh Majhi
2026-09-21 18:31 ` [PATCH v8 05/10] iio: pressure: dps310: add triggered buffer support Rupesh Majhi
2026-09-21 18:31 ` [PATCH v8 06/10] iio: core: add an accessor for scan_timestamp Rupesh Majhi
2026-09-21 18:31 ` [PATCH v8 07/10] iio: pressure: dps310: read buffered samples from the hardware FIFO Rupesh Majhi
2026-09-21 18:31 ` [PATCH v8 08/10] iio: pressure: dps310: derive the drain interval from the watermark Rupesh Majhi
2026-09-21 18:31 ` Rupesh Majhi [this message]
2026-09-21 18:31 ` [PATCH v8 10/10] iio: pressure: dps310: check the lock markings with context analysis Rupesh Majhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921183132.233136-10-zoone.rupert@gmail.com \
--to=zoone.rupert@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=justinstitt@google.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®