* [PATCH] mm/damon: fix typos in comments
@ 2026-09-22 3:36 Zhijian Han
2026-09-22 6:42 ` SJ Park
0 siblings, 1 reply; 2+ messages in thread
From: Zhijian Han @ 2026-09-22 3:36 UTC (permalink / raw)
To: SJ Park; +Cc: Andrew Morton, SeongJae Park, damon, linux-mm, linux-kernel
Fix spelling errors found by codespell in mm/damon/core.c:
- "widnow" -> "window"
- "makrs" -> "marks"
No functional changes.
Signed-off-by: Zhijian Han <hanzhijian1991@gmail.com>
---
mm/damon/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 644daf5a1..c01b7e2a1 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -2328,7 +2328,7 @@ static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r,
* This function checks if a given region should be skipped or not for the
* reason. If only the starting part of the region has previously charged,
* this function splits the region into two so that the second one covers the
- * area that not charged in the previous charge widnow, and return true. The
+ * area that not charged in the previous charge window, and return true. The
* caller can see the second one on the next iteration of the region walk.
* Note that this means the caller should use damon_for_each_region() instead
* of damon_for_each_region_safe(). If damon_for_each_region_safe() is used,
@@ -2486,7 +2486,7 @@ static void damos_walk_call_walk(struct damon_ctx *ctx, struct damon_target *t,
* This function is called when kdamond finished applying the action of a DAMOS
* scheme to all regions that eligible for the given &damos->apply_interval_us.
* If every scheme of @ctx including @s now finished walking for at least one
- * &damos->apply_interval_us, this function makrs the handling of the given
+ * &damos->apply_interval_us, this function marks the handling of the given
* DAMOS walk request is done, so that damos_walk() can wake up and return.
*/
static void damos_walk_complete(struct damon_ctx *ctx, struct damos *s)
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/damon: fix typos in comments
2026-09-22 3:36 [PATCH] mm/damon: fix typos in comments Zhijian Han
@ 2026-09-22 6:42 ` SJ Park
0 siblings, 0 replies; 2+ messages in thread
From: SJ Park @ 2026-09-22 6:42 UTC (permalink / raw)
To: Zhijian Han
Cc: SJ Park, Andrew Morton, SeongJae Park, damon, linux-mm, linux-kernel
Hi Zhijian,
On Tue, 22 Sep 2026 11:36:18 +0800 Zhijian Han <hanzhijian1991@gmail.com> wrote:
> Fix spelling errors found by codespell in mm/damon/core.c:
>
> - "widnow" -> "window"
> - "makrs" -> "marks"
>
> No functional changes.
Thank you for sharing this patch. However, same fix is already posted by
Adrian already [1] and accepted. So unfortunately we cannot accept this patch.
Please set the baseline of your work with recommended ones [2] from the next
time.
I also found that you posted another bigger typos fix patch [3] that contains
this patch's change. That's confusing. Please post only the bigger one or a
series of smaller ones from the next time.
[1] https://lore.kernel.org/20260921151547.78472-4-sj@kernel.org
[2] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
[2] https://lore.kernel.org/20260922031843.2857104-1-hanzhijian1991@gmail.com
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-22 6:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-22 3:36 [PATCH] mm/damon: fix typos in comments Zhijian Han
2026-09-22 6:42 ` SJ Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®