mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: John Stultz <jstultz@google.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>, Hui Su <sh_def@163.com>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Zhidao Su <soolaugust@gmail.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] sched/proxy_exec: detect cycles in proxy walks
Date: Tue, 22 Sep 2026 09:18:16 +0200	[thread overview]
Message-ID: <20260922071816.GT4121339@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CANDhNCqKYjO=0mFM1aidHyAWaRirD2zO4_HqH=qB+0x-Uhk9PQ@mail.gmail.com>

On Mon, Sep 21, 2026 at 11:06:52PM -0700, John Stultz wrote:

> > So if we are eventually planning on returning -EDEADLK to userspace
> > (context: https://lore.kernel.org/lkml/20260917153649.GK4121339@noisy.programming.kicks-ass.net/)
> > do we care where the chain starts or can we return -EDEADLK anywhere
> > in the chain?
> 
> So returning EDEADLK to userland seems like a new feature to me, as I
> don't believe existing futexes (which can still have dependency cycles
> or just ABA style usage) currently do this.

  git grep -e DEADLK -e DEADLOCK kernel/{futex,locking}

We definitely return -EDEADLK for PI futexes and rt_mutex. And given the
whole proxy thing hard relies on the block graph being acyclic, it
seems rather mandatory we enforce this before exposing it to userspace.


  reply	other threads:[~2026-09-22  7:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 16:54 [RFC PATCH 0/1] sched/proxy_exec: detect cycles without persistent walk state Hui Su
2026-09-14 16:54 ` [RFC PATCH 1/1] sched/proxy_exec: detect cycles in proxy walks Hui Su
2026-09-22  5:26   ` John Stultz
2026-09-22  5:48     ` K Prateek Nayak
2026-09-22  6:06       ` John Stultz
2026-09-22  7:18         ` Peter Zijlstra [this message]
2026-09-19 15:51 ` [RFC PATCH 0/1] sched/proxy_exec: detect cycles without persistent walk state Hui Su

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922071816.GT4121339@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=sh_def@163.com \
    --cc=soolaugust@gmail.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®