* [PATCH] staging: sm750fb: fix const pointer declaration in sm750.c
@ 2026-09-22 19:36 Vladan Kalaba
2026-09-23 7:28 ` Ahmet Sezgin Duran
0 siblings, 1 reply; 3+ messages in thread
From: Vladan Kalaba @ 2026-09-22 19:36 UTC (permalink / raw)
To: gregkh, sudipm.mukherjee, teddy.wang
Cc: vladan.kalaba, linux-fbdev, linux-staging, linux-kernel
Fix static const char * declaration for g_fbmode[] to static const
char * const as reported by checkpatch to cohere to Linux kernel
coding standards.
Signed-off-by: Vladan Kalaba <vladan.kalaba@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 1ea3dd8b8f28..79d0221cdeae 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -12,7 +12,7 @@
static int g_hwcursor = 1;
static int g_noaccel __ro_after_init;
static int g_nomtrr __ro_after_init;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
static const char * const g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview __ro_after_init;
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: sm750fb: fix const pointer declaration in sm750.c
2026-09-22 19:36 [PATCH] staging: sm750fb: fix const pointer declaration in sm750.c Vladan Kalaba
@ 2026-09-23 7:28 ` Ahmet Sezgin Duran
2026-09-23 19:18 ` Vladan Kalaba
0 siblings, 1 reply; 3+ messages in thread
From: Ahmet Sezgin Duran @ 2026-09-23 7:28 UTC (permalink / raw)
To: Vladan Kalaba, gregkh, sudipm.mukherjee, teddy.wang
Cc: linux-fbdev, linux-staging, linux-kernel
On 9/22/26 10:36 PM, Vladan Kalaba wrote:
> Fix static const char * declaration for g_fbmode[] to static const
> char * const as reported by checkpatch to cohere to Linux kernel
> coding standards.
>
> Signed-off-by: Vladan Kalaba <vladan.kalaba@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 1ea3dd8b8f28..79d0221cdeae 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -12,7 +12,7 @@
> static int g_hwcursor = 1;
> static int g_noaccel __ro_after_init;
> static int g_nomtrr __ro_after_init;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
> static const char * const g_def_fbmode = "1024x768-32@60";
> static char *g_settings;
> static int g_dualview __ro_after_init;
Did you compile this patch? While SM750 module is enabled?
Regards,
Ahmet Sezgin Duran
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: sm750fb: fix const pointer declaration in sm750.c
2026-09-23 7:28 ` Ahmet Sezgin Duran
@ 2026-09-23 19:18 ` Vladan Kalaba
0 siblings, 0 replies; 3+ messages in thread
From: Vladan Kalaba @ 2026-09-23 19:18 UTC (permalink / raw)
To: Ahmet Sezgin Duran
Cc: gregkh, sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging,
linux-kernel
On Wed, Sep 23, 2026 at 10:28 AM Ahmet Sezgin Duran
<ahmet@sezginduran.net> wrote:
>
> On 9/22/26 10:36 PM, Vladan Kalaba wrote:
> > Fix static const char * declaration for g_fbmode[] to static const
> > char * const as reported by checkpatch to cohere to Linux kernel
> > coding standards.
> >
> > Signed-off-by: Vladan Kalaba <vladan.kalaba@gmail.com>
> > ---
> > drivers/staging/sm750fb/sm750.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > index 1ea3dd8b8f28..79d0221cdeae 100644
> > --- a/drivers/staging/sm750fb/sm750.c
> > +++ b/drivers/staging/sm750fb/sm750.c
> > @@ -12,7 +12,7 @@
> > static int g_hwcursor = 1;
> > static int g_noaccel __ro_after_init;
> > static int g_nomtrr __ro_after_init;
> > -static const char *g_fbmode[] = {NULL, NULL};
> > +static const char * const g_fbmode[] = {NULL, NULL};
> > static const char * const g_def_fbmode = "1024x768-32@60";
> > static char *g_settings;
> > static int g_dualview __ro_after_init;
>
> Did you compile this patch? While SM750 module is enabled?
>
> Regards,
> Ahmet Sezgin Duran
Hi Ahmet,
My make defconfig didn't compile in SM750, my bad sorry.
Will double check that in the future.
Sincerely,
Vladan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-23 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-22 19:36 [PATCH] staging: sm750fb: fix const pointer declaration in sm750.c Vladan Kalaba
2026-09-23 7:28 ` Ahmet Sezgin Duran
2026-09-23 19:18 ` Vladan Kalaba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®