From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Wentao Liang <vulab@iscas.ac.cn>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
qiuxu.zhuo@intel.com
Subject: Re: [PATCH] EDAC/i10nm: Fix mdev reference leak in i10nm_get_ddr_munits()
Date: Tue, 22 Sep 2026 17:20:09 -0700 [thread overview]
Message-ID: <20260923002009.GCarMbOYCb4onwhwRf@fat_crate.local> (raw)
In-Reply-To: <arLWNgnyo08aFM-R@agluck-desk3>
On Tue, Sep 22, 2026 at 12:25:42PM -0700, Luck, Tony wrote:
> The above is a clear example that should not be tagged for stable. I'm
> suggesting that this EDAC bug doesn't meet the stable criteria.
Aaaha, I see it now. You basically want to point out that this patch
shouldnt've been tagged for stable in the first place.
And I agree - old, error handling path, patch is probably AI-caused, and
nothing really someone hits.
> I ought to have quizzed the submitter on why they thought it needed the
> tag.
Actually, that is your job. And you should remove it if you don't think the
patch is stable material. Because the stable tag causes a *lot* of work
downstream in distros and stable kernels picking up this patch and trying to
figure out why is it even stable material, what it is fixing, should their
customers upgrade, yadda yadda.
So, what I would do is, rebase the branch and zap the stable tag. The stable
tag is not something we should use willy-nilly but think twice whether we
really want to pile more work for distros and stable folks.
And if submitters cannot give a good reason why stable, then off it goes.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-09-23 0:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 9:12 Wentao Liang
2026-09-16 14:31 ` Leo Zhuo
2026-09-17 23:35 ` Luck, Tony
2026-09-19 5:34 ` Borislav Petkov
2026-09-21 16:04 ` Luck, Tony
2026-09-22 4:50 ` Borislav Petkov
2026-09-22 14:59 ` Luck, Tony
2026-09-22 18:53 ` Borislav Petkov
2026-09-22 19:25 ` Luck, Tony
2026-09-23 0:20 ` Borislav Petkov [this message]
2026-09-23 0:30 ` Luck, Tony
2026-09-23 0:33 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923002009.GCarMbOYCb4onwhwRf@fat_crate.local \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®