From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Wentao Liang <vulab@iscas.ac.cn>, <linux-edac@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <qiuxu.zhuo@intel.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] EDAC/i10nm: Fix mdev reference leak in i10nm_get_ddr_munits()
Date: Mon, 21 Sep 2026 09:04:30 -0700 [thread overview]
Message-ID: <arFVjp8k-3kvSkhf@agluck-desk3> (raw)
In-Reply-To: <20260919053437.GEaq4e7SFEZqRzsjim@fat_crate.local>
On Fri, Sep 18, 2026 at 10:34:37PM -0700, Borislav Petkov wrote:
> Hi Tony,
>
> On Thu, Sep 17, 2026 at 04:35:44PM -0700, Luck, Tony wrote:
> > On Wed, Sep 16, 2026 at 09:12:51AM +0000, Wentao Liang wrote:
> > > In i10nm_get_ddr_munits(), get_ddr_munit() returns a PCI device with
> > > its reference count incremented. If ioremap() fails to map the MMIO
> > > space of the memory controller, the function returns -ENODEV without
> > > putting the reference held by mdev, leaking it.
> > >
> > > Put the device reference before returning on the ioremap failure path.
> >
> > Applied. Thanks.
>
> this one has CC:stable. That means it needs to go to Linus now. If so, it
> needs to be into edac-urgent.
I though urgent was for:
1) Fixing something that broke in the current merge window
2) Fixing something that's really important (security, corruption)
This is just an old issue that's been around for ages.
>
> Yes? No?
No.
-Tony
next prev parent reply other threads:[~2026-09-21 16:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 9:12 Wentao Liang
2026-09-16 14:31 ` Leo Zhuo
2026-09-17 23:35 ` Luck, Tony
2026-09-19 5:34 ` Borislav Petkov
2026-09-21 16:04 ` Luck, Tony [this message]
2026-09-22 4:50 ` Borislav Petkov
2026-09-22 14:59 ` Luck, Tony
2026-09-22 18:53 ` Borislav Petkov
2026-09-22 19:25 ` Luck, Tony
2026-09-23 0:20 ` Borislav Petkov
2026-09-23 0:30 ` Luck, Tony
2026-09-23 0:33 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arFVjp8k-3kvSkhf@agluck-desk3 \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®