From: Greg KH <gregkh@linuxfoundation.org>
To: Murali Krishna <muralikrishna2444b@gmail.com>
Cc: srini@kernel.org, ekansh.gupta@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: misc: fastrpc: is a ctx_idr IDR -> XArray conversion wanted?
Date: Wed, 23 Sep 2026 12:41:43 +0200 [thread overview]
Message-ID: <2026092308-landmine-entire-2aa8@gregkh> (raw)
In-Reply-To: <20260923094040.18397-1-muralikrishna2444b@gmail.com>
On Wed, Sep 23, 2026 at 03:10:01PM +0530, Murali Krishna wrote:
> On Wed, Sep 23, 2026 at 11:28:52AM +0200, Greg KH wrote:
> > I doubt it's really needed unless you can prove some sort of advantage
> > for the change? Is it faster on a measurable path, or less memory or
> > something else that would justify the churn?
> >
> > idr is still a fine structure/api for many things, they don't all have
> > to go away, otherwise we would have done so long ago.
>
> Understood, and I cannot show such an advantage. struct idr is already
> built on the same underlying tree as the xarray, so there is nothing
> measurable to gain here in speed or memory -- it would be churn for its
> own sake. I will drop the conversion.
>
> Thank you for answering so quickly, and for explaining the reasoning
> rather than just saying no. That was useful to me.
>
> If there is something in fastrpc, or elsewhere in drivers/misc, that you
> would actually like to see worked on, I would be glad to take on
> something small and learn from the review.
Please help with review and testing of all of the patches that keep
getting sent for this driver, that would be the best help at this point
in time and will show you what needs to be done on it in the future.
thanks,
greg k-h
prev parent reply other threads:[~2026-09-23 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 8:22 Murali Krishna
2026-09-23 9:28 ` Greg KH
2026-09-23 9:40 ` Murali Krishna
2026-09-23 10:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026092308-landmine-entire-2aa8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ekansh.gupta@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muralikrishna2444b@gmail.com \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®