mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srish Srinivasan <ssrish@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
	christophe.leroy@csgroup.eu, nayna@linux.ibm.com,
	gjoyce@linux.ibm.com, ritesh.list@gmail.com,
	sshegde@linux.ibm.com, linux-kernel@vger.kernel.org,
	rnsastry@linux.ibm.com, ssrish@linux.ibm.com
Subject: [PATCH 10/12] pseries/plpks: make narrowing conversions explicit
Date: Wed, 23 Sep 2026 23:58:14 +0530	[thread overview]
Message-ID: <20260923182816.151451-11-ssrish@linux.ibm.com> (raw)
In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com>

Add explicit casts when assigning values from the hcall return buffers
to narrower fields to make the intended conversions clear.

Signed-off-by: Srish Srinivasan <ssrish@linux.ibm.com>
Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com>
---
 arch/powerpc/platforms/pseries/plpks.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
index 896eda3eb65f..eff968fe5ae0 100644
--- a/arch/powerpc/platforms/pseries/plpks.c
+++ b/arch/powerpc/platforms/pseries/plpks.c
@@ -576,7 +576,7 @@ static int plpks_confirm_object_flushed(struct label *label,
 				 virt_to_phys(auth), virt_to_phys(label),
 				 label->size);
 
-		status = retbuf[0];
+		status = (u8)retbuf[0];
 		if (rc) {
 			timed_out = false;
 			if (rc == H_NOT_FOUND && status == 1)
@@ -870,13 +870,13 @@ static int plpks_read_var(u8 consumer, struct plpks_var *var)
 	}
 
 	if (!var->data || var->datalen > retbuf[0])
-		var->datalen = retbuf[0];
+		var->datalen = (u16)retbuf[0];
 
 	if (var->data)
 		memcpy(var->data, output, var->datalen);
 
 out_copy_policy:
-	var->policy = retbuf[1];
+	var->policy = (u32)retbuf[1];
 out_free_output:
 	kfree_sensitive(output);
 out_free_label:
-- 
2.52.0


  parent reply	other threads:[~2026-09-23 18:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 18:28 [PATCH 00/12] Refactor and harden PLPKS code Srish Srinivasan
2026-09-23 18:28 ` [PATCH 01/12] pseries/plpks: fix error handling in plpks_read_var() Srish Srinivasan
2026-09-23 18:28 ` [PATCH 02/12] pseries/plpks: fix error code for wrapping key reads Srish Srinivasan
2026-09-23 18:28 ` [PATCH 03/12] pseries/plpks: validate input to plpks_signed_update_var() Srish Srinivasan
2026-09-23 18:28 ` [PATCH 04/12] pseries/plpks: clear sensitive PLPKS buffers Srish Srinivasan
2026-09-23 18:28 ` [PATCH 05/12] pseries/plpks: clear sensitive buffers in wrapping operations Srish Srinivasan
2026-09-23 18:28 ` [PATCH 06/12] pseries/plpks: clear signed update authentication buffer Srish Srinivasan
2026-09-23 18:28 ` [PATCH 07/12] pseries/plpks: clear SED key data after use Srish Srinivasan
2026-09-23 18:28 ` [PATCH 08/12] pseries/plpks: fix self-reference in plpks_var initializer Srish Srinivasan
2026-09-23 18:28 ` [PATCH 09/12] pseries/plpks: hide wrapping_features when unsupported Srish Srinivasan
2026-09-23 18:28 ` Srish Srinivasan [this message]
2026-09-23 18:28 ` [PATCH 11/12] pseries/plpks: rename the default wrapping key macro Srish Srinivasan
2026-09-23 18:28 ` [PATCH 12/12] pseries/plpks: update PKS documentation and MAINTAINERS entry Srish Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923182816.151451-11-ssrish@linux.ibm.com \
    --to=ssrish@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=gjoyce@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=nayna@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=rnsastry@linux.ibm.com \
    --cc=sshegde@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®